Solved Zombies

hello i'm trying to make the zombie only spawn on grass not stone dirt or air

here code:

Code:java

 this.getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
public void run() {
Player[] players = main.this.getServer().getOnlinePlayers();
for (Player p : players) {
Random r = new Random();
int per = r.nextInt(3);
if(per == 1){
Location loc = p.getLocation().add(10, 0, 10);
Zombie zombie = (Zombie) p.getWorld().spawnEntity(loc, EntityType.ZOMBIE);
}
if(per == 2){
Location loc4 = p.getLocation().add(10, 0, 10);
Zombie zombie4 = (Zombie) p.getWorld().spawnEntity(loc4, EntityType.ZOMBIE);
}
}
}
}, 0, 3600);

i'd try using something like this but it didn't work

Code:java

 Material block2 = world.getBlockAt(blockX, highestBlockY - 1, blockZ).getType();
if ((!block2.equals(Material.STONE)) && (!block2.equals(Material.DIRT))) {

or is there a possible way to make them only spawn on grass?

 

Listen for CreatureSpawnEvent and cancel it if the block under it isn't grass

 

Conarnar well i'm not natural spawning them i'm spawning them around players with location.

 

Wantsome909 Well I thought CreatureSpawnEvent is called every time a mob spawns. It doesn't matter if it was natural or from a method.

 

Conarnar ok well, ill try it!

Conarnar i don't see how to cancel it if the block under it isn't grass

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:java

    @EventHandler
    public void onCreatureSpawn(CreatureSpawnEvent event)
    {
        if (!(event.getEntity().getLocation().subtract(0, 1, 0).getBlock().getType() == Material.GRASS))
        {
            event.setCancelled(true);
        }
    }

 

The_Doctor_123
so when a zombie spawn and if he spawn in the air it wont spawn?

cause when i try mine then yours it did the same things

 

Cancelling mob spawns constantly is generally a BAD idea due to minecraft's spawning nature, bergerkiller 's post: https://forums.bukkit.org/threads/important-information-regarding-cancelling-creature-spawns.147007/

 

Axe2760 well im just trying to get it so my zombie don't spawn in the air or in a wall.

 

1. That code should work. If the block below the spawned zombie is air, then the if statement would be true.
2. Why would a zombie spawn in air anyway..?

In that case, replace the cancelling of the event with:

Code:

event.getEntity().remove();

 

The_Doctor_123 right. but I'm trying to stop them from spawning in the air and losing health from fall damage.

 

The_Doctor_123 Read the post, that clearly would just make things worse. You have to stop the game from trying to spawn them altogether, before it generates things like AI, etc.

 

My code does just that.

Meh, it's only really a problem if you're cancelling a whole lot of entities from being spawned. We just have to remember that cancelling that event is costly(for now).

 

Axe2760 & The_Doctor_123 well could i just make them so when they fall they wont take any fall damage?

The_Doctor_123 you code really does not do what i said. when they spawn and there air under one zombie he wont spawn.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Yes. Just set the fall distance.

Code:

event.getEntity().setFallDistance(-50F);

 

Wantsome909
You can do multiple things. The easy way out, is to add a resistance 5 potion effect for four or so seconds -- therefore mobs spawned in air will not lose health when they fall.

You can also use a delayed task to set the health back to 20.

Finally, (the overkill) you can store the entity in a HashMap upon spawning, set a Boolean to true. Then, when the entity takes damage, check if they're in the HashMap and have the value "true", and then if they do remove them and set their health.

Come to think of it, an array or ArrayList would probably work just fine as well.

Edit: Ninja'd with a far better answer.

 

The_Doctor_123 well thank you for your help sir!

 

Axe2760
Woah, woah, woah.. no need for complicated things, just set the fall distance of the entity.

 

The_Doctor_123 Hahaha I had no idea such a method existed as well, thank you Doctor.

(I'ma stay and watch the TARDIS dematerialisation)

 

The_Doctor_123 last thing! now if i get close to a wall they will spawn in there how can i stop that?

 

Axe2760

 

The_Doctor_123 ya, no?

 

Okay, in this case.. you really should edit the code that is spawning the zombies. Can I see that code?

 

Naturally killing it is a better way