Would this work?

so im trying to make it so when a player clicks a chest it gives him 4 random items, I used some code from a minigame I made awhile back.. will it work

Code:

public ItemStack[] fillChest() {
        Material[] items1 = new Material[] { Material.GOLDEN_APPLE, Material.IRON_SWORD, Material.IRON_CHESTPLATE, Material.IRON_SWORD };
        Material[] items2 = new Material[] { Material.APPLE, Material.WOOD_SWORD, Material.LEATHER_CHESTPLATE, Material.BOW, Material.ARROW, Material.STONE_SWORD, Material.DIAMOND, Material.LEATHER_BOOTS, Material.IRON_INGOT };
       
        Random r = new Random();
       
        int numItems = r.nextInt(5) + 1; // A random number between 1 and 5.
       
        for (int i = 0; i < numItems; i++) {
            Material material = null;
           
            if (tier == 1) {
                material = items1[r.nextInt(items1.length)]; // A random Materials from the items1 array.
            }
           
            else if (tier == 2) {
                material = items2[r.nextInt(items2.length)]; // A random Materials from the items2 array.
            }
           
            ItemStack item = new ItemStack(material, 1);
           
            int index;
           
            do {
                index = r.nextInt(chest.getInventory().getSize());
            } while (chest.getInventory().getItem(index) != null);
           
            chest.getInventory().setItem(index, item);
        }
        return null;
        }

Code:

if (e.getInventory().getHolder() instanceof Chest && canOpen.containsKey(p) && p.isSneaking()){
           e.setCancelled(true);
          
           p.getInventory().addItem(fillChest());

 

@XgXXSnipz Try it.

 

@Skionz nope.. no work it doesnt even send a message when I place down my chest

 

@XgXXSnipz I don't see you ever send a message in the method you posted.

 

@Skionz

Code:

@EventHandler
    public void onBreak(BlockBreakEvent e){
        Player p = e.getPlayer();
       
        if(e.getBlock().equals(Material.CHEST) && p.isOp()
                && p.isSneaking() || chestPlaced.containsKey(p)){
            e.getBlock().breakNaturally();
           
            p.sendMessage(ChatColor.YELLOW + "[" + ChatColor.BLUE + "NetherFactions" + ChatColor.YELLOW + "]" + ChatColor.GREEN + "Randomized Item chest destroyed!");
        }else
            return;
       
    }
   
    @EventHandler
    public void onJoin(PlayerJoinEvent e){
        Player p = e.getPlayer();
        canOpen.put(p, p);
        if(canOpen.containsKey(p)){
            return;
        }
    }
   
    @EventHandler
    public void onPlace(BlockPlaceEvent e){
        Player p = e.getPlayer();
       
        if(e.getBlock().equals(Material.CHEST) && p.isOp() && p.isSneaking()){
            p.sendMessage(ChatColor.YELLOW + "[" + ChatColor.BLUE + "NetherFactions" + ChatColor.YELLOW + "]" + ChatColor.GREEN + "Randomized Item chest placed!");
           
            chestPlaced.put(p, p);
           
        }else
        return;
    }
    

 

@XgXXSnipz Is your Listener registered?

 

@Skionz its all in one class,

Code:

Bukkit.getServer().getPluginManager().registerEvents(this,this);

 

@XgXXSnipz Put in debug code

 

@teej107 I did... it no work still

EDIT: does work just not the chest placing and stuff

 

No { after else try now

 

@XgXXSnipz

Code:

e.getBlock().equals(Material.CHEST)

I'm not a java expert, but I think a block can't be equals to a Material

 

@Konato_K @BaconStripzMan great tips, I try!

@Konato_K

Code:

if(e.getBlock().equals(Chest.class)

would that work?

 

@XgXXSnipz A Block isn't a class.

 

They can @XgXXSnipz is it working?

 

@Skionz well IDK what to put.... I cant do

Code:

BLock.

 

Material.CHEST

 

They can't.

 

oh..

 

@BaconStripzMan No they can't, this is the code for equals in CraftBlock

Code:

public boolean equals(Object o)
  {
  if (o == this) return true;
  if (!(o instanceof CraftBlock)) return false;
  CraftBlock other = (CraftBlock)o;

  return (x == other.x) && (y == other.y) && (z == other.z) && (getWorld().equals(other.getWorld()));
  }

I don't think Material extends CraftBlock

@XgXXSnipz Try getting the type of the block and comparing that instead?

 

@BaconStripzMan ok I try now

 

@XgXXSnipz Read the above messages. It won't work. The solution is to compare the type to a different Material.

 

No my solution was he didnt have a { after else

 

@Konato_K @BaconStripzMan @Skionz ok so how would I get the "type" of block placed down

 

Its only one line. There doesn't need to be any brackets.
@XgXXSnipz I wonder if the Block#getType method will work

 

@XgXXSnipz Check the javadocs http://jd.bukkit.org/rb/apidocs/org/bukkit/block/Block.html

TIP: It's something related to "get" and "type"

 

@Konato_K @Skironz omfg i dumb

 

@Konato_K @Skionz this is what I came up with

Code:

Block.getById(54))

 

Looks good, does it work?

 

@BaconStripzMan testing now EDIT: Keep timing out on my server, may not be able to test

 

Wanna send it to me? I can test, just keep trying to join