Worldguard pr.getId().startsWith return false

Hi all, for my plugin, I use a Worldguard listener to check if the player was in a region that start with "music_"

For that, I use

Code:java

if (pr.getId().startsWith("music_") == true && regionname == pr.getId()) {

That work, but only if the player was in one region.

If the player was in the region (For exemple) Spawn and music_spawn at the same time, that will not work, the condition

Code:java

(pr.getId().startsWith("music_")

will return false.


How can I do to do that ?
Thank.

up

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

splint
I'm not familiar with WorldGuard, however, if possible iterate through the regions and if the regions id starts with "music_" then do what you want with the player.

 

But I don't know how to do that too

 

splint
You do not know how to iterate over a list? I have pretty much confirmed that you don't know Java. Please learn Java before going into the Bukkit API, or any API for that matter.

 

Please post more of your code so I can help you cause I have no clue what pr is. splint

 

This is all my Listener code...

Code:java

package com.minecamp.spouties;
 
import java.util.Iterator;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerMoveEvent;
import org.getspout.spoutapi.SpoutManager;
import org.getspout.spoutapi.player.SpoutPlayer;
import org.getspout.spoutapi.sound.SoundManager;
 
import com.sk89q.worldguard.bukkit.WorldGuardPlugin;
import com.sk89q.worldguard.protection.ApplicableRegionSet;
import com.sk89q.worldguard.protection.regions.ProtectedRegion;
 
public class EnteringRegion implements Listener {
Spouties plugin;
public EnteringRegion(Spouties instance) {
plugin = instance;
}
public static int c = 0;
public static int spawnonit;
public static String regionname;
public static int loop1;
public static int b = 0;
public static String i = null;
public static int enter = 0;
public static int time;
public static String url;
public static String region = null;
private WorldGuardPlugin getwg() {
WorldGuardPlugin pl = (WorldGuardPlugin) Bukkit.getPluginManager().getPlugin("WorldGuard");
if((WorldGuardPlugin) Bukkit.getPluginManager().getPlugin("WorldGuard") != null){
return ((WorldGuardPlugin)pl);
}
else
{
}
return null;}
 
@SuppressWarnings("deprecation")
@EventHandler(priority = EventPriority.NORMAL)
public void onPlayerMove(PlayerMoveEvent event) {
final Player p = event.getPlayer();
if (p.getWorld().getName().equalsIgnoreCase("world") == true) {
ApplicableRegionSet ar = this.getwg().getRegionManager(p.getWorld()).getApplicableRegions(p.getLocation());
Iterator<ProtectedRegion> prs = ar.iterator();
if(prs.hasNext() == false)
{enter = 0;
b = 0;
c = 0;
if (Spouties.musiccommand == 0){
SoundManager music = SpoutManager.getSoundManager();
music.stopMusic((SpoutPlayer) p, true);
Bukkit.getScheduler().cancelTask(loop1);}}
while (prs.hasNext()) {
ProtectedRegion pr = prs.next();
 
if (pr.getId().startsWith("music_") == true && regionname == pr.getId()) {
String i = pr.getId();
if (i != null){
enter = 1;
url = plugin.getConfig().getString("url." + i);
String timestring = plugin.getConfig().getString("time." + i);
if (timestring != null){
time = Integer.parseInt(timestring);
time = time*20;
}
if (b==0){
b = 1;
if (url != null && timestring !=null) {
regionname = pr.getId();
loop1 = plugin.getServer().getScheduler().scheduleAsyncRepeatingTask(plugin, new Runnable() {
public void run() {
SoundManager music = SpoutManager.getSoundManager();
music.stopMusic((SpoutPlayer)p, true, 1000);
Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(plugin, new Runnable() {
public void run() {
SoundManager music = SpoutManager.getSoundManager();
Bukkit.getScheduler().cancelTask(Spouties.loop);
music.playCustomMusic(plugin, (SpoutPlayer)p, url, true);
Spouties.musiccommand = 0;
}
}, 20);
 
}
}
, 0L, time);
}else{
enter = 0;
b = 0;
if (Spouties.musiccommand == 0){
SoundManager music = SpoutManager.getSoundManager();
music.stopMusic((SpoutPlayer)p);
Bukkit.getScheduler().cancelTask(loop1);}}
p.sendMessage(ChatColor.RED + "bad");
}
}
}
 
else {
regionname = pr.getId();
enter = 0;
b = 0;
if (Spouties.musiccommand == 0){
SoundManager music = SpoutManager.getSoundManager();
music.stopMusic((SpoutPlayer)p);
p.sendMessage(ChatColor.RED + "bad1");
Bukkit.getScheduler().cancelTask(loop1);}}
 
 
if (pr.getId().startsWith("music_") == true && spawnonit == 0) {
spawnonit = 1;
String i = pr.getId();
if (i != null){
enter = 1;
url = plugin.getConfig().getString("url." + i);
String timestring = plugin.getConfig().getString("time." + i);
if (timestring != null){
time = Integer.parseInt(timestring);
time = time*20;
}
if (b==0){
b = 1;
if (url != null && timestring !=null) {
regionname = pr.getId();
 
loop1 = plugin.getServer().getScheduler().scheduleAsyncRepeatingTask(plugin, new Runnable() {
public void run() {
SoundManager music = SpoutManager.getSoundManager();
music.stopMusic((SpoutPlayer)p, true, 1000);
Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(plugin, new Runnable() {
public void run() {
SoundManager music = SpoutManager.getSoundManager();
Bukkit.getScheduler().cancelTask(Spouties.loop);
music.playCustomMusic(plugin, (SpoutPlayer)p, url, true);
Spouties.musiccommand = 0;
}
}, 20);
 
}
}
, 0L, time);
}
else{
enter = 0;
if (Spouties.musiccommand == 0){
SoundManager music = SpoutManager.getSoundManager();
music.stopMusic((SpoutPlayer)p);
Bukkit.getScheduler().cancelTask(loop1);}}
}
}
}
else if (pr.getId().startsWith("se_")){
String i = pr.getId();
if (i != null){
url = plugin.getConfig().getString("url." + i);
if (c==0){
c = 1;
if (url != null){
SoundManager music = SpoutManager.getSoundManager();
music.playCustomSoundEffect(plugin, (SpoutPlayer)p, url, plugin.getConfig().getBoolean("notify.playeffect"));
}
else{}
}
}
}
else{
c = 0;
}
}
}
}
 
}

If I ask how to do that and you answer "Learn it", what the utility of the forum ?

 

Stop comparing strings using ==.

 

Now I use .equals() but this will not solve my problem

 

splint You're right, there's no point fixing problems, you have a different problem.

Also, comparing two strings with == can very easily return false when you're expecting true. How do you know that it's not what's causing your problem?

Either way, as has been said, please learn Java or else you will run into simple problems all the time. Trust me.

 

AdamQpzm
I know why this return false, but I don't know how to fix it.

When I'm in 2 regions on the same time, pr.getId() will return a list like
- music_spawn
- spawn

and if I check with .startWith, worldguard return false and not true, because they don't have only one region.

I try with pr.getId().contains, but same result

 

splint But you're iterating through the regions? Also, you don't "know" since you aren't a java runtime environment and you have no debug messages - for all you know the startsWith() check could've been returning true, but the == could have been returning false. Please learn Java, it'll help, and should stop you from using the bad practices you're using at the moment.

splint Look, that's the problem you have. Do you think you're making a plugin? You're not, really. You're mostly copying from other sources without understanding what it means or what it does. To prove that point... you ask if you should iterate over it? Well, what do you think prs is in your code? It's an iterator!

Please learn Java before using the Bukkit API, because otherwise you will encounter problems that you don't know how to solve, and the extend of your abilities will be mostly copied code.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

AdamQpzm
I know prs was an iterator, I just see it, and i'm trying to work with it.
I learn java by doing some stuff, test some fonctions, etc. I do that just for myself, for my server, and I don't really want to learn all the java methods for years, because I work just for this little project. I take some code, here, because I don't know how to make the worldguard listener, and I try to understand how this function work, etc.
Every time I ask something, everybody say "Go learn java". That s**k.

 

What word is this supposed to be? o.o

Also, the reason people tell you to learn Java, regardless of whether or not you like it, is because you have to know Java in order to make things work. Let's assume that poems could only be written in English, as Bukkit plugins can only be written in Java - would you learn how to write a poem before learning how to write (at least the basics of) English? No, you wouldn't. Java & Bukkit is no different.

As for your problem, it might be caused by the fact you never terminate the loop early, even if it finds such a region.