Working with errors :/

Hi i have a inventroy gui plugin, but i got errors
It working perfectly but i wont errors.
Here is that part that is giving me errors:

Code:java

@EventHandler
public void click(InventoryClickEvent event) {
Player p = (Player) event.getWhoClicked();
if (event.getInventory().getTitle().equals(null)) {
event.setCancelled(true);
}
if (event.getCurrentItem().getType().equals(Material.STONE_SWORD)) {
p.performCommand("pvp");
event.setCancelled(true);
}
if (event.getCurrentItem().getType().equals(Material.BOW)) {
p.performCommand("archer");
event.setCancelled(true);
}
else {
return;
}
}
}
 

Error:

 

What is line 61?

 

What do you mean?

 

Alright an you show us line 61 of your 'Main' class please? Also, I can see why when you right click the stone sword or the bow, nothing will happen. The way you're doing it seems a bit odd. So just to make sure, does ot work when you right click the sword or the bow? If not I can easily help you, jist remember to tag me Monkey_Swag!

 

Oh, here:

Code:java

if (event.getCurrentItem().getType().equals(Material.STONE_SWORD)) {

 

In your error it says <Main.Java:61> http://forums.bukkit.org/threads/ho...ubleshoot-your-own-plugins-by-yourself.32457/

 

if (event.getCurrentItem().getType().equals(Material.STONE_SWORD)) {

 

And a inventory can never be null.
What is your custom inventory called?
Can you show us the full code?

 

Code:java

public static Inventory inv = null;

So i think the name is inv

 

Stackore
Replace that with:
if(event.getAction() == RIGHT_CLICK_AIR /*or right click block*/ && p.getItemInHand().getType() == Material.STONE_SWORD){
//do the code
}
EDIT: ninja'd 4 lyfe

 

Your inventory is null?
Show your full code. I need to see where you created your inventory

 

Code:java

package me.kitgui;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
 
    public static Inventory inv = null;
 
    public void onEnable() {
        this.getServer().getPluginManager().registerEvents(this, this);
        this.getLogger().info("KitGUI = Enable");
        createInventoryGUI();
 
    }
 
    public void createInventoryGUI() {
        inv = Bukkit.createInventory(null, 9, "hej");
 
        ItemStack pvp = new ItemStack(Material.STONE_SWORD, 1);
        ItemMeta pvpmeta = pvp.getItemMeta();
        pvpmeta.setDisplayName(ChatColor.AQUA + "" + ChatColor.ITALIC + "PvP");
        pvp.setItemMeta(pvpmeta);
 
        ItemStack archer = new ItemStack(Material.BOW, 1);
        ItemMeta archermeta = archer.getItemMeta();
        archermeta.setDisplayName(ChatColor.AQUA + "" + ChatColor.ITALIC + "Archer");
        archer.setItemMeta(archermeta);
 
        inv.setItem(0, pvp);
        inv.setItem(1, archer);
    }
 
    @EventHandler
    public void interact(PlayerInteractEvent event) {
        Player p = event.getPlayer();
        if (p.getItemInHand().getType() == Material.PAPER) {
                event.setCancelled(true);
                p.openInventory(inv);
        }
    }
 
    @EventHandler
    public void click(InventoryClickEvent event) {
        Player p = (Player) event.getWhoClicked();
        if (event.getInventory().getTitle().equals(null)) {
            event.setCancelled(true);
        }
    if (event.getCurrentItem().getType().equals(Material.STONE_SWORD)) {
    p.performCommand("pvp");
    event.setCancelled(true);
    }
    if (event.getCurrentItem().getType().equals(Material.BOW)) {
        p.performCommand("archer");
    event.setCancelled(true);
    }
    else {
    return;
    }
    }
    }
 

Full code

Hmm i get error on

Code:java

== RIGHT_CLICK_AIR 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Stackore the

Code:java

event.getCurrentItem()

can be null, so if you try to do something with it, in your case get the Type, it will throw an NPE.
The way to solve this, is as follows:

Code:java

if (event.getCurrentItem() != null && event.getCurrentItem().getType == Material.BOW) {
//do stuff
}

and, don't use .equals() for enums, but use the == operator.

 

This should work

Code:

 @EventHandler
    public void click(InventoryClickEvent event) {
        Player p = (Player) event.getWhoClicked();
        if (event.getInventory().getTitle().equals("hej")) {
    if (event.getCurrentItem().getType().equals(Material.STONE_SWORD)) {
    p.performCommand("pvp");
    event.setCancelled(true);
    }
    if (event.getCurrentItem().getType().equals(Material.BOW)) {
        p.performCommand("archer");
    event.setCancelled(true);
    }
    }
    }

You can do event.getCurrentItem().getType().equals(Material.STONE_SWORD);
It has never gave me an error

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

When i choose a kit and then right or left click with the bow or sword the error appears!

 

did you use my code?
and if yes send me the error

 

Now it's working withouts errors! Thanks alot

 

With my code XD

 

Yes! And i just got a new error -.-
Can you please try to fix it
Code:

Code:java

@EventHandler
        public void TP(EntityDamageByEntityEvent e) {
            final Player p = (Player) e.getEntity();
            final Player d = (Player) e.getDamager();
            if (d instanceof Player)
            {
                if (Enderman.contains(d.getName()))
                {
                    if (d.getItemInHand().getType() == Material.EYE_OF_ENDER)
                    {
                            if (!cooldown.contains(d))
                            {
                d.teleport(p.getLocation());
                d.getWorld().playSound(d.getLocation(), Sound.ENDERDRAGON_HIT, 1, 1);
                d.getWorld().playEffect(d.getLocation(), Effect.ENDER_SIGNAL, 1, 1);
                d.sendMessage(ChatColor.GREEN + "" + ChatColor.ITALIC + "Woosh");
                p.sendMessage(ChatColor.RED + "" + ChatColor.ITALIC + "En Enderman har slagit dig!");
                cooldown.add(d);
                c.setList(cooldown);
                c.setPlayer(d);
                new Thread(c).start();

Error:

I am sorry i'm just a begginer xD

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

What is the line where it gives the error?

 

120 i think

 

What is line 120?

 

When i hit a mob with another item than eye of ender it gives error. That code is for players usually
And it works great when i hit a player

final Player p = (Player) e.getEntity();

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

why do you set it to final?

You don't need to cast it to a player
final Player p =(Player) e.getEntity(); do

Code:

Player p = event.getEntity();

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Yea idk why i casted it into a player but i get errors if i don't cast it to a player (errors in eclpise)

 

HAHA an Entity is not a player
I was so stupid
Use

Code:

Entity d = event.getEntity();

 

But i want it to be a player

 

this are the things you need to use

Code:

Entity p = e.getEntity();
Player d = e.getDamager();

just try it it should work

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Player d = (Player) e.getDamager(); if i don't have the cast i got errors in eclipse

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

you can try it on your bukkit server but if it doesn't work use:

Code:

Entity d = e.getDamager(); 

because you are using EntityDamageByEntityEvent

This is what your event should look like

Code:

@EventHandler
    public void TP(EntityDamageByEntityEvent e) {
        Entity p = e.getEntity();
        Entity d = e.getDamager();
        if (d instanceof Player)
        {
            if (Enderman.contains(d.getName()))
            {
                if (d.getItemInHand().getType() == Material.EYE_OF_ENDER)
                {
                        if (!cooldown.contains(d))
                        {
            d.teleport(p.getLocation());
            d.getWorld().playSound(d.getLocation(), Sound.ENDERDRAGON_HIT, 1, 1);
            d.getWorld().playEffect(d.getLocation(), Effect.ENDER_SIGNAL, 1, 1);
            d.sendMessage(ChatColor.GREEN + "" + ChatColor.ITALIC + "Woosh");
            p.sendMessage(ChatColor.RED + "" + ChatColor.ITALIC + "En Enderman har slagit dig!");
            cooldown.add(d);
            c.setList(cooldown);
            c.setPlayer(d);
            new Thread(c).start();
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.