Why won't this work.

Hi this is not working as I expected.. I want it so when they have the permission node it says the join msg.. But for some reason it doing it without the permission and everyone gets the join message? I cannot seem to find out why this isn't working.

Code:java

package me.sean0402.join;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public final class Join extends JavaPlugin implements Listener {
 
              public void onEnable() {
                  Bukkit.getServer().getPluginManager().registerEvents(this, this);
              saveDefaultConfig();
              }
 
              @EventHandler
              public void onJoin(PlayerJoinEvent event){
                      for (Player player: Bukkit.getServer().getOnlinePlayers()) {
 
                            if (player.hasPermission("joinmessage.join")) {
                                event.setJoinMessage(getConfig().getString("test").replace("&", "§").replace("%player%", player.getDisplayName()));
                          } else {
                          event.setJoinMessage("");
                          }
                  }
 
        }
 
        @EventHandler
          public void onQuit(PlayerQuitEvent event) {
                  event.setQuitMessage("");
                }
 
} 

 

Sean0402
The Event join message can't be changed for some players but not others. You have to set the join message to "" at the beginning, then loop through all players, if they have permission send them a message with Player#sendMessage()

 

AoH_Ruthless How do you loop through the players?

 

Sean0402
You already know how because you have done it already in your code.

 

AoH_Ruthless My friend done this for me and I tried to find out why it don't work.. but I cant

Code:java

package me.sean0402.join;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public final class Join extends JavaPlugin implements Listener {
 
              public void onEnable() {
                  Bukkit.getServer().getPluginManager().registerEvents(this, this);
              saveDefaultConfig();
              }
 
              @EventHandler
              public void onJoin(PlayerJoinEvent event){
                      for (Player player: Bukkit.getServer().getOnlinePlayers()) {
                          event.setJoinMessage("");
                            if (player.hasPermission("joinmessage.join")) {
                                event.setJoinMessage(getConfig().getString("test").replace("&", "§").replace("%player%", player.getDisplayName()));
                          } else {
                          event.setJoinMessage("");
                          }
                  }
 
        }
 
        @EventHandler
          public void onQuit(PlayerQuitEvent event) {
                  event.setQuitMessage("");
                }
 
} 

 

You don't need the for loop... e.setJoinMessage("") already broadcasts it to all the players.

 

Sean0402
If you don't know what a loop is, you should learn Java first....

Read everything about Control Flow Statements here: http://docs.oracle.com/javase/tutorial/java/nutsandbolts/flow.html

Edit:
macboinc
The for loop is necessary to send certain players a certain message (looping to see which players have permission).

 

This also might be an error, but at the top of your event where the EventHandler annotation is, do:

Code:java

@EventHandler(priority = EventPriority.MONITOR)

Gosh you reply fast...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:java

 @EventHandler
public void onJoin(PlayerJoinEvent event){
 
for (Player player: getServer().getOnlinePlayers()) {
if (player.hasPermission("this.person.has.permission")) {
player.sendMessage(getConfig().getString("test").replace("&", "§").replace("%player%", player.getDisplayName()));
}
}
event.setJoinMessage(null);
}

Set the join message to null then loop though all the players online and see if player 'player' has the permission node "this.person.has.permission" if they do send them the join message.

 

Still doesn't work.. :/

Code:java

package me.sean0402.join;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public final class Join extends JavaPlugin implements Listener {
 
              public void onEnable() {
                  Bukkit.getServer().getPluginManager().registerEvents(this, this);
              saveDefaultConfig();
              }
 
              @EventHandler(priority = EventPriority.MONITOR)
              public void onJoin(PlayerJoinEvent event){
                      for (Player player: Bukkit.getServer().getOnlinePlayers()) {
                            if (player.hasPermission("joinmessage.join")) {
                                event.setJoinMessage(getConfig().getString("test").replace("&", "§").replace("%player%", player.getDisplayName()));
                          }
                          event.setJoinMessage(null);
                          }
                  }
 
 
        @EventHandler
          public void onQuit(PlayerQuitEvent event) {
                  event.setQuitMessage("");
                }
 
} 

 

well look good what shawshark sad on line 5

Code:java

if (player.hasPermission("this.person.has.permission"))

 

1. You're using EventPriority.MONITOR incorrectly. This is explained here.
2. Why is your class final? Try removing the final modifier.
3. You're getting string "test" from the config. You never specified any defaults, so it isn't there unless you added it manually.
4. If 1 person online has the permission, you're setting the join message to that for every player. setJoinMessage sets the join message for everybody. Use player.sendMessage();.

 

wolfs25 are you talking about the player.sendmessage? I need it to be a join message.. So say a donator joins "[Pro+] Sean0402 Has Joined The Hub!"

SmooshCakez is there a way to make it work? With Event.setjoinmessage so it only works for my donators..

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

No, there isn't. event.setJoinMessage(); sets the message to all players. Try looping through the players with the permission and sending them the join message with player.sendMessage();

If you mean to make it so that the join message is displayed to everyone if the player who joined has the permission, check if they have the permission and then use event.setJoinMessage();

 

wel u can also can use essentials on config.yml line 367 change "{PLAYER} &ejoined the game" just saying

 

SmooshCakez that is checking if they have the perms isn't it? Then sending the join msg?

wolfs25 yes but how do I make it so it only says it for donors?

 

bump

 

Sean0402 Player has a convenient sendMessage(String) method for sending messages. Just loop over all Players online, check if they have the perm, and if so, send the join message. Also, set the join message to null to prevent it from sending to people in general, to prevent duplicate join messages. Moreover, use ChatColor.translateAlternateColorCodes('&', message) for colouring your messages.
SmooshCakez final classes wouldn't cause any issues. Moreover, it's his main class, why would he need to be able to extend it in the first place.