why is this null again?

so, why is this null?

Code:java

private int goldAmount(Player player) {
    int sendme = 0;
    for (ItemStack is : player.getInventory().getContents()) {
        if (is.getTypeId() == 266) { // this line
            sendme = sendme + is.getAmount();
        }
    }
    return sendme;
}

 

Are you sure that the player is being passed correctly?

Also, I've never used getContents(), but does it get only the slots with items in, or does it return also empty slots (which wouldn't have a TypeId)?

 

Can we see the exception you get?

 

player.getInventory().getContents() will always return 32 item stacks. So you need to test for null on each one, before trying to do anything. any empty slot in the inventory will come back as a null, rather than a valid ItemStack

 

if (is != null && is.getTypeId() == 266) { // this line

 

Give them a chance to solve the problem themselves, else they won't really learn. Rather than just giving them fixed code, that just leads to more questions about other topics.

 

Adding on to what everyone else said. This shouldn't change anything, but it is good practice. Whenever using foreach loops you should make the variable final.

private int goldAmount(Player player) {
int sendme = 0;
for (final ItemStack is : player.getInventory().getContents()) {
if (is.getTypeId() == 266) { // this line
sendme = sendme + is.getAmount();
}
}
return sendme;
}

 

Why?

 

Well it's proper programming. The variable is redefined so it makes sense to make it final, since is keeps getting created then destroyed.