Solved While loop with scheduler doesn't work ?

Hi. Is it possible to use a while statement combined with a scheduler? When I use the code below, it crashes my server:

Code:java

 
    @EventHandler
    public void toggleSneak(PlayerToggleSneakEvent event) {
        final Player player = event.getPlayer();
        player.sendMessage("Toggled sneaking");
        while (player.isSneaking()) {
            Bukkit.getScheduler().runTaskLater(plugin, new Runnable() {
                @Override
                public void run() {
                    player.sendMessage("You're sneaking"); //send this every 2 seconds while the player is sneaking
                }
            }, 40L);
        }
    }
 

Any help is appreciated, thanks!

 

It should be possible. Something is making the statement think the player is sneaking while they're not if it keeps going.

 

Jake6177
Yeah that's what I was thinking. What can I do about this?

 

Hmm...maybe at the top:

player.sendMessage("toggled " + (player.isSneaking()) ? "on":"off");

See if it correctly changes from on to off?

 

Well when I first hold the shift key down is displays the 'Toggled sneaking' message; then when I let go it displays it again. Any idea?

 

idea!

how about (psuedocode):

if player is sneaking
make a repeating runnable for every 2 seconds
in runnable check if sneaking
if no longer sneaking, cancel task

 

Alright I'll try that, thanks!

Jake6177 This is very strange but I have another while loop with a scheduler in another plugin and it seems to lag out and crash as well. It certainly is very strange:

Code:java

 
                        final int cooldownPlayer = plugin.getCustomConfig().getInt("Shoot Cooldown." + player.getName() + ".Time Remaining");
                        while (cooldownPlayer != 0) {
                            Bukkit.getScheduler().runTaskLater(plugin, new Runnable() {
                                @Override
                                public void run() {
                                    plugin.getCustomConfig().set("Shoot Cooldown." + player.getName() + ".Time Remaining", cooldownPlayer - 1);
                                    plugin.updateCustomConfig(true);
                                    player.sendMessage("2 - Looped: " + cooldownPlayer);
                                }
                            }, 20L);
                        }
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Yeah I totally agree with you it's very odd..

 

ThunderWaffeMC Jake6177 How is that weird? That while loop doesn't wait for the scheduled task to end, it keeps going until cooldownPlayer = 0, which happends in 1 second, AFTER ~5000 tasks are already generated.

 

I would have thought that the loop would have executed the full way before restarting? Otherwise the loop would execute in 1 hit and that isn't appropriate for my needs.

 

You don't need the while loop, that will continuously schedule tasks. You want to check, within the run method, if the player is sneaking. Also, only schedule the task once, so that it isn't scheduled every time a player toggles sneaking:

Code:java

 
public class SomePlugin extends JavaPlugin implements Listener {
    @Override
    public void onEnable() {
 
        getServer().getScheduler().scheduleSyncRepeatingTask(plugin, new Runnable() {
            @Override
            public void run() {
                for (Player player : SomePlugin.this.getServer().getOnlinePlayers()) {
                    if (player.isSneaking() {
                        player.sendMessage("You're sneaking"); //send this every 2 seconds while the player is sneaking
                    }
                }
            }
        }, 40L, 40L);
    }
 
@EventHandler
public void toggleSneak(PlayerToggleSneakEvent event) {
    event.getPlayer().sendMessage("Toggled sneaking");
}
 
 

Same issue, do a repeating scheduler and include a check inside it. You're continuously scheduling tasks, which would overload the server.