When typing in command, keep on getting the same command in chat

main class

Show Spoiler Hide Spoiler

Code:java

 
package me.ChumChumx.Cuicide;
 
import org.bukkit.command.CommandSender;
import org.bukkit.command.ConsoleCommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Cuicide extends JavaPlugin {
 
@Override
public void onDisable() {
System.out.println("[Cuicide] Has been Disabled!");
 
}
 
@Override
public void onEnable() {
System.out.println("[Cuicide] Has Been Enabled!");
}
 
public boolean onCommandEvent(ConsoleCommandSender sender, CommandSender cmd,
String commandLabel, String[] args) {
Player player = ((Player)sender);
if (cmd.getName().equalsIgnoreCase("die")) {
if(player.hasPermission("Cuicide.die")){
player.setHealth(0);
this.getServer().broadcastMessage("PlayerName just did Suicide!");
return true;
} else {
player.sendMessage("WHY YOU TRY AND DO SUICIDE?");
}
}
return false;
} }
 
 
 
 

The plugin.yml

Show Spoiler Hide Spoiler

Code:

name: Cuicide
main: me.ChumChumx.Cuicide.Cuicide
version: 0.1
commands:
    die:
      description: does suicide
      aliases: d
      usage: /<command>

 

Your command handling method seems to look funny.
Here is how I would handle commands in your case:

Code:

public boolean onCommand(CommandSender sender, Command command, String commandLabel, String[] args)
{
     // stuff...
     //
    
     if (command.getName().equals("die"))
     {
          // more stuff...
          //
     }
     else
     {
          // even more stuff...
          //
     }
}

 

What Slayer said and be sure nesting of code is proper. I can't really tell because of your strange formatting, but you may be returning false even if the player has permission to use the command. Try this:

Code:

public boolean onCommand(CommandSender sender, Command command, String commandLabel, String[] args){
    // Check if sender is player...
    Player p = (Player) sender;
 
    if (command.getName().equals("die") && p.hasPermission("Cuicide.die")) {
          // Execute code
          return true;
    } else {
          return false;
    }
}

 

This is your entire code, copy and paste it.

Code:

package me.ChumChumx.Cuicide;
 
import org.bukkit.command.CommandSender;
import org.bukkit.command.ConsoleCommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Cuicide extends JavaPlugin {
 
@Override
public void onDisable() {
System.out.println("[Cuicide] Has been Disabled!");
 
}
 
@Override
public void onEnable() {
System.out.println("[Cuicide] Has Been Enabled!");
}
public boolean onCommandEvent(ConsoleCommandSender sender, CommandSender cmd,
String commandLabel, String[] args) {
Player player = ((Player)sender);
String PlayerName  = sender.getName();
if (cmd.getName().equalsIgnoreCase("die") && sender.hasPermission("Cuicide.die")) {
player.setHealth(0);
this.getServer().broadcastMessage(PlayerName + "just did Suicide!");
return true;
} else {
player.sendMessage("WHY YOU TRY AND DO SUICIDE?");
}
return false;
} }

BTW i only helped because I wanted help like this before...
Basically what the plugin you made and i fixed does, is that it checks if the player typed /die and it also checked if it had permission. && means and, its kinda like redstone logic gates... If 1 is true and 1 is true then the statement is true, if the player typed /die and he has permissions then set his health to 0. If the player type /die and doesn't have permission then display else (why you try and do suicide). || aka OR, if the player typed /die or has permission, as long as one of those is true then the whole statement is true, If you use OR in the specific statement you used, you could simply remove permission support and it'd let everyone kill themselves. But this is was a good lesson for permissions for you.

 

Im just a beginner , i just learned all this stuff a couple of days ago, this is my first plugin
Thanks for the help

It gives me an error for PlayerName

Show Spoiler Hide Spoiler

Code:

DescriptionResourcePathLocationType
The value of the local variable PlayerName is not usedCuicide.java/Cuicide/src/me/ChumChumx/Cuicideline 24Java Problem

This is the main class right now.

Show Spoiler Hide Spoiler

Code:java

 
package me.ChumChumx.Cuicide;
 
import org.bukkit.command.CommandSender;
import org.bukkit.command.ConsoleCommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Cuicide extends JavaPlugin  {
 
@Override
public void onDisable() {
System.out.println("[Cuicide] Has been Disabled!");
 
}
 
@Override
public void onEnable() {
System.out.println("[Cuicide] Has Been Enabled!");
}
 
public boolean onCommandEvent(ConsoleCommandSender sender, CommandSender cmd,
String commandLabel, String[] args) {
Player player = ((Player)sender);
String PlayerName = sender.getName();
if (cmd.getName().equalsIgnoreCase("die") && sender.hasPermission("Cuicide.die")) {
player.setHealth(0);
this.getServer().broadcastMessage("PlayerName just did Suicide!");
return true;
} else {
   player.sendMessage("WHY YOU TRY AND DO SUICIDE?");
}
return false;
} }
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:

String PlayerName  = sender.getName(); [/CODE
 
Add this under Player player = sender.getName();
 
You wouldn't have ran into that error if you just copying it :p

 

Why does everyone use cmd.getName(); ?
There's a dedicated parameter, String label, which does the same thing o-o

 

I like to learn, by typing it

Okay, i copied and pasted, this is what i get.

Show Spoiler Hide Spoiler

Code:

DescriptionResourcePathLocationType
The value of the local variable PlayerName is not usedCuicide.java/Cuicide/src/me/ChumChumx/Cuicideline 24Java Problem

same thing...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

It doesn't do the same thing. Example:
Command b is an alias of a.
When a player types /b, the label = b; cmd.getName() = a.
When a player types /a, label = a; cmd.getName() = a.

So: label represents the alias, cmd.getName(): the regular command

 

I fixed it, fixed the plugin.yml and still, repeats the command in the chat!

The main class:

Show Spoiler Hide Spoiler

Code:java

 
package me.ChumChumx.Cuicide;
 
import org.bukkit.command.CommandSender;
import org.bukkit.command.ConsoleCommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Cuicide extends JavaPlugin {
 
@Override
public void onDisable() {
System.out.println("[Cuicide] Has been Disabled!");
 
}
 
@Override
public void onEnable() {
System.out.println("[Cuicide] Has Been Enabled!");
}
public boolean onCommandEvent(ConsoleCommandSender sender, CommandSender cmd,
String commandLabel, String[] args) {
Player player = ((Player)sender);
String PlayerName  = sender.getName();
if (cmd.getName().equalsIgnoreCase("die") && sender.hasPermission("Cuicide.die")) {
player.setHealth(0);
this.getServer().broadcastMessage(PlayerName + "just did Suicide!");
return true;
} else {
player.sendMessage("WHY YOU TRY AND DO SUICIDE?");
}
return false;
} }
 

And the plugin.yml

Show Spoiler Hide Spoiler

Code:

name: Cuicide
main: me.ChumChumx.Cuicide.Cuicide
version: 0.1
commands:
    die:
      description: Allows you to do suicide
      permission: Cuicide.die
      usage: /<command>
      aliases: d

 

I compile in JavaSE-1.6... That may be the issue. Since I'm on mac It would be stupid to use Java-7.

 

I use JavaSE-1.7
EDIT: so use JaveSE-1.6

 

Do NOT reference the name of the player from the CommandSender. Be sure to reference the player's name from the Player. That is your issue.

Replace:

Code:

String playerName = sender.getName();

With:

Code:

String playerName = player.getName();

What you should have:

Code:

Player player = (Player) sender;
String playerName  = player.getName(); // Use lowercase on instances of classes. Use uppercase on class names

 

Oh, okay

 

ugh. still same thing, show's it in the chat..

main class... again.

Show Spoiler Hide Spoiler

Code:java

 
package me.ChumChumx.Cuicide;
 
import org.bukkit.command.CommandSender;
import org.bukkit.command.ConsoleCommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Cuicide extends JavaPlugin {
 
@Override
public void onDisable() {
System.out.println("[Cuicide] Has been Disabled!");
 
}
 
@Override
public void onEnable() {
System.out.println("[Cuicide] Has Been Enabled!");
}
public boolean onCommandEvent(ConsoleCommandSender sender, CommandSender cmd,
String commandLabel, String[] args) {
Player player = (Player) sender;
String playerName  = player.getName();
if (cmd.getName().equalsIgnoreCase("die") && sender.hasPermission("Cuicide.die")) {
player.setHealth(0);
this.getServer().broadcastMessage(playerName + "just did Suicide!");
return true;
} else {
player.sendMessage("WHY YOU TRY AND DO SUICIDE?");
}
return false;
} }
 

The plugin.yml....

Show Spoiler Hide Spoiler

Code:

name: Cuicide
main: me.ChumChumx.Cuicide.Cuicide
version: 0.1
commands:
    die:
      description: Allows you to do suicide
      permission: Cuicide.die
      usage: /<command>
      aliases: d

Maybe it's something with the plugin.yml or the main class, i cant find it.
it dosent show any errors....

 

It looks like at around this point:

Code:

if (cmd.getName().equalsIgnoreCase("die") && sender.hasPermission("Cuicide.die"))

one of these conditionals are returning false.
Output them using System.out.println() in your code and follow your server's output in the console.

 

So put
System.out.printIn()
under
if (cmd.getName().equalsIgnoreCase("die") && sender.hasPermission("Cuicide.die"))
?

 

Not exactly. Something like "System.out.println(cmd.getName());" and "System.out.println(sender.hasPermission("Cuicide.die");" right abouve your conditionals.
That way you can see exactly what they are, and troubleshoot from there.

Just curious, how much programming experience do you have?

 

A little bit, this is my first plugin
So its supposed to be like this?

Show Spoiler Hide Spoiler

Code:

System.out.println(sender.hasPermission("Cuicide.die");
cmd.getName().equalsIgnoreCase("die") && sender.hasPermission("Cuicide.die");

 

No, more like this:

Code:

System.out.println(cmd.getName());
System.out.println(sender.hasPermission("Cuicide.die");
cmd.getName().equalsIgnoreCase("die") && sender.hasPermission("Cuicide.die");

The whole point of "System.out.println()" is to output to your console some given value.
The reason why I recommended you use this is so you can debug and see exactly where your program flows.
"System.out.println()" will not do anything to your code, so simply adding these lines won't change anything.
Just use this technique to analyze where your program goes and then you can find the underlining problem.

Not to be mean or anything, but if you don't know the very basics like "System.out.println()", I suggest you really learn Java before attempting to code any plugins all by yourself.