Solved WeatherChangeEvent Help

I'm trying to make it so when the weather changes into rain, granite blocks will be changed to diorite blocks. Can anyone help me with this?

Code:

@SuppressWarnings("deprecation")
    @EventHandler
    public void onWeather(WeatherChangeEvent e){
        World world = Bukkit.getWorld("thornmc");
        for(Chunk chunk : world.getLoadedChunks()) {
             int aX = chunk.getX() << 4;
             int aZ = chunk.getZ() << 4;
             for(int x = aX; x < aX + 16; x++){
                 for(int z = aZ; z < aZ + 16; z++){
                     for(int y = 0; y < 128; y++){
                         Block b = world.getBlockAt(x, y, z);
                         if(b.getType() == Material.STONE){
                             if(b.getData() == (byte)1){
                                 b.setType(Material.STONE);
                                 b.setData((byte)3);
                             }
                         }
                     }
                 }
             }
        }
    }

 

I used this:

Code:java

for(Chunk c : world.getLoadedChunks()) {
for(BlockState bs : c.getTileEntities()) {
if(bs.getType().equals(Material.COMMAND)) {
 
}
}
}

And I would suggest you checking if its actually raining because the event fires too if it switches from rain to sun

 

hmm. doesn't work for me :/

@FisheyLP
Okay i did this:

Code:

@SuppressWarnings("deprecation")
    @EventHandler
    public void onWeather(WeatherChangeEvent e){
        if(!e.isCancelled()){
            if(e.toWeatherState()){
                World world = Bukkit.getWorld("thornmc");
                for(Chunk chunk : world.getLoadedChunks()) {
                    Bukkit.getServer().broadcastMessage("1");
                    int aX = chunk.getX() << 4;
                    int aZ = chunk.getZ() << 4;
                    for(int x = aX; x < aX + 16; x++){
                        for(int z = aZ; z < aZ + 16; z++){
                            for(int y = 0; y < 128; y++){
                                Block b = world.getBlockAt(x, y, z);
                                    if(b.getType() == Material.STONE){
                                        Bukkit.getServer().broadcastMessage("3");
                                    if(b.getData() == (byte)1){
                                        b.setType(Material.STONE);
                                        b.setData((byte)3);
                                        Bukkit.getServer().broadcastMessage("4. worked");
                                     }
                                 }
                             }
                         }
                     }
                }
            }
        }

it doesn't broadcast the message '3' or '4. worked'.

This doesn't work either:

Code:

@SuppressWarnings("deprecation")
    @EventHandler
    public void onWeather(WeatherChangeEvent e){
        if(!e.isCancelled()){
            if(e.toWeatherState()){
                World world = Bukkit.getWorld("thornmc");
                for(Chunk chunk : world.getLoadedChunks()) {
                    for(BlockState bs : chunk.getTileEntities()) {
                        Bukkit.broadcastMessage("1");
                        if(bs.getType().equals(Material.STONE)){
                            Bukkit.broadcastMessage("2");
                            if(bs.getData().equals(1)){
                                Bukkit.broadcastMessage("3");
                                bs.getBlock().setType(Material.STONE);
                                bs.getBlock().setData((byte)3);
                            }
                        }
                    }
                }
            }
        }
    }

it stops at the message '1'

 

getData() returns the MaterialData. You need to use getData().getData()

 

@FisheyLP
Still not working. Stops at '1'. And should ''for(BlockState bs : chunk.getTileEntities()) {'' be changed to ''for(BlockState bs : chunk.getBlock(int, int, int)) {''?

Code:

@SuppressWarnings("deprecation")
    @EventHandler
    public void onWeather(WeatherChangeEvent e){
        if(!e.isCancelled()){
            if(e.toWeatherState()){
                World world = Bukkit.getWorld("thornmc");
                for(Chunk chunk : world.getLoadedChunks()) {
                    Bukkit.broadcastMessage("1");
                    for(BlockState bs : chunk.getTileEntities()) {
                        Bukkit.broadcastMessage("2");
                        if(bs.getType().equals(Material.STONE)){
                            Bukkit.broadcastMessage("3");
                            if(bs.getData().getData() == (byte)1){
                                Bukkit.broadcastMessage("4");
                                bs.getBlock().setType(Material.STONE);
                                bs.getBlock().setData((byte)3);
                            }
                        }
                    }
                }
            }
        }
    }

 

The code works for me. Maybe the world is wrong or there are no loaded chunks in the world?

 

Are you both using the same Java/Bukkit Version?

 

@Zombie_Striker
I'm using craftbukkit 1.8

@FisheyLP
World is not wrong and it has loaded chunks

EDIT by Timtower: merged posts

 

bump

ok i was messing around with that and i finally managed to make it work

Code:

@SuppressWarnings("deprecation")
    @EventHandler
    public void onWeather(WeatherChangeEvent e){
        if(!e.isCancelled()){
            if(e.toWeatherState()){
                for(Player p : Bukkit.getOnlinePlayers()){
                    World world = p.getWorld();
                     for(Chunk chunk : world.getLoadedChunks()) {
                         int aX = chunk.getX() << 4;
                         int aZ = chunk.getZ() << 4;
                         for(int x = aX; x < aX + 16; x++){
                             for(int z = aZ; z < aZ + 16; z++){
                                 for(int y = 0; y < 128; y++){
                                     if(chunk.getBlock(x, y, z).getType() == Material.STONE){
                                         if(chunk.getBlock(x, y, z).getData() == (byte)1){
                                             world.getBlockAt(new Location(world, x, y, z)).setType(Material.STONE);
                                             world.getBlockAt(new Location(world, x, y, z)).setData((byte) 3);
                                         }
                                     }
                                 }
                             }
                         }
                     }
                }
            }
        }
    }