Vanish Plugin

Code:JAVA

package me.ceramictitan.spy;
 
import java.util.HashSet;
import java.util.Set;
 
import org.bukkit.Bukkit;
import org.bukkit.Effect;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
 
public class myPlayerInteractListener implements Listener{
 
public Set<String> vanished = new HashSet<String>();
public spy plugin;
private int id;
 
public myPlayerInteractListener(spy plugin){
this.plugin = plugin;
}
public void setTaskId(int id) {
this.id = id;
}
@EventHandler
public void onPlayerInteract(PlayerInteractEvent event){
final Player p = event.getPlayer();
if(event.getAction() == Action.RIGHT_CLICK_AIR){
if(p.getItemInHand().getType() == Material.REDSTONE){
if(vanished.contains(p.getName())){
p.sendMessage("Already Vanished");
event.setCancelled(true);
}else if(!vanished.contains(p.getName())){
this.vanished.add(p.getName());
p.hidePlayer(p);
p.sendMessage("You are now hidden!");
p.getWorld().playEffect(p.getLocation(), Effect.STEP_SOUND, Material.SNOW_BLOCK.getId());
if(vanished.contains(p.getName())){
id = Bukkit.getScheduler().scheduleAsyncRepeatingTask(plugin, new Runnable(){
 
@Override
public void run() {
if(p.getItemInHand().getType() == Material.REDSTONE){
p.getItemInHand().setAmount(p.getItemInHand().getAmount() -1);
if(p.getItemInHand().getType() == Material.REDSTONE){
if(p.getItemInHand().getAmount() == 1){
p.setItemInHand(new ItemStack(Material.AIR, 1));
}
if(p.getItemInHand().getType() != Material.REDSTONE && !p.getInventory().contains(Material.REDSTONE)){
p.showPlayer(p);
p.sendMessage("No longer hidden");
vanished.remove(p);
System.out.println("removed!");
Bukkit.getServer().getScheduler().cancelTask(id);
}
}
if(p.getItemInHand().getType() != Material.REDSTONE){
p.showPlayer(p);
p.sendMessage("No longer hidden");
vanished.remove(p);
System.out.println("removed!");
Bukkit.getServer().getScheduler().cancelTask(id);
}
}
}
},20L, 20L);
}
}
 
}
}
}
}
 

A few problems:
1. I don't think the player disappears.
2. If I player is vanished and they change their item in had it doesn't do anything.
3. I don't think i'm cancelling the Async Repeating task properly

 

1. I don't think the player disappears.

You aren't hiding the player properly. You need to specify who to hide from. For example, if you wanted to hide yourself ('me') from another player ('anotherPlayer') you would do this:

Code:

anotherPlayer.hidePlayer(me);

Therefore, change this line:

Code:

p.hidePlayer(p);

To something like this:

Code:

for (Player player : server.getOnlinePlayers())
{
    player.hidePlayer(p);
}

You would also have to listen for PlayerLoginEvent, to ensure that anyone logging in can't see players that are supposed to be invisible.

2. If I player is vanished and they change their item in had it doesn't do anything.

You would need an event listener for this as well. Whenever someone changes their held item, check what the item is and react accordingly.

 

What event listener?

Also how would I hide players from newly logged in players with the PlayerLoginEvent?

Like this:

Code:JAVA

@EventHandler
public void onPlayerLogin(PlayerLoginEvent event){
Player loginPlayer = event.getPlayer();
if(vanished.contains(p)){
p.hidePlayer(loginPlayer);?
}
}
 

 

I wasn't sure, so I've been searching since I posted that to find out.

The PlayerItemHeldEvent looks like what you want: "Fired when a player changes their currently held item."

When you iterate through players and make sure none of them can see you, you've done all online players.

When someone new logs in (which activates a PlayerLoginEvent) you would need to run the hidePlayer() method on them too.

 

did you see my code? would that be on the right track?

 

It's on the right track, but won't work ;-) Remember what I said before:

Code:

anotherPlayer.hidePlayer(me);

You've got that the wrong way around.

This part is incorrect:

Code:

if(vanished.contains(p)) {
    p.hidePlayer(loginPlayer);?
}

Go through every Player listed in 'vanished', and then do:

Code:

loginPlayer.hidePlayer(p);

... where p is an instance of Player taken from the 'vanished' Set.

 

hmm alright i understood all of that except for this bit:

leiger

It would be a for loop but i don't know what arguments the for loop would take?

 

I'm trying not to do it all for you

You have a vanished variable, which is a Set of Strings. Do you know how to iterate through it? [Hint: I iterated through the list of online players earlier...]

For each String in vanished, get a Player object using that name. Then do something like this:

Code:

loginPlayer.hidePlayer(playerObjectYouJustCreated);

Basically, when someone new logs into your server they can see everyone, including those people that they are not supposed to see (the people in vanished). What you are trying to do is to make all of the people in vanished not visible any more to this new player.

 

Thank, I'm sorry i had no intention for you to do everthing

Also would i do the same thing for PlayerItemHeldEvent because its out of the other method and p is an unknown variable

 

PlayerItemHeldEvent should give you access to the player that performed the action, most likely with something like event.getPlayer(). Just use that to get a reference to the player:

Code:

Player p = event.getPlayer();

Then ... either show or hide that player using similar code to what you did in the PlayerInteractEvent handler. You would either make them hidden to every other online player, or you'd make them visible again to every online player.

 

Great thank you

 

Everything's working now?

 

Yeah except the fact the when the player is invisible, the invisible player doesn't take damage.

 

Hmm. Are you doing anything with your code that might cause this?

Posting the updated code that you are using now (since making all of those modifications) might help to find the cause.

 

Alright. Well I'm not at home right now but as soon as I get home I will post it.

Code:JAVA

package me.ceramictitan.spy;
 
import java.util.HashSet;
import java.util.Set;
 
import org.bukkit.Bukkit;
import org.bukkit.Effect;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerItemHeldEvent;
import org.bukkit.event.player.PlayerQuitEvent;
 
import org.bukkit.event.player.PlayerLoginEvent;
import org.bukkit.inventory.ItemStack;
 
public class myPlayerInteractListener implements Listener{
 
public Set<String> vanished = new HashSet<String>();
public spy plugin;
private int id;
 
public myPlayerInteractListener(spy plugin){
this.plugin = plugin;
}
@EventHandler
public void onPlayerInteract(PlayerInteractEvent event){
final Player p = event.getPlayer();
if(event.getAction() == Action.RIGHT_CLICK_AIR){
if(p.getItemInHand().getType() == Material.REDSTONE){
if(vanished.contains(p.getName())){
p.sendMessage("Already Vanished");
event.setCancelled(true);
}else if(!vanished.contains(p.getName())){
this.vanished.add(p.getName());
for (Player player : Bukkit.getServer().getOnlinePlayers())
{
   player.hidePlayer(p);
}
p.sendMessage("You are now hidden!");
p.getWorld().playEffect(p.getLocation(), Effect.STEP_SOUND, Material.SNOW_BLOCK.getId());
if(vanished.contains(p.getName())){
id = Bukkit.getScheduler().scheduleAsyncRepeatingTask(plugin, new Runnable(){
 
@Override
public void run() {
if(p.getItemInHand().getType() == Material.REDSTONE){
p.getItemInHand().setAmount(p.getItemInHand().getAmount() -1);
if(p.getItemInHand().getType() == Material.REDSTONE){
if(p.getItemInHand().getAmount() == 1){
p.setItemInHand(new ItemStack(Material.AIR, 1));
}
if(p.getItemInHand().getType() != Material.REDSTONE){
for(Player player : Bukkit.getServer().getOnlinePlayers()){
player.showPlayer(p);
p.sendMessage("No longer hidden");
if(vanished.contains(p.getName())){
vanished.remove(p.getName());
}
System.out.println("removed!");
stopTask();
}
}
}
}
}
},20L, 20L);
}
}
 
}
}
}
@EventHandler
public void onItemChange(PlayerItemHeldEvent event){
if(event.getPlayer().getItemInHand().getType() == Material.REDSTONE){
if(!vanished.contains(event.getPlayer().getName())){
return;
}
for(Player player : Bukkit.getServer().getOnlinePlayers()){
player.showPlayer(event.getPlayer());
event.getPlayer().sendMessage("No longer hidden");
if(vanished.contains(event.getPlayer().getName())){
vanished.remove(event.getPlayer().getName());
System.out.println("removed!");
}
stopTask();
}
}
}
@EventHandler
public void onPlayerLogin(PlayerLoginEvent event){
for(String playerName : vanished) { 
Player player = Bukkit.getPlayerExact(playerName); 
Player loginPlayer = event.getPlayer();
if (player != null) {
loginPlayer.hidePlayer(player); 
}
}
 
}
@EventHandler
public void onDamage(EntityDamageByEntityEvent event){
Player p = (Player)event.getEntity();
if(p instanceof Player){
if(vanished.contains(p.getName())){
for(Player players : Bukkit.getServer().getOnlinePlayers()){
players.showPlayer(p);
}
event.setCancelled(false);
p.getWorld().playEffect(p.getLocation(), Effect.STEP_SOUND, Material.LAVA.getId());
vanished.remove(p.getName());
p.sendMessage("You have been Spotted!");
stopTask();
 
}
}
}
@EventHandler
public void onPlayerQuit(PlayerQuitEvent event){
if(vanished.contains(event.getPlayer().getName())){
vanished.remove(event.getPlayer().getName());
}
}
private void stopTask(){
Bukkit.getServer().getScheduler().cancelTask(id);
}
}
 
 

Here is the full class.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

If you remove the onDamage(EntityDamageByEntityEvent event) method, e.g. comment it out, do you still have the problem with invincible players?

Once you've isolated the cause of the problem, you can start looking for a solution.

 

alright, will try within the next few days

I think this is the problem ^

EDIT by Moderator: merged posts, please use the edit button instead of double posting.