Usage on all but a few commands?

Ok guys, I'm thanking you all ahead of time for your help.

Now.
I had 2 plugins and merged them. Everything is set up, i fixed plugin.yml, added commands in, and everything. But all the commands I merged in to the plugin just automatically return false. The ones that already were there work perfectly. No console errors or anything. Just the usage message. Any ideas? Heres some code.


Beginning:

Code:java

 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
Player player = null;
if (sender instanceof Player) {
player = (Player) sender;
}
 

What Works:

Code:java

 
if (cmd.getName().equalsIgnoreCase("ntp")) {
if (args.length == 0) {
NTPServer.OnCmdNTP(player);
}
 

What Doesnt Work:

Code:java

 
if (cmd.getName().equalsIgnoreCase("test")) {
player.sendMessage("Testing Confirmed.");
 
}
 

Any ideas on what could be going wrong? (I have more commands that work and dont work, but this is just part.)

 

• registered commands properly in the plugin.yml?
• set the executor of all commands correctly?

 

Yes.

What do you mean? I put return true where it is supposed to return true, if that is what you're asking.

 

If you have your onCommand method in a seperate class that implements CommandExecutor, make sure you set the command to that executor.

 

You registered the command "test"?
I mean, if /ntp works, you could just do sender.sendMessage("Test"); there.

 

Its in the Main Class like it should be.

Yes It's registered in the plugin.yml. My point is, one command works while the other doesnt. Same onCommand thing too.

 

If you don't have the on command in you main class

Code:

getCommand("command_thats_not_working").setExecutor(the_class);

 

sry, over read that one. Well, posting the main/executor class and/or the plugin.yml would help a bit at least.

 

Its okay! I do stuff like that all the time. And sure... I just wanted my plugin to be semi private, so Ill post the stuff needed.

MainClass (open) MainClass (close)

Code:java

 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
Player player = null;
if (sender instanceof Player) {
player = (Player) sender;
}
if (cmd.getName().equalsIgnoreCase("ntp")) {
if (args.length == 0) {
NTPServer.OnCmdNTP(player);
}
else if (args.length == 1){
//ntp command
}
}
if(cmd.getName().equalsIgnoreCase("ban")) {
------------------
------------------
(This Works)
------------------
------------------
}
if (cmd.getName().equalsIgnoreCase("test")) {
player.sendMessage("Testing Confirmed.");
 
}
 

And plugin.yml will be in next post.

Code:yml

 
name: NTPServer
main: me.nicholasntp.NTPServer.NTPServer
version: 1.0dev
author: nicholasntp
 
description:
NTP Server's plugin.
 
commands:
    ntp:
        description: Does various things for The NTP Server.
        usage: Does various things for The NTP Server.
 
    ban:
        description: Bans players
        usage: /ban (player) (reason)
 
    test:
        description: A test
        usage: /test
 
------------
 

Anyone?

I am so confused on why it wont work. Anyone have any ideas?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

When you want to do multiple checks for the same purpose(example: commands) use else if. I believe it improves performance slightly and makes your code nicer.

Code:java

if(condition1);
else if(condition2);
else if(condition3);
else;

 

Good point, thank you. I will see if this solves my problem too.

Thank you Technius! What you said made me look at my code, and I had a bracket error somewhere. Thank you for the tip too!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

So is the issue fixed, or still there?

 

He said it's fixed.

 

Ahh sorry, but yeah, its fixed. Thanks all of you!