Solved Unsquashable bug

Sorry for the formatting, the tabs and spaces mix together...

Alright, here's the prob:
Whenever Arena#game() is executed by the command handler, the messages all show TWICE. I'll try to show some pics tomorrow, but for now it's like:

[BattleDome][BattleDome]starts in 10 seconds, prepare for battle!
[BattleDome][BattleDome]starts in 10 seconds, prepare for battle!
[BattleDome][BattleDome]starts in 9 seconds, prepare for battle!
[BattleDome][BattleDome]starts in 9 seconds, prepare for battle!

Here's all the code:

PHP:

//Command
        if(cmd.equalsIgnoreCase("start")){
            if(ErrorHandler.getEh().validateCmd(p, args.length, 1, "bd.start")){
                int i = 0;
                try{
                    i = Integer.parseInt(args[0]);
                }catch (NumberFormatException e){
                    p.sendMessage(ErrorHandler.getEh().error + "Invalid arena ID");
                }
                Arena a = BattleManager.getBM().getArena(i);

                if(a != null){
                    if(a.getState().equals(Arena.Game.LOBBY)){
                        a.game();
                        p.sendMessage(BattleManager.getBM().bd + "Starting Arena #" + a.getId());
                    }else{
                        p.sendMessage(ErrorHandler.getEh().error + "This arena has already started!");
                    }
                }else{
                    p.sendMessage(ErrorHandler.getEh().error + "Invalid arena!");
                }
            }
            return;
        }

PHP:

//Arena#game() / start() / broadcast()
    public void game() {
        for(String s : players){
            Player p = Bukkit.getPlayer(s);
            if(p == null){
                return;
            }
            MoveListener.getSet().add(s);
        }

        Count c = new Count(10, this, false);

        c.setId(Bukkit.getScheduler().scheduleSyncRepeatingTask(plugin, c, 0L, 20L));
    }


    public void lobby(int i) {
        Count c = new Count(i, this, true);

        c.setId(Bukkit.getScheduler().scheduleSyncRepeatingTask(plugin, c, 0L, 5*60L*20L));

    }

    public void start(){
        rb.saveWorld(redSpawn.getWorld());
        for(String s : players){
            Player p = Bukkit.getPlayer(s);
            if(p == null){
                return;
            }
            MoveListener.getSet().remove(s);
        }

        setState(Game.BUILD);
        Countdown c = new Countdown(45, this);

        Bukkit.getScheduler().scheduleSyncRepeatingTask(plugin, c, 0L, 5L*60L*20L);
    }

    public void broadcast(String s){
        for(String st : players){
            Player p = Bukkit.getPlayer(st);
                        if(p != null) {
                            p.sendMessage(/*BattleManager.getBM().bd oops, I'll fix that tomorrow. 1 problem fixed :D*/ + s);
                        }
                }
        }

PHP:

//Count
package com.gmail.woodyc40.battledome.runnables;

import com.gmail.woodyc40.battledome.Arena;
import com.gmail.woodyc40.battledome.BattleManager;
import com.gmail.woodyc40.battledome.handlers.SignHandler;
import org.bukkit.Bukkit;

public class Count implements Runnable{

    int count = 0;
    int id = 0;
    Arena a;
    private boolean isLobby;

    public Count(int i, Arena a, boolean b) {
        this.count = i;
        this.a = a;
        this.isLobby = b;

        RunnableQueue.queue(this, a);
    }

    public void setId(int id) {
        this.id = id;
    }

    public int getId() {
        return id;
    }

    void stop(){
        Bukkit.getScheduler().cancelTask(id);
    }

    @Override
    public void run() {
        if(this.isLobby){
            SignHandler.getSh().update(a, Arena.Game.LOBBY);
            a.broadcast(BattleManager.getBM().bd + "Lobby ends in " + count + " minutes! Please vote to start quicker!");
            if(count == 0){
                if(a.getPlayerCount() == 0){
                    a.lobby(5);
                    return;
                }
                a.teleportToGame();
                stop();
                a.game();
                RunnableQueue.removeFromQueue(this);
            }
            count--;
        }else {
            SignHandler.getSh().update(a, Arena.Game.STARTING);
            a.broadcast(BattleManager.getBM().bd + "starting in " + count + " seconds, prepare for battle!");
            if(count == 0){
                a.broadcast(BattleManager.getBM().bd + "has started! Best of luck!");
                a.start();
                stop();
                RunnableQueue.removeFromQueue(this);
            }
            count--;
        }
    }
}

PHP:

//RunnableQueue
package com.gmail.woodyc40.battledome.runnables;

import com.gmail.woodyc40.battledome.Arena;
import org.bukkit.Bukkit;

import java.util.*;

public class RunnableQueue {

    private static Map<Integer, Count> runnableQueue = new HashMap<>();

    public static void queue(Count c, Arena a) {
        runnableQueue.put(a.getId(), c);
    }

    public static void cancelAllTasks(Arena a) {
        for(Map.Entry<Integer, Count> e : runnableQueue.entrySet()) {
            if(a.getId() == e.getKey()) {
                Bukkit.getScheduler().cancelTask(e.getValue().getId());
            }
        }
    }

    public static void removeFromQueue(Count c) {
        if(!runnableQueue.containsValue(c)) {
            return;
        }

        for(Count count : loopThroughValues()) {
            if(count.getId() == c.getId()) {
                Bukkit.getScheduler().cancelTask(c.getId());
                break;
            }
        }
    }

    public static boolean containsInQueue(Count c) {
        return runnableQueue.containsValue(c);
    }

    private static List<Count> loopThroughValues() {
        List<Count> list = new ArrayList<>();
        for(Map.Entry<Integer, Count> e : runnableQueue.entrySet()) {
            list.add(e.getValue());
        }
        return list;
    }

}

Edit: I'll try to use a HashSet tomorrow to see if there are 2 of me in the ArrayList

 

xTrollxDudex

Code:java

public void broadcast(String s){
System.out.println("broadcasted : " + s);
        for(String st : players){
            Player p = Bukkit.getPlayer(st);
                        if(p != null) {
                            p.sendMessage(/*BattleManager.getBM().bd oops, I'll fix that tomorrow. 1 problem fixed :D*/ + s);
                        }
                }
        }

Does it print to the console more than once?

 

Xacero
I'm on an iPad right now, but when I did that earlier it shows only once. I'll try tomorrow.

 

xTrollxDudex Something wrong with the variable "players" then.
I dont think you included where that's coming from , and if you did I missed it.

If you're adding to that list when the player joins the arena make sure you aren't calling the join method 2x.

Some good debug code would be

Code:java

for(String st : players){
            Player p = Bukkit.getPlayer(st);
                        if(p != null) {
System.out.println(p.getName());
                            p.sendMessage(/*BattleManager.getBM().bd oops, I'll fix that tomorrow. 1 problem fixed :D*/ + s);
                        }
                }
        }

 

This is what I used in my 1v1 plugin. Give it a try:

Code:

        new BukkitRunnable() {
 
            int i = 3;
            @Override
            public void run() {
                String ll1 = (ChatColor.translateAlternateColorCodes('&', plugin.getConfig().getString("messages.count-down-1v1-1")));
                String ll2 = (ChatColor.translateAlternateColorCodes('&', plugin.getConfig().getString("messages.count-down-1v1-2")));
                String ll3 = (ChatColor.translateAlternateColorCodes('&', plugin.getConfig().getString("messages.count-down-1v1-3")));
                switch (i){
                    case 3:
                        player.sendMessage(ll3);
                        target.sendMessage(ll3);
                        break;
                    case 2:
                        player.sendMessage(ll2);
                        target.sendMessage(ll2);
                        break;
                    case 1:
                        player.sendMessage(ll1);
                        target.sendMessage(ll1);
                        break;
                    case 0:
                        player.sendMessage(ChatColor.translateAlternateColorCodes('&', plugin.getConfig().getString("messages.1v1-go")));
                        target.sendMessage(ChatColor.translateAlternateColorCodes('&', plugin.getConfig().getString("messages.1v1-go")));
                        freeze.remove(player.getName());
                        freeze.remove(target.getName());
                        cancel();
                }
                i--;
            }
 
        }.runTaskTimer(plugin, 20, 20);

 

players is an ArrayList as mentioned.

 

xTrollxDudex
I know it's an ArrayList, I just didn't see any methods adding / removing things from it. only methods getting information from it.

I'd like to see the methods setting the data in the list. Sorry for the confusion

 

Xacero
Here:

PHP:

//Arena#addPlayer(Player)
public void addPlayer(Player p) {
        p.teleport(FileHandler.deserializeLoc(FileHandler.getFh().getSpawns().getString("Arenas." + getId() + ".lobby")));
        p.setGameMode(GameMode.SURVIVAL);
        p.setHealth(20);
        p.setFoodLevel(20);
        p.setSaturation(20);
        players.add(p.getName());
        this.numOfPlayers++;
    }

PHP:

    //BattleManager#addPlayer()
public void addPlayer(Player p, int id) {
        Arena a = getArena(id);
        if(a == null){
            p.sendMessage(ErrorHandler.getEh().error + "This arena does not exist...");
            return;
        }
        save(p);
        exp.put(p.getName(), p.getTotalExperience());

        a.addPlayer(p);
    }

PHP:

//command. I swear I didn't type it in twice!
        if (cmd.equalsIgnoreCase("join")) {
            if (ErrorHandler.getEh().validateCmd(p, args.length, 1,
                    "bd.join")) {
                int i = 0;
                try {
                    i = Integer.parseInt(args[0]);
                } catch (NumberFormatException e) {
                    p.sendMessage(ErrorHandler.getEh().error
                            + "Invalid arena ID!");
                }
                BattleManager.getBM().addPlayer(p, i);
                Arena a = BattleManager.getBM().getArena(i);
                if(a == null){
                    p.sendMessage(ErrorHandler.getEh().error + "Invalid arena!");
                    return;
                }

                if(a.getState().equals(Arena.Game.LOBBY)){BattleManager.getBM().addPlayer(p, i);p.sendMessage(BattleManager.getBM().bd + "Added you to Arena #" + i);}
                else {
                    if(a.getState().equals(Arena.Game.BUILD) || a.getState().equals(Arena.Game.DEATHMATCH) || a.getState().equals(Arena.Game.FIGHT))    a.setSpectator(p);
                    else if(a.getState().equals(Arena.Game.DISABLED) || a.getState().equals(Arena.Game.NOT_JOINABLE) || a.getState().equals(Arena.Game.UNKNOWN) || a.getState().equals(Arena.Game.STARTING) || a.getState().equals(Arena.Game.ENDGAME)){    p.sendMessage(ErrorHandler.getEh().error + "This arena is not joinable at the current time");    return;}
                }

                if (a.getPlayerCount() == FileHandler.getFh().getConfig().getInt("Arena.max-players")) {
                    a.lobby(10);
                } else if (a.getPlayerCount() == 1) {
                    BattleManager.getBM().countdown(3, a);
                }
            }else if(args.length == 0){
                p.teleport(BattleManager.deadSpawn);
            }
            return;
        }

 

xTrollxDudex

Code:java

 
BattleManager.getBM().addPlayer(p, i); // added 1x
Arena a = BattleManager.getBM().getArena(i);
if(a == null){
p.sendMessage(ErrorHandler.getEh().error + "Invalid arena!");
return;
}

Code:java

 if(a.getState().equals(Arena.Game.LOBBY)){
 
BattleManager.getBM().addPlayer(p, i); // added 2x

Is that your problem ?

 

What!?

.....

What's wrong with me D:

Thanks. I was banging my head against the wall for a few days over stupid mistakes such as this. If you want to see another idiotic mistake a while back, feel free to ask thanks again.

 

Code:

//command. I swear I didn't type it in twice!

Mhhm.

Don't worry about it, it happens to all of us Remember to mark as [solved] unless there's anything else you need assistance with

 

http://forums.bukkit.org/threads/solved-this-cant-be-a-serious-error-intellij.170267/

Pure stupidity

 

xTrollxDudex
Bracket errors can be tricky to spot. Don't even worry about it

 

xTrollxDudex
xTrollxDudex asking for help? No it's... impossible. Also just a question. I'm following your tutorial on minigame plugin and am using GameStates and join signs. How should I run a countdown for when the game starts?

 

mattrick16
Hmmm.

Eh?

 

xTrollxDudex
Ok thanks, I wasn't really paying attention