Unmute problems

Greetings, I made a mute and unmute plugin. The mute is working but the unmute isnt working. If we use /unmute on a player he will still be muted. Please help. My code so far:

Code:java

package me.BeastCraft3.inventorygui;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.AsyncPlayerChatEvent;
 
public class Mute implements CommandExecutor, Listener{
 
    public Main plugin;
 
    public Mute(Main main) {
        main.getServer().getPluginManager().registerEvents(this, main);
      }
 
 
    public ArrayList<String> mute = new ArrayList<String>();
 
 
    @EventHandler
    public void onChat(AsyncPlayerChatEvent e) {
        Player p = e.getPlayer();
        if (mute.contains(p.getName()))  {
            e.setCancelled(true);
            p.sendMessage(ChatColor.DARK_RED + "You are muted and have to wait until someone unmute you!");
        }
    }
 
 
    @SuppressWarnings("deprecation")
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        if (!(sender instanceof Player)) {
            sender.sendMessage(ChatColor.GREEN + "Only Players can preform this command");
            return true;
        }
        Player player = (Player) sender;
        if(label.equalsIgnoreCase("mute")) {
            if (player.hasPermission("Hub.mute")) {
                if (args.length == 0) {
                    player.sendMessage(ChatColor.RED + "Invalid args. Try /mute <Player Name>");
                    return true;
                }
                if (args.length == 1) {
                    Player online = Bukkit.getPlayer(args[0]);
                    if (online == null || !online.isOnline()) {
                        player.sendMessage(ChatColor.RED + "Player " + args[0] + " was not found ");
                    } else {
                        mute.add(online.getName());
                        player.sendMessage(ChatColor.GREEN + "You have muted " + online.getName());
                        online.sendMessage(ChatColor.DARK_RED + "You have been muted");
                    }
                }
            }
        }
        if (label.equalsIgnoreCase("unmute")) {
            if (player.hasPermission("Hub.unmute")) {
                if (args.length == 0) {
                    player.sendMessage(ChatColor.RED + "Invalid args. Try /unmute <Player Name>");
                    return true;
                }
                if (args.length == 1) {
                    Player online = Bukkit.getPlayer(args[0]);
                    if (online == null || !online.isOnline()) {
                        player.sendMessage(ChatColor.RED + "Player " + args[0] + " was not found ");
                    } else {
                        mute.remove(online.getName());
                        player.sendMessage(ChatColor.GREEN + "You have unmuted " + online.getName());
                        online.sendMessage(ChatColor.DARK_RED + "You have been unmuted");
                    }
                }
            }
        }
        return false;
    }
 
}
 

 

Not sure if this is causing your issues, but you should never use an asynch event like this. Either use the PlayerChatEvent (the synchronised one) or implement proper concurrency handling.

 

Instead of
ArrayList<String>
useHashSet<String>
and it should work fine then.

 

Nope, HashSet is not thread save either. Quote from the Oracle docs:

 

minoneer
rsod
Everyone on youtube did this and they manage to make it work

 

BeastCraft3 Youtube is a very poor source for learning to program well. You need to consider the possibility that the mute command is run at the same exact time the asynchronous chat event is called, which would likely cause some issues. The easiest way is to use Collections.synchronizedList() to create a synchronized list.

 

coasterman10
Im new to java and your talking to advanced ;3

 

Try

Code:java

Player targetPlayer = player.getServer().getPlayer(args[0]);

instead of the

Code:java

Player online = Bukkit.getPlayer(args[0]);

Also, because of the UUID change, if this is 1.7.9 then I would replace the targetPlayer.getName() with targetPlayer.getUniqueId()

 

BeastCraft3 Since you haven't posted your main class, I can make a guess. You might be calling new Mute(this) twice, thus you are working with two completely separate Lists. But again, this is just a guess.

 

BeastCraft3 Instead of using new ArrayList<String>, use Collections.synchronizedList(). If you can't figure this out then I suggest you learn more Java before continuing with Bukkit.

 

coasterman10 Rocoty Synapz minoneer rsod
My main class: http://pastebin.com/yhvDiSHT

 

BeastCraft3 Alright. Seeing your code confirmed my concerns. So don't instantiate the class more than once. In fact, looking at your code, it doesn't seem like you have the faintest idea of what you're doing, so you might as well read some Java tutorials.

 

Rocoty
omg.. I've tried to many java tutorials but this is the only place I actually learn. all the other is just watching a video without thinking.

 

BeastCraft3 Don't watch videos. Read them. Here, I'll point you to a tutorial that fits your needs for this problem.
http://docs.oracle.com/javase/tutorial/java/javaOO/index.html

EDIT: Or you can always read what I posted to you earlier (my first post in this thread)

 

Rocoty
I'll just buy a lesson from bcbroz. He has cheap prices

 

If you're not opposed to books (yes, those things made of paper ), "Head first Java" is an awesome book to learn Java with. It teaches a lot of background, while being very entertaining and easy to read and understand.

 

Getting back to the original question of this thread,

Synapz 's answer should fix your problem.

 

Synapz When will people learn that Bukkit.getPlayer(String name) is the same as Bukkit.getServer().getPlayer(String name). It's a wrapper...

 

Code0 I must disagree. The problem is that OP is working with three different instances of a class of which he should have only been working with one instance. If you look at the code from the pastebin link he posted, you'll see that this is a recurring toxic practice in his code.

 

BeastCraft3
1. Don't use Logger.getLogger("Minecraft"), use the Logger object you get from JavaPlugin#getLogger()
2. For your own safety, remove that static instance of your main class.
3. Use a (Hash)Set instead of any List implementation, due to the fact that Sets are way faster than Lists when it comes to contains().
4. As mentioned before, learn to synchonize or use the non async events. While async is preferred, ignoring thread safety like in your current implementation is no better. The easiest way to synchronise in this case is by using Collections.synchronisedSet(new HashSet<String>());
5. When the player is offline, Bukkit.getPlayer(String) returns null, which throws an NullPointerException is you use .isOnline(), thus check if(player == null)

 

fireblast709
Could you give me the code for both of em? Please im close to give up cause I never manage to get this to work.

 

BeastCraft3 I don't spoonfeed code. You can find the actual answer to the issue in Rocoty 's last post, and additional pointers in my last post which will prevent some future issues.

 

It would be best to get a good Java book and become more familiar with the concepts behind the language. It will help you greatly both now and later on when you get into more complex plugins. Once you are familiar then all the advice here will be easy to implement into your program.