Timer not working.

I'm making a count down system every quarter time of the timer specified, so for example when the time specified is 60. Then it will say after 15 seconds: There are still 45 seconds remaining and when it reaches zero it stops and does some other stuff.

But the time that I specified isn't working correctly, I specified a time of 600 and set the timer to getConfig().getInt(path)/4. But when I tell it to start and from on then it just goes rapidly from the first statement that it has to do to the last one.

Here is some code:

The secondConvert method just returns a string so there shouldn't be a problem there.

Code:java

 
 
 
public String timeLeft = "unknown";
 
public String timeConvert(int i) {
int d = i / 86400;
int drem = i % 86400;
int h = drem / 3600;
int hrem = drem % 3600;
int m = hrem / 60;
int s = hrem % 60;
 
String days = secondConvert("day", d);
String hours = secondConvert("hour", h);
String mins = secondConvert("minute", m);
String secs;
if(secondConvert("minute", m).equals("")) {
secs = secondConvert("second", s);
}
else {
secs = "and " + secondConvert("second", s);
}
 
String t = days + hours + mins + secs;
timeLeft = t;
return t;
}
public Timer timer;
public int count = 0;
public void Timer() {
timer = new Timer(getConfig().getInt("Config.RoundLength") / 4, new TimerListener(this));
timer.start();
}
public String secondConvert(String n, int i) {
String s;
if(!(i > 0)) {
s = "";
return s;
}
if(i == 1) {
s = i + " " + n + " ";
return s;
}
s = i + " " + n + "s ";
return s;
}
 

This is the TimerListener class:

Code:java

package me.Dreeass.Play;
 
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
 
import org.bukkit.entity.Player;
 
public class TimerListener implements ActionListener {
 
public static Main plugin;
 
public TimerListener(Main instance) {
plugin = instance;
}
 
@Override
public void actionPerformed(ActionEvent arg0) {
plugin.count++;
int count = plugin.count;
int time = plugin.getConfig().getInt("Config.RoundLength");
switch(count) {
case 1:
plugin.timeConvert(count/4 * time);
plugin.BukkitMsgConvert("Messages.Start/Stop.Broadcast.Remaining", null);
break;
case 2:
plugin.timeConvert(count/4 * time);
plugin.BukkitMsgConvert("Messages.Start/Stop.Broadcast.Remaining", null);
break;
case 3:
plugin.timeConvert(count/4 * time);
plugin.BukkitMsgConvert("Messages.Start/Stop.Broadcast.Remaining", null);
break;
case 4:
plugin.BukkitMsgConvert("Messages.Start/Stop.Broadcast.Ended", null);
plugin.started = false;
plugin.loading = false;
plugin.players();
for(Player p : plugin.players()) {
p.setHealth(20);
p.setFoodLevel(20);
plugin.Sneak(p, false);
p.teleport(plugin.getLocation("WatchSpawn"));
plugin.MessageConvert("Messages.Start/Stop.Ended", p);
}
plugin.team1Players.clear();
plugin.team2Players.clear();
plugin.ffaPlayers.clear();
plugin.timer.stop();
plugin.count = 0;
break;
 
}
}
 
}
 

Ok I see that I had to multiply the Timer's delay with 1000 because it was in ms..

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Don't use timers with bukkit! Use the scheduler, that's what it was made for. Otherwise, you have some severe concurrency problems.
And you are using a swing timer, which is even worse (without a swing GUI). Your task will be executed by the event dispatcher thread, that's murder for a minecraft server.

 

It's working now, it was a little mistake that was wrong. But why is the swing timer a murder for a minecraft server?

 

If you don't know what threading is and how it works, this is very difficult to explain.
There is a huge difference between it works and it works safely.

Basically, imagine a thread is something that calls methods. When there are multiple of them, stuff happens at the same time. The minecraft server (as well as the bukkit API) is not designed to be used by multiple threads (from the outside).

Imagine the server is one big machine, moving its players and mobs around, loading and unloading chunks and so on.
Now when you do something asynchronously (= from a different thread), you break out of that machine and you start randomly throwing in stuff. 90% of the cases what you throw in might hit its target and work as expected, but at some point it's going to hit a part of the machine where it causes damage.

It's unpredictable, that's why any method call from a different thread (with some exceptions) can potentially cause world corruption and server crashes.

Back to your timer: Swing is a graphical API. That means it is designed to work with applications that use graphical swing elements.
Like I said, the timer task will be executed by the event dispatcher thread. That's what a swing application uses to process window events. On a minecraft server, because it doesn't use a GUI, that thread doesn't even exist. Thus, all kinds of swing classes need to be loaded and that thread needs to be launched and kept running just for the sake of your timer.
While this is bad enough, the concurrency problem described above (you throwing in random stuff into a big machine) is the worst.


I don't expect you to understand all this, it is really complicated. If you want to try to understand it a bit more, feel free to read this tutorial: http://download.oracle.com/javase/tutorial/essential/concurrency/

But please, please: Never use threading unless you know how to use it properly! Its effects are not instantly visible, but they will eventually cause severe damage to the server.

http://wiki.bukkit.org/Scheduler_Programming
The scheduler should be used when working with delays/timers.
Also here: make sure you never use any method that has "Async" in its name, then you will be back at threading!

 

Bone008
Thanks for the information, currently I have made some methods which make it so if you put the length of a round to 600 and the amount of messages to display in that time period. For example if I put 600 and 4 in, then it would put out every 150 seconds: 2 minutes and 30 seconds remaining.

Is there any other way of doing this then?

 

create an task that run every 150 sec or 3000 ticks

 

I already figured a method out a method so you can configure it, but thanks.