Tasks causing laggs/freezing

Hi Guys, I'm getting problems with the Bukkit Tasks I think.
I want to create an TntRun-Minigame for my Plugin and now I'm at the Problem that it's taking too much resources I think. It's not much Code, but the Server still has an 11k Ping (I saw it in the Console), so what can I do to improve this?

SourceCode:

Show Spoiler Hide Spoiler

GameWorker:

Show Spoiler Hide Spoiler

Code:java

package at.prefixaut.runner;
 
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.entity.Player;
import org.bukkit.scheduler.BukkitTask;
 
import at.prefixaut.lobbys.LobbyData;
import at.prefixaut.lobbys.Players;
import at.prefixaut.runner.tasks.DeleteBlocksTask;
 
public class GameWorker {
 
private static Main main;
 
static BukkitTask deleteBlocks;
 
public GameWorker(Main main) {
GameWorker.main = main;
}
 
public static void startGame(final LobbyData data) {
 
final String[] players = Players.getPlayers(data.getGroupId());
 
for (int i=10; i > -1; i--) {
for (int o=0; o<players.length;o++) {
Bukkit.getPlayer(players[o]).sendMessage("The Game starts in: " + i + " Secounds!");
try {
Thread.sleep(1000);
} catch (InterruptedException e) {
e.printStackTrace();
}
}
}
 
double x = 0;
double y = 0;
double z = 0;
if (data.getDestX().charAt(0) == '~') {
String[] temp = data.getDestX().split("~");
x = data.getBlockX() + Double.parseDouble(temp[1]);
} else x = Double.parseDouble(data.getDestX());
if (data.getDestY().charAt(0) == '~') {
String[] temp = data.getDestY().split("~");
x = data.getBlockX() + Double.parseDouble(temp[1]);
} else y = Double.parseDouble(data.getDestY());
if (data.getDestZ().charAt(0) == '~') {
String[] temp = data.getDestZ().split("~");
x = data.getBlockX() + Double.parseDouble(temp[1]);
} else z = Double.parseDouble(data.getDestZ());
 
for (String player : players) {
Player p = Bukkit.getPlayer(player);
p.teleport(new Location(p.getLocation().getWorld(), x, y, z));
}
 
deleteBlocks = new DeleteBlocksTask(data).runTaskTimer(main, 0L, 2L);
}
}
 

DeleteBlocksTask:

Show Spoiler Hide Spoiler

Code:java

package at.prefixaut.runner;
 
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.entity.Player;
import org.bukkit.scheduler.BukkitTask;
 
import at.prefixaut.lobbys.LobbyData;
import at.prefixaut.lobbys.Players;
import at.prefixaut.runner.tasks.DeleteBlocksTask;
 
public class GameWorker {
 
private static Main main;
 
static BukkitTask deleteBlocks;
 
public GameWorker(Main main) {
GameWorker.main = main;
}
 
public static void startGame(final LobbyData data) {
 
final String[] players = Players.getPlayers(data.getGroupId());
 
for (int i=10; i > -1; i--) {
for (int o=0; o<players.length;o++) {
Bukkit.getPlayer(players[o]).sendMessage("The Game starts in: " + i + " Secounds!");
try {
Thread.sleep(1000);
} catch (InterruptedException e) {
e.printStackTrace();
}
}
}
 
double x = 0;
double y = 0;
double z = 0;
if (data.getDestX().charAt(0) == '~') {
String[] temp = data.getDestX().split("~");
x = data.getBlockX() + Double.parseDouble(temp[1]);
} else x = Double.parseDouble(data.getDestX());
if (data.getDestY().charAt(0) == '~') {
String[] temp = data.getDestY().split("~");
x = data.getBlockX() + Double.parseDouble(temp[1]);
} else y = Double.parseDouble(data.getDestY());
if (data.getDestZ().charAt(0) == '~') {
String[] temp = data.getDestZ().split("~");
x = data.getBlockX() + Double.parseDouble(temp[1]);
} else z = Double.parseDouble(data.getDestZ());
 
for (String player : players) {
Player p = Bukkit.getPlayer(player);
p.teleport(new Location(p.getLocation().getWorld(), x, y, z));
}
 
deleteBlocks = new DeleteBlocksTask(data).runTaskTimer(main, 0L, 2L);
}
}
 

IgniteTntTask:

Show Spoiler Hide Spoiler

Code:java

package at.prefixaut.runner.tasks;
 
import org.bukkit.Location;
import org.bukkit.block.Block;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.entity.TNTPrimed;
import org.bukkit.scheduler.BukkitRunnable;
 
public class IgniteTntTask extends BukkitRunnable {
 
private static Location loc;
private static Player p;
public IgniteTntTask(Location loc, Player p) {
IgniteTntTask.loc = loc;
IgniteTntTask.p = p;
}
 
@SuppressWarnings("deprecation")
public void run() {
try {
Block b = p.getWorld().getBlockAt(loc);
b.setTypeId(0);
loc.setY(loc.getY()-0.3);
Entity tnt = p.getWorld().spawn(loc, TNTPrimed.class);
((TNTPrimed)tnt).setFireTicks(0);
Thread.sleep(100);
tnt.remove();
} catch (InterruptedException e) {
e.printStackTrace();
this.cancel();
}
 
}
 
}
 

PS: I never worked with Tasks allot, and yeah I know I'm using lot of Tasks, but with the Thread.sleep Method, it's going to freez the Entire Class which means I can't do anything anymore until it's "awake" again :/

OffTopic: In DeleteBlocksTask is an Line outcommented > p.getWorld().playEffect(p.getLocation(),Effect.SMOKE, p.getLocation().getDirection());
won't work and I have no Idea why, because I googled it and found an Post wich was posted 3Days before, and it worked for him/her :/
Stacktrace:

Show Spoiler Hide Spoiler

Code:

[17:38:15] [Server thread/WARN]: [TntRun-Minigame] Task #5 for TntRun-Minigame v0.0.1 generated an exception
java.lang.IllegalArgumentException: Wrong kind of data for this effect!
at org.apache.commons.lang.Validate.isTrue(Validate.java:157) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
at org.bukkit.craftbukkit.v1_7_R1.CraftWorld.playEffect(CraftWorld.java:774) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
at org.bukkit.craftbukkit.v1_7_R1.CraftWorld.playEffect(CraftWorld.java:769) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
at at.prefixaut.runner.tasks.DeleteBlocksTask.run(DeleteBlocksTask.java:30) ~[?:?]
at org.bukkit.craftbukkit.v1_7_R1.scheduler.CraftTask.run(CraftTask.java:53) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
at org.bukkit.craftbukkit.v1_7_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:587) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:250) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:545) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:457) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [craftbukkit.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]

Info > No Errors when I comment it out

 

You're calling Thread.sleep() in your main thread, this will freeze the whole server .

 

werter318
Oh, I was thinking it will only freeze the Task :/ But I can't create an new delayedTask for every Delay, or do I need to?

 

PreFiXAUT I was talking about your GameWorker class, the startgame method

 

werter318
The startGame Method will only be called once, and it's not my Main Class. My Main Class is the "Main" Class (lol), as you can see that the GameWorker isn't extending JavaPlugin

 

PreFiXAUT Another class != another thread

 

werter318 Ok, but what should I do to delay the Methods? By using wait in an static Method will cause trouble (I know how to fix it, but it will cause other problems), and to start allways an new Task isn't that good, or am I wrong?

 

PreFiXAUT
Why not simply make a task that is scheduled for every second, and inside that thread have a int called countdown that is equal to 30 seconds or etc. Then every time it is called subtract from that, and inside the run method if the countdown == 30 seconds, simply announce "Game Starting in 30 seconds" or even better idea, have an array of integers and if that number is equal to the countdown announce it.
Example Code:

Code:java

package com.mcforger.example;
 
import java.util.List;
 
import org.bukkit.scheduler.BukkitRunnable;
 
public class GameCountdown extends BukkitRunnable
{
private Arena arena;
private int countdown;
private List<Integer> announce;
 
public GameCountdown(Arena arena, int countdown, List<Integer> announce)
{
this.arena = arena;
this.countdown = countdown;
this.announce = announce;
}
 
@Override
public void run()
{
if (announce.contains(countdown))
{
arena.broadcastMessage("Game starting in " + countdown
+ " seconds!");
}
if (countdown == 0)
{
cancel();
}
countdown -= 1;
}
}
 

 

You can use the System.currentTimeMillis() to manage timing. If you wish to wait for 1 second you can do something like this:

Code:java

int lasttime = System.currentTimeMillis();
int nexttime = lasttime + 1000;
while (true) {
if (!(System.currentTimeMillis() <= nexttime)) {
// Do something
}
}

(The code is not that pretty, but it should do the thing )