String help

Hi, I'm coming across a small... question, in my plugin.
basically, I'm getting the IP of a player, and storing it to a string, using
String ip = player.getPlayer().getAddress().getHostName();

i then go on to check if things exist in my config and adding them,
but then I wanted to check if the ip of a player logging on, didn't equal the one located in the config, again, all help is appreciated

 

Is that your event listener?
It's your signature

And to get ip, use this:

Code:

String ip = event.getPlayer().getAddress().getAddress().getHostAddress();

Do you want to compare the players ip to the one in the config, and if it isn't, ban him?

 

Chinwe I already have the code you posted, and what you said, I want to cancel the event and log in the config about a suspicious sign in, but I already know how to do that, I just need to compare the ip if you know how

Chinwe what you thought is my event listener, is my sig, sorry I see the confusion xD

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Samthelord1
Ah stupid me

Are you saving it in getConfig()?

To log it, you'll need to get get their ip when they join, and save it like this:

Code:

getConfig().set(player.getName(), ip);

(This will only save one ip per player)

And then to check it, you can use:

Code:

String configIp = getConfig().getString(player.getName());

Then you can compare them:

Code:

if (!configIp.equals(ip))
{
    // not correct ip
}
else
{
    // correct ip, most likely do nothing
}

 

Samthelord1
Are you trying to detect a proxy/ip change?

Just compare the current ip on login to ip in config.

Save the ip like this:

Code:

public void onJoin(PlayerJoinEvent e) {
    if(!getConfig().contains("ips." + e.getPlayer().getName())) {
        getConfig().set("ips." + e.getPlayer().getName(), e.getPlayer().getAddress().getAddress().getHostAddress());
        saveConfig();
    } else {
        if(!getConfig().getString("ips." e.getPlayer().getName()).equals(e.getPlayer().getAddress().getAddress().getHostAddress())) {
            // suspicious action
        }
    }
}

EDIT: Dangit, super ninja'd by Chinwe

 

I thought for saving it was getConfig().set(player.getName() + ".", ip

Assist Chinwe In theory, this should work?:

Code:java

                          String configIp = getConfig().getString("player." + player.getName() + ".ip");
                            if(!configIp.equals(ip)) {
                                if((config.contains("player." + player.getName() + ".ip" + ip + ".errors")) || (!config.contains("player." + player.getName() + ".ip" + ip + ".errors")));
                            config.set("player." + player.getName() + ".ip" + ip + ".errors", configIp);  {
                            }
                            }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Derp, so it is :>

 

Samthelord1
You might want to make "errors" a stringlist, otherwise it would store only 1 "error" ip.

Make a List<String>, then add the error ip to that, then set the list as value into config.

 

Chinwe Assist as for my code, I was just thinking, maybe

String configIp = getConfig().getString("player."+ player.getName()+".ip");
wont work because I should be getting paths to the string rather than A string, but how would I do this?

 

That looks in the config for:

Code:

player:
  Chinwe:
    ip: 127.0.0.1

Saved with:

Code:

getConfig().set("player." + player.getName() + ".ip", ip);

 

How would i set the list as a value in a config?

Chinwe ah thanks, I was just wondering if I needed to get paths rather than just a string

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:

// Get the list, or make a new one if it doesn't exist
List<String> errors = getConfig().contains("player." + player.getName() + ".errors") ? getConfig().get("player." + player.getName() + ".errors") : new ArrayList<String>();
 
// Add to it
errors.add(ip);
 
// Check a value in it
if (errors.contains(ip))
{
    // do something
}
 
// Save back to config
getConfig().set("player." + player.getName() + ".errors", errors);
saveConfig();

 

Samthelord1

Code:

List<String> listName = etc();
listName.add(errorip);
getConfig().set(thepath, listName);

OR an easier way

getConfig().set(thepath, Arrays.asList(new String[] { errorip }));

You might not even need to make new String[].

Edit: Chinwe again..

 

Assist Chinwe thanks both, I've got that coded now, but I'm just asking for your opinions on whether I should cancel the event or kick them or ban them?

 

Samthelord1
I think you should use PlayerLoginEvent, that gets triggered when player is attempting to join a server, not when player joins a server. Ban the player on login if necessary.

Edit: 400 posts!

 

Samthelord1
I would probably alert all ops (or players) online, log to console and either kick or freeze on login, not allowing them to move, chat, run commands or anything else (depending on config perhaps?)

Using PlayerJoinEvent you can kick/freeze them, using PlayerLoginEvent you can .disallow() it :>

Assist huehuehue..

 

Assist WTAF WE HIT 400 AT THE SAME TIME 0.0

 

Samthelord1
With me trundling along behind with 335

 

Samthelord1
And I've been here only few years less than you :3

 

Assist I actually actually used my account a few months ago haha, I had to register for curse for some reason in 2011 and I think I was looking for plugins lol, i decided that I could use


getServer().banIP(ip);

But then how would I set their ban message? I know I would have to change event priority, but for a ip?

 

Samthelord1
I suppose you could kick/disallow with the message, and then ban after that?

 

Chinwe I think I'm gonna just ban the IP because Essentials will decide what the ban message is

Assist Chinwe ok, I think this code will work as a allowed ip, correct?

if((config.contains("player." + player.getName() + ".allow")) || (!config.contains("player." + player.getName() + ".allow"))); {
List<String> allow = (List<String>) (getConfig().contains("player." + player.getName() + ".allow") ? getConfig().get("player." + player.getName() + ".allow") : new ArrayList<>());

config.set("player." + player.getName() + ".allow", allow);

if(allow.contains(ip)) {
player.sendMessage("Your IP was allowed!");

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Samthelord1
Few things:

- Your first 'if' statement has a semicolon before the {, that won't work.
- The 'allow' list is either going to be equal to "allow" stringlist in config, or new ArrayList. You shouldn't do it that way if you want to do multiple things with it.

Anyways, you never added the ip to the 'allow' list.

 

Assist that will be done either manually, or onCommand which I'm adding to a different class, I am disappointed with myself for semicolons at the end of if statements xD but i'm not sure what you mean by

 

Samthelord1
When using '? 1 : 2' in Java, it's basically an else statement. The question mark asks for true or false. The first one is what you do if condition is true, second one is what you do if condition is false.

Example:

Code:java

player.isFlying() ? player.setFlying(false) : player.setFlying(true);

Get it?

In your case, the method should work - just remember to actually add the ip to the 'allow' arraylist.

 

Assist yeh I get it thanks

Assist how would I check if args is equal to an ip? Also,

do you have any other ideas on how I should add it?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Samthelord1
Equal to what ip? If you want to check if args is equal to someone's "default" ip (not error or allow ip), loop through the keys in configurationsection, and check if any of the values are equal to your arg.

Example config:

Code:

ips:
  playername: '1337.1337'
  anotherplayer: '1234.5678'

Example code:

Code:

ConfigurationSection ips = getConfig().getConfigurationSection("ips");

for(String keys = ips.getKeys(true)) {
    if(getConfig().getString("ips." + keys).equals(args[someint])) {
        // stuff
    }
}

Untested.

 

Assist question 1. I was kinda wondering how it would know it was a ip rather than just someone typing /allow saoiijdaw i thought i could check for a-z and check if there are like 3+ .'s
question 2. would a command like /allow 80.12.34.56 count as more or 1 args?

 

Samthelord1
Can you please elaborate your first question? It's kind of confusing.

2. 1 argument. Bukkit splits the command args with " ".

 

Assist does this mean that in the config the space would be there though? I could check for it then replace a space with a dot in this case, but would that add more strings??

EDIT: I think not for last one.