Solved Stopping scheduleSyncRepeatingTask

Hey!
So I'm trying to make a little plugin that spawns firework rockets at certain locations when somebody issues a command. It shouldn't be just one rocket per location; I want the spawning to go on until somebody issues another command. For this purpose, I use a 'scheduleSyncRepeatingTask'.
Now, the first command, the spawning and the repeating of the whole, works just fine. The problem is the second command. I've been trying to stop the Bukkit Task with Bukkit.getScheduler().cancelTask(id); but they just keep spawning.
I've also tried to use an 'if' loop with the condition that the code inside the Runnable will only be run if a boolean is true. That way, I thought that if I set the boolean to 'false' if the second command is issued, the code wouldn't be executed anymore. However, this didn't work either.

I've double-checked my plugin.yml; that one is OK. Eclipse is giving me no errors at all.
I hope that somebody can help me!





This is my code:

Code:java

//A package
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.plugin.java.JavaPlugin;
//And some imports for the Fireworks
 
public final class VuurwerkShow extends JavaPlugin {
    public boolean onCommand(final CommandSender sender, Command cmd, final String commandLabel, String[] args) {
        if (commandLabel.equalsIgnoreCase("startfireworks")) {
 
            //Here are some ArrayLists to be used by the code in the Runnable (working fine)
 
            int scheduler = Bukkit.getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
                public void run() {
                    //Some code that spawns random Firework Rockets at specified locations (working fine)
                }
            }, 0, 20);
 
            if(commandLabel.equalsIgnoreCase("stopfireworks")) {
                Bukkit.getScheduler().cancelTask(scheduler); //This part isn't working.
            }
        }
        return true;
    }
}

 

I'll link you to a very recent Thread I answered: http://forums.bukkit.org/threads/self-cancelling-syncrepeatingtask.226383/#post-2219311

 

The method "scheduleSyncRepeatingTask" returns a BukkitTask. Simply store that BukkitTask to a variable and then use the "cancelTask" method using it as a parameter when you want it to end.

Code:java

// Store this variable somewhere
BukkitTask taskToCancel = null;
 
// Schedule the task somewhere
taskToCancel = getScheduler().scheduleSyncRepeatingTask( plugin , runnable , delay , period );
 
// Cancel it using the stored variable
getScheduler().cancelTask( taskToCancel );

 

TheDummy Thanks for your help, but it seems that the method returns an int. And when I turn it into an int, it doesn't work either: the second command gives me no response..

werter318 Thanks for your help! This is what I made:

Code:java

class Stopper extends BukkitRunnable {
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
if(commandLabel.equalsIgnoreCase("stopvuurwerk")) {
this.cancel();
}
return true;
}
}

I'm so sorry, but I'm sort of a dummy at making multiple classes. It gives me the error: 'The type Stopper must implement the inherited abstract method Runnable.run()' How should I implement it?

(And I like your signature xD)

 

Omniscimus I'm sorry about that. I always mix up the two types. One will return an int and the other returns a BukkitTask. Some principle applies though. Store the taskID integer and then use the integer to cancel it.

The "must implement Runnable.run()" means you need to make a method in the format:

Code:java

@Override
public void run()
{
// Put code for what the task should do here
}

 

Many thanks! I fixed it by putting the cancelTask method in an if-loop with a boolean as the condition inside the Runnable. The command switches the boolean.