SQL DB - Coins not increasing bug

Hello everyone.
I'm writing here because i've encountered a bug that i can't fix.

Im just going to explain it all.
So this plugin is quite simple, whenever a player kills another player, 5 points will be added to hes account which is stored in a MySQL database. But there is a problem. Whenever the player kills another player, 5 coins is added. But if he kill a player more, hes credits will stay at 5 and not increase.
Any help regarding this bug will be greatly appreciated. And as Bukkit forums attachment function dosen't work, im gonna leave a mediafile link to the source code.

Thanks in advance!
Link to the 4 src files
<Edit by Moderator: Redacted mediafire url>

The zip file includes the 4 files.
~DivineStudios

 

Andq1
Without looking at the source code, by the sounds of it, you are setting the players credits to 5, rather than adding 5 on. If you are using MySQL, try getting the players score, then adding 5 points, then set their score back in the table.

 

GusGold To optimise this you could do this in one query rather than one. For example use this:

Code:java

SET coins = coins + AMOUNT_TO_ADD

This will set coins to the current coins value plus the amount to add.

 

Ad237
Nice to know

 

This is how the coin generating system works

Code:java

public void onEntityDeath(EntityDeathEvent evt) {
        try {
            if (evt instanceof PlayerDeathEvent) {
                PlayerDeathEvent event = (PlayerDeathEvent) evt;
                Player killer = event.getEntity().getKiller();
                String username = killer.getDisplayName();
                if (!database.checkUserExists(username))
                    database.createUser(username);
                int current = database.getUsersCoinCount(username);
                int get = Integer.parseInt(database
                        .getSetting("coins_per_kill"));
                database.setUsersCoinCount(username, current + get);
            }
        } catch (Exception e) {
 
        }
 
    }

 

1. You do not need this:

Code:

 try {
if (evt instanceof PlayerDeathEvent) {
PlayerDeathEvent event = (PlayerDeathEvent) evt;

Just use the PlayerDeathEvent directly.

2. Check if the killer actually is a Player.
Because if not, your code will cause an error when trying to assign this killer entity to a Player object.

3.

Code:

 int get = Integer.parseInt(database
.getSetting("coins_per_kill"));

I guess (and hope) your "coins_per_kill" setting is an integer in your DB.
So you do not need to use "Integer.parseInt()". The DB will directly return an integer here.
Storing this as String does not make sense. Use an integer or decimal value like float or double.

 

Im sorry for my lack of knowledge, but this plugin was developed by a private developer i had contact to. Now he can't assist me any longer. While i appreciate your help, i can't seem to get this working, using the feedback you gave me. If you could post the code, with the tweaks i'd be very greatfull. Anyways, thanks for your help.

And yes coins_per_kill is a setting in the DB

Bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bump

 

Bump...

 

We are not here to give you the code. We help you with small things but asking to someone to fix your whole code is annoying. If this was developed by another developer and you have no knowledge in this then you need to contact them. It is hard for us to find the problem without knowing how your databases are set up and what errors your getting etc.