Speed command Isn't working right

Discussion in 'Plugin Development' started by random_username, Dec 19, 2013.

Thread Status:
Not open for further replies.
  1. Offline

    random_username

    Hello, I am trying to make a speed command for my plugin, but It isn't working right. What happens is that after setting my speed to something, when I change it again, I cannot move. i.e. I set my flight speed to 10, then change it to 4. After changing it, I can only move up and down. This is happening with both fly speed and walk speed. The console doesn't display any errors. Any ideas on how to solve this, and could I also please know what am I doing wrong? :) Code:
    Code:java
    1.     private Main main;
    2.  
    3.     public speed(Main main)
    4.     {
    5.         this.main = main;
    6.     }
    7.  
    8.     @Override
    9.     public boolean onCommand(CommandSender Sender, Command cmd, String commandLabel, String[] args){
    10.         String noperm = main.getConfig().getString("NoPermission").replace("&", "§");
    11.         String prefix = main.getConfig().getString("Prefix").replace("&", "§");
    12.           if(cmd.getName().equalsIgnoreCase("speed")){
    13.  
    14.               if(!(args.length == 1 || args.length == 2)){
    15.  
    16.               }if(args.length == 1){
    17.                   if(Sender instanceof Player){
    18.                       Player player = (Player) Sender;
    19.                   if(player.hasPermission("pcommands.speed")){
    20.                       int speed = 0;
    21.  
    22.                       try{
    23.                           speed = Integer.parseInt(args[0]);
    24.                       }catch(NumberFormatException e){
    25.                           Sender.sendMessage(prefix + "§4Speed must be a whole number!");
    26.                           return true;
    27.                       }
    28.                       if(speed >10 || speed < 1){
    29.                           Sender.sendMessage(prefix + "§4Speed can only be from 1-10!");
    30.                           return true;
    31.                       }else{
    32.                       Float f = Float.valueOf(speed / 10);
    33.                       if(player.isFlying()){
    34.                           player.setFlySpeed(f);
    35.                           player.sendMessage(prefix + "§3Set flight speed to " + args[0]);
    36.                       }else{
    37.                           player.setWalkSpeed(f);
    38.                           player.sendMessage(prefix + "§3Set walk speed to " + args[0]);
    39.                       }
    40.  
    41.  
    42.                   }
    43.                   }else{
    44.                       Sender.sendMessage(prefix + noperm);
    45.                   }
    46.                   }else{
    47.                       Sender.sendMessage("Console usage: /speed <number> <player>");
    48.                   }
    49.               }if(args.length == 2){
    50.                   if(Sender.hasPermission("pcommands.speed.others")){
    51.                       Player target = Bukkit.getPlayer(args[1]);
    52.                       if(target == null){
    53.                           Sender.sendMessage(prefix + "§4Player not found!");
    54.                       }else{
    55.                           int speed = 0;
    56.  
    57.                           try{
    58.                               speed = Integer.parseInt(args[0]);
    59.                           }catch(NumberFormatException e){
    60.                               Sender.sendMessage(prefix + "§4Speed must be a whole number!");
    61.                               return true;
    62.                           }
    63.                           if(speed >10 || speed < 1){
    64.                               Sender.sendMessage(prefix + "§4Speed can only be from 1-10!");
    65.                               return true;
    66.                           }else{
    67.  
    68.                           Float f = Float.valueOf(speed / 10);
    69.  
    70.                           if(target.isFlying()){
    71.                               target.setFlySpeed(f);
    72.                               target.sendMessage(prefix + "§3Set your flight speed to " + args[0]);
    73.                               Sender.sendMessage(prefix + "§3Set " + args[1] + "'s flight speed to " + args[0]);
    74.                           }else{
    75.                               target.setWalkSpeed(f);
    76.                               target.sendMessage(prefix + "§3Set your walk speed to " + args[0]);
    77.                               Sender.sendMessage(prefix + "§3Set " + args[1] + "'s walk speed to " + args[0]);
    78.                           }
    79.                       }
    80.                       }
    81.                   }else{
    82.                       Sender.sendMessage(prefix + noperm);
    83.                   }
    84.               }
    85.               }
    86.         return false;
    87.     }

    Thanks for helping :D
     
    random_username, Dec 19, 2013
    #1
  2. Offline

    random_username

    bump, any Ideas? :)
     
    random_username, Dec 21, 2013
    #2
  3. Offline

    lordbobby104

    random_username hmmm interesting. Try removing the division and just enter in the .whatever because I know that works for me.
     
    lordbobby104, Dec 21, 2013
    #3
  4. Offline

    random_username

    bump, any other Ideas?
     
    random_username, Dec 22, 2013
    #4
  5. Offline

    random_username

    bump. Any ideas on how to solve it?
     
    random_username, Dec 23, 2013
    #5
  6. Offline

    random_username

    bump
     
    random_username, Dec 25, 2013
    #6
  7. Offline

    xize

    random_username
    I had the same problem though what I did whas make a public variable outside the command holding the default speed before changing it and then when I wanted to go back to normal speed I used that value, you may want to check what the default value is by printing it out;)
     
    xize, Dec 25, 2013
    #7
    random_username likes this.
  8. Offline

    random_username

    Hello, thanks for the reply :D This problem isn't happening just while going to the normal speed, but while changing your speed after using the command once. Would that work for this as well? Maybe While changing speed, set it to that default value, and changing it to the desired value?
     
    random_username, Dec 25, 2013
    #8
  9. Offline

    xize

    random_username
    it will work, basicly the problem probably is if you set setWalkSpeed(); or setFlySpeed() you override the default value this means when you set it back to 0 you can't walk but if you store the default value in a other variable before changing it you are safe:p

    a example what I should do is:
    Code:
    public Float walkSpeed;
 
public boolean onCommand(CommandSender sender, Command cmd, CommandLabel label, String[] args) {
if(cmd.getName().equalsIgnoreCase("someCommand")) {
    if(sender instanceof Player) {
      Player p = (Player) sender;
      if(args.length == 1) {
         if(args[0].equalsIgnoreCase("on")) {
         walkSpeed = p.getWalkSpeed();
         p.setWalkSpeed(200);
      } else if(args[0].equalsIgnoreCase("off")) {
              p.setWalkSpeed(walkSpeed);
      }
  }
   }
}
return false;
}
    its just a psuodo not really safe to use though, but what you can also do is printing the getWalkSpeed() before changing it so you don't have to store its value to set it back but you can just use that printed value instead;), the default walk speed is not 0 :p
     
    xize, Dec 25, 2013
    #9
  10. Offline

    random_username

    xize
    It's still not working, I'm trying this:
    Code:java
    1.     private Main main;
    2.  
    3.     public speed(Main main)
    4.     {
    5.         this.main = main;
    6.     }
    7.  
    8.     public Float walkspeed = 0.2F;
    9.     public Float flyspeed = 0.1F;
    10.  
    11.     @Override
    12.     public boolean onCommand(CommandSender Sender, Command cmd, String commandLabel, String[] args){
    13.         String noperm = main.getConfig().getString("NoPermission").replace("&", "§");
    14.         String prefix = main.getConfig().getString("Prefix").replace("&", "§");
    15.           if(cmd.getName().equalsIgnoreCase("speed")){
    16.  
    17.               if(!(args.length == 1 || args.length == 2)){
    18.  
    19.               }if(args.length == 1){
    20.                   if(Sender instanceof Player){
    21.                       Player player = (Player) Sender;
    22.                   if(player.hasPermission("pcommands.speed")){
    23.                       int speed = 0;
    24.  
    25.                       try{
    26.                           speed = Integer.parseInt(args[0]);
    27.                       }catch(NumberFormatException e){
    28.                           Sender.sendMessage(prefix + "§4Speed must be a whole number!");
    29.                           return true;
    30.                       }
    31.                       if(speed >10 || speed < 1){
    32.                           Sender.sendMessage(prefix + "§4Speed can only be from 1-10!");
    33.                           return true;
    34.                       }else{
    35.                       Float f = Float.valueOf(speed / 10);
    36.                       if(player.isFlying()){
    37.                           player.setFlySpeed(flyspeed);
    38.                           player.setFlySpeed(f);
    39.                           player.sendMessage(prefix + "§3Set flight speed to " + args[0]);
    40.                       }else{
    41.                           player.setWalkSpeed(walkspeed);
    42.                           player.setWalkSpeed(f);
    43.                           player.sendMessage(prefix + "§3Set walk speed to " + args[0]);
    44.                       }
    45.  
    46.  
    47.                   }
    48.                   }else{
    49.                       Sender.sendMessage(prefix + noperm);
    50.                   }
    51.                   }else{
    52.                       Sender.sendMessage("Console usage: /speed <number> <player>");
    53.                   }
    54.               }if(args.length == 2){
    55.                   if(Sender.hasPermission("pcommands.speed.others")){
    56.                       Player target = Bukkit.getPlayer(args[1]);
    57.                       if(target == null){
    58.                           Sender.sendMessage(prefix + "§4Player not found!");
    59.                       }else{
    60.                           int speed = 0;
    61.  
    62.                           try{
    63.                               speed = Integer.parseInt(args[0]);
    64.                           }catch(NumberFormatException e){
    65.                               Sender.sendMessage(prefix + "§4Speed must be a whole number!");
    66.                               return true;
    67.                           }
    68.                           if(speed >10 || speed < 1){
    69.                               Sender.sendMessage(prefix + "§4Speed can only be from 1-10!");
    70.                               return true;
    71.                           }else{
    72.  
    73.                           Float f = Float.valueOf(speed / 10);
    74.  
    75.                           if(target.isFlying()){
    76.                               target.setFlySpeed(flyspeed);
    77.                               target.setFlySpeed(f);
    78.                               target.sendMessage(prefix + "§3Set your flight speed to " + args[0]);
    79.                               Sender.sendMessage(prefix + "§3Set " + args[1] + "'s flight speed to " + args[0]);
    80.                           }else{
    81.                               target.setWalkSpeed(walkspeed);
    82.                               target.setWalkSpeed(f);
    83.                               target.sendMessage(prefix + "§3Set your walk speed to " + args[0]);
    84.                               Sender.sendMessage(prefix + "§3Set " + args[1] + "'s walk speed to " + args[0]);
    85.                           }
    86.                       }
    87.                       }
    88.                   }else{
    89.                       Sender.sendMessage(prefix + noperm);
    90.                   }
    91.               }
    92.               }
    93.         return false;
    94.     }

    Any ideas on what am I doing wrong? :)
     
    random_username, Dec 25, 2013
    #10
  11. Offline

    xize

    random_username
    the problem is that you need to check if your fly speed is higher or lower than the default fly speed I recommend to make a toggle;)
    because now you do setFlySpeed(flyspeed); and then override it again with a faster fly speed.

    you could make a simple boolean to check whenever the player is flying faster or slower or equals with default.

    Code:
    public boolean isFlyingOtherThanDefault(Float speed) {
      if(speed != flyspeed) {
           return true;
      }
     return false;
}
    then do something like this in your command:

    Code:
    if(player.isFlying()) {
     if(isFlyingOtherThanDefault(player.getFlySpeed())) {
           player.setFlySpeed(flyspeed);
           //toggled fly speed to normal
     } else {
          flyspeed = player.getFlySpeed();
          player.setFlySpeed(your custom value);
          //change speed, note that we have added the default speed to the public variable outside the command
    }
}
     
    xize, Dec 25, 2013
    #11
  12. Offline

    random_username

    xize
    Hello, sorry for the late reply :p I have the following code now:
    Code:java
    1.     private Main main;
    2.  
    3.     public speed(Main main)
    4.     {
    5.         this.main = main;
    6.     }
    7.  
    8.     public Float walkspeed = 0.2F;
    9.     public Float flyspeed = 0.1F;
    10.  
    11.     public boolean isFlyingOtherThanDefault(Float speed) {
    12.         if(speed != flyspeed) {
    13.             return true;
    14.         }
    15.         return false;
    16.     }
    17.  
    18.     public boolean iswalkingOtherThanDefault(Float speed) {
    19.         if(speed != walkspeed) {
    20.             return true;
    21.         }
    22.         return false;
    23.     }
    24.  
    25.     @Override
    26.     public boolean onCommand(CommandSender Sender, Command cmd, String commandLabel, String[] args){
    27.         String noperm = main.getConfig().getString("NoPermission").replace("&", "§");
    28.         String prefix = main.getConfig().getString("Prefix").replace("&", "§");
    29.           if(cmd.getName().equalsIgnoreCase("speed")){
    30.  
    31.               if(!(args.length == 1 || args.length == 2)){
    32.  
    33.               }if(args.length == 1){
    34.                   if(Sender instanceof Player){
    35.                       Player player = (Player) Sender;
    36.                   if(player.hasPermission("pcommands.speed")){
    37.                       int speed = 0;
    38.  
    39.                       try{
    40.                           speed = Integer.parseInt(args[0]);
    41.                       }catch(NumberFormatException e){
    42.                           Sender.sendMessage(prefix + "§4Speed must be a whole number!");
    43.                           return true;
    44.                       }
    45.                       if(speed >10 || speed < 1){
    46.                           Sender.sendMessage(prefix + "§4Speed can only be from 1-10!");
    47.                           return true;
    48.                       }else{
    49.                       Float f = Float.valueOf(speed / 10);
    50.                       if(player.isFlying()){
    51.                           if(isFlyingOtherThanDefault(player.getFlySpeed())){
    52.                           player.setFlySpeed(flyspeed);
    53.                               player.sendMessage(prefix + "§3Set flight speed to default. Try again to set to the desired value.");
    54.                           }else{
    55.                               player.setFlySpeed(f);
    56.                           player.sendMessage(prefix + "§3Set flight speed to " + args[0]);
    57.                           }
    58.                           }else{
    59.                           if(iswalkingOtherThanDefault(player.getWalkSpeed())){
    60.                           player.setWalkSpeed(walkspeed);
    61.                               player.sendMessage(prefix + "§3Set Walk speed to default. Try again to set to the desired value.");
    62.                               System.out.println("Walk speed = " + walkspeed);
    63.                               System.out.println("Current = " + player.getWalkSpeed());
    64.                           }else{
    65.                           player.setWalkSpeed(f);
    66.                           player.sendMessage(prefix + "§3Set walk speed to " + args[0]);
    67.                           }
    68.                       }
    69.  
    70.  
    71.                   }
    72.                   }else{
    73.                       Sender.sendMessage(prefix + noperm);
    74.                   }
    75.                   }else{
    76.                       Sender.sendMessage("Console usage: /speed <number> <player>");
    77.                   }
    78.               }if(args.length == 2){
    79.                   if(Sender.hasPermission("pcommands.speed.others")){
    80.                       Player target = Bukkit.getPlayer(args[1]);
    81.                       if(target == null){
    82.                           Sender.sendMessage(prefix + "§4Player not found!");
    83.                       }else{
    84.                           int speed = 0;
    85.  
    86.                           try{
    87.                               speed = Integer.parseInt(args[0]);
    88.                           }catch(NumberFormatException e){
    89.                               Sender.sendMessage(prefix + "§4Speed must be a whole number!");
    90.                               return true;
    91.                           }
    92.                           if(speed >10 || speed < 1){
    93.                               Sender.sendMessage(prefix + "§4Speed can only be from 1-10!");
    94.                               return true;
    95.                           }else{
    96.  
    97.                           Float f = Float.valueOf(speed / 10);
    98.  
    99.                           if(target.isFlying()){
    100.                               if(isFlyingOtherThanDefault(target.getFlySpeed())){
    101.                               target.setFlySpeed(flyspeed);
    102.                                   Sender.sendMessage(prefix + "§3Set flight speed to default. Try again to set to the desired value.");
    103.                               }else{
    104.                               target.setFlySpeed(f);
    105.                               target.sendMessage(prefix + "§3Set your flight speed to " + args[0]);
    106.                               Sender.sendMessage(prefix + "§3Set " + args[1] + "'s flight speed to " + args[0]);
    107.                               }
    108.                               }else{
    109.                               if(iswalkingOtherThanDefault(target.getWalkSpeed())){
    110.                               target.setWalkSpeed(walkspeed);
    111.                                   Sender.sendMessage(prefix + "§3Set walk speed to default. Try again to set to the desired value.");
    112.                               }else{
    113.                               target.setWalkSpeed(f);
    114.                               target.sendMessage(prefix + "§3Set your walk speed to " + args[0]);
    115.                               Sender.sendMessage(prefix + "§3Set " + args[1] + "'s walk speed to " + args[0]);
    116.                               }
    117.                           }
    118.                       }
    119.                       }
    120.                   }else{
    121.                       Sender.sendMessage(prefix + noperm);
    122.                   }
    123.               }
    124.               }
    125.         return false;
    126.     }

    Each time I try the speed command, it says my speed has been set to default. After that, when I try again, it still says the same. I tried printing the default and current values in the console each time the command is performed. When i join the game, my walking speed is 0.2 and my Flying speed is 0.1 . Each time I try the command, the speeds are equal to its default values. Any idea on what am I doing wrong? :)
     
    random_username, Dec 27, 2013
    #12
  13. Offline

    xize

    You didn't change the fly speed on else :p
    random_username

    edit
    readed it wrong hmm you could try .equals(...) instead of != on the boolean
     
    xize, Dec 27, 2013
    #13
  14. Offline

    random_username

    xize
    I tried changing the methods to:
    Code:java
    1.  public boolean isFlyingOtherThanDefault(Float speed) {
    2. if(!speed.equals(flyspeed)) {
    3. return true;
    4. }
    5. return false;
    6. }
    7.  
    8. public boolean iswalkingOtherThanDefault(Float speed) {
    9. if(!speed.equals(walkspeed)) {
    10. return true;
    11. }
    12. return false;
    13. }

    As you said. This time, the boolean check is working. The only problem is that after the speed is set to the default, when I use the command again, It won't let me move. Is there any other ways to solve it? Btw, thanks so much for the help! :D
    edit: Command is only working when the speed argument is 10. The fly speed I use is args[0] / 10, any idea why this is happening?
     
    random_username, Dec 27, 2013
    #14
  15. Offline

    xize

    random_username
    hmm what happends when you change 10 to lower? because default speed is 2 so when you set the speed lower than 20 its always lower.
     
    xize, Dec 27, 2013
    #15
  16. Offline

    random_username

    xize When I change it to lower than 10, after setting it to default, I am no longer able to move, just as before :)
     
    random_username, Dec 27, 2013
    #16
  17. Offline

    xize

    random_username
    I'm wondering if the float value 'f' is correct, could you print that value when it sets the speed and test it with different speed values inside the arguments?, I'm at my phone so its hard to read :p
     
    xize, Dec 27, 2013
    #17
Thread Status:
Not open for further replies.

Share This Page