[SOLVED] Shooting fireballs from a enderdragon

I'm currently adding new functions into RideThaDragon, one of them should make it possible to shoot fireballs. This is the code I tried:

Code:java

  @EventHandler(ignoreCancelled = false)
  public void shoot(PlayerInteractEvent event)
  {
    if(event.getAction() != Action.LEFT_CLICK_AIR)
      return;
    Player p = event.getPlayer();
    if(!p.hasPermission("ridetha.shoot"))
      return;
    String pn = p.getName();
    if(!plugin.dragons.containsKey(pn))
      return;
    LivingEntity ld = plugin.dragons.get(pn);
    Entity pa = ld.getPassenger();
    if(pa == null || pa.getUniqueId() != p.getUniqueId())
      return;
    final Fireball f = ld.launchProjectile(Fireball.class);
    f.setShooter(p);
    System.out.print("Shooted:"+f.getLocation().getX()+" - "+f.getLocation().getY()+" - "+f.getLocation().getZ());
    plugin.getServer().getScheduler().scheduleSyncRepeatingTask(plugin, new Runnable(){public void run(){
        if(!f.isDead())
            System.out.print(f.getLocation().getX()+" - "+f.getLocation().getY()+" - "+f.getLocation().getZ());
    }}, 0L, 1L);
  }

And this is the debugging output:
10:49:26 [INFORMATION] Shooted:87.29999998807868 - 154.5999999999992 - 2336.194694107435

So the ball seems to die instantly.

Any ideas?

 

Your firing a fireball from a playername the way I see it. get(pn) get playername. That is ur livingentity. Hint: EntityType.ENDER_DRAGON

 

plugin.dragons is a HashMap playername -> LivingEntity, where the LivingEntity is the dragon the player owns. How else should this code work:

Code:java

Entity pa = ld.getPassenger();
if(pa == null || pa.getUniqueId() != p.getUniqueId())
return;

The player can't be a passenger of itself...

The codes are correct, it even spawns the fireball as you see with the debugging message, but it seems like it dies instantly as no debugging message from the runnable appears in the log.

 

Code:java

 
net.minecraft.server.World notchWorld = null;
EntityFireball notchEntity = null;
Vector velocity = null;
CraftPlayer playerE = null;
playerE = (CraftPlayer) player;
Location location = player.getEyeLocation();
notchWorld = ((CraftWorld) player.getWorld()).getHandle();
EntityLiving playerEntity = playerE.getHandle();
notchEntity = new EntityFireball(notchWorld, playerEntity,
location.getX(), location.getY(), location.getZ());
velocity = player.getEyeLocation().getDirection().multiply(5);
notchWorld.addEntity(notchEntity);
Entity Bukkitentity = notchEntity.getBukkitEntity();
Bukkitentity.teleport(player.getEyeLocation());
Bukkitentity.setVelocity(velocity);
World world = player.getWorld();

I took this code from an unactive project. You can tinker with it as you will. It may work.

 

Thanks, new code:

Code:java

  @EventHandler(ignoreCancelled = false)
  public void shoot(PlayerInteractEvent event)
  {
    if(event.getAction() != Action.LEFT_CLICK_AIR)
      return;
    Player p = event.getPlayer();
    if(!p.hasPermission("ridetha.shoot"))
      return;
    String pn = p.getName();
    if(!plugin.dragons.containsKey(pn))
      return;
    LivingEntity ld = plugin.dragons.get(pn);
    Entity pa = ld.getPassenger();
    if(pa == null || pa.getUniqueId() != p.getUniqueId())
      return;
    Location loc = ld.getEyeLocation();
    net.minecraft.server.World nw = ((CraftWorld)ld.getWorld()).getHandle();
    EntityFireball nf = new EntityFireball(nw, ((CraftPlayer)p).getHandle(), loc.getX(), loc.getY(), loc.getZ());
    nw.addEntity(nf);
    final Fireball f = (Fireball)nf.getBukkitEntity();
    f.setVelocity(loc.getDirection().multiply(5));
    System.out.print("Shooted:"+f.getLocation().getX()+" - "+f.getLocation().getY()+" - "+f.getLocation().getZ());
    plugin.getServer().getScheduler().scheduleSyncRepeatingTask(plugin, new Runnable(){public void run(){
        if(!f.isDead())
            System.out.print(f.getLocation().getX()+" - "+f.getLocation().getY()+" - "+f.getLocation().getZ());
    }}, 0L, 1L);
  }

Debugging output:

Code:

11:50:47 [INFORMATION] Shooted:73.49999998807903 - 67.00000000000004 - 2340.994694107421
11:50:47 [INFORMATION] 73.49999998807903 - 67.00000000000004 - 2340.994694107421

So it lives a little bit longer, but before it's even able to move it dies.

 

How about going back to your original code, but including the setVelocity() call? The fireball may have been dying because it didn't have a velocity.

 

With this I could finally see the fireball in-game, but i instantly died (looked like it crashed with a ComplexEntityPart of the dragon). But I have another code I'm currently working on which seems to work better. I have to tune it a bit more before I show it...

//EDIT: Here's the final code. Please note that it's designed for RideThaDragon, hence you can't simply copy&paste it for other purposes and you may not like the result:

Code:java

  @EventHandler(ignoreCancelled = false)
  public void shoot(PlayerInteractEvent event)
  {
    if(event.getAction() != Action.LEFT_CLICK_AIR)
      return;
    Player p = event.getPlayer();
    if(!p.hasPermission("ridetha.shoot"))
      return;
    String pn = p.getName();
    if(!plugin.dragons.containsKey(pn))
      return;
    LivingEntity ld = plugin.dragons.get(pn);
    Entity pa = ld.getPassenger();
    if(pa == null || pa.getUniqueId() != p.getUniqueId())
      return;
    Location loc = ld.getLocation();
    float yaw = loc.getYaw();
 
    if(yaw < 22.5F || yaw > 337.5F)
    {
      loc.setZ(loc.getZ() - 10.0F);
    }
    else if(yaw < 67.5F)
    {
      loc.setZ(loc.getZ() - 7.0F);
      loc.setX(loc.getX() + 7.0F);
    }
    else if(yaw < 112.5F)
    {
      loc.setX(loc.getX() + 10.0F);
    }
    else if(yaw < 157.5F)
    {
      loc.setZ(loc.getZ() + 7.0F);
      loc.setX(loc.getX() + 7.0F);
    }
    else if(yaw < 202.5F)
    {
      loc.setZ(loc.getZ() + 10.0F);
    }
    else if(yaw < 247.5F)
    {
      loc.setZ(loc.getZ() + 7.0F);
      loc.setX(loc.getX() - 7.0F);
    }
    else if(yaw < 292.5)
    {
      loc.setX(loc.getX() - 10.0F);
    }
    else
    {
      loc.setZ(loc.getZ() - 7.0F);
      loc.setX(loc.getX() - 7.0F);
    }
 
    yaw += 180.0F;
    while(yaw > 360)
      yaw -=360;
    loc.setYaw(yaw);
 
    V10Dragon vd = (V10Dragon)((CraftLivingEntity)ld).getHandle();
    if(vd.upDown == 1)
      loc.setPitch(45.0F);
    else if(vd.upDown == 2)
      loc.setPitch(-45.0F);
    else
      loc.setPitch(0.0F);
 
    net.minecraft.server.World nw = ((CraftWorld)ld.getWorld()).getHandle();
    EntityFireball nf = new EntityFireball(nw, ((CraftPlayer)p).getHandle(), loc.getX(), loc.getY(), loc.getZ());
    nw.addEntity(nf);
    final Fireball f = (Fireball)nf.getBukkitEntity();
    f.teleport(loc);
    double speed = 5.0D;
    if(!vd.br)
    {
      speed += plugin.rideSpeed;
      speed += vd.fl;
    }
    Vector v = loc.getDirection().multiply(speed);
    f.setDirection(v);
    f.setVelocity(v);
  }