Solved Skull GUI

I am trying to make a GUI for people to see all of the heads of people that are still alive. Here is the current code:

Code:java

public static Inventory heads = Bukkit.createInventory(null, 27, ChatColor.GREEN + "Teleport");
static {
 
ItemStack skull = new ItemStack(Material.SKULL_ITEM, 1, (short) SkullType.PLAYER.ordinal());
SkullMeta meta = (SkullMeta) skull.getItemMeta();
int i = 0;
for (Player p : Main.alive){ // Main.alive is not the issue as it works fine in other parts of the code
 
 
meta.setOwner(p.getName());
meta.setDisplayName(ChatColor.LIGHT_PURPLE + p.getName());
skull.setItemMeta(meta);
heads.setItem(i, skull);
i++;
}
 
 
}

For some reason the inventory is always empty. It has the title "Teleport" though and the correct number of slots. Also, there are no errors. Any help is greatly appreciated thanks!!

 

It's not the issue, just thought I'd point it out: you're first adding one to int i, then using i - 1. Why don't you just add one to i at the end... Seems a bit odd to do it like this, as you're modifying i twice..

 

Yeah I could do that.
EDIT: fixed that.... if only that would fix the real issue xD

 

Works fine for me:

Code:java

public void onEnable() {
    Inventory heads = Bukkit.createInventory(null, 27, ChatColor.GREEN + "Teleport");
 
    ItemStack skull = new ItemStack(Material.SKULL_ITEM, 1, (short) SkullType.PLAYER.ordinal());
    SkullMeta meta = (SkullMeta) skull.getItemMeta();
    int i = 0;
 
    for (Player p : Bukkit.getOnlinePlayers()){
        meta.setOwner(p.getName());
        meta.setDisplayName(ChatColor.LIGHT_PURPLE + p.getName());
        skull.setItemMeta(meta);
        heads.setItem(i, skull);
        i++;
    }
 
    for(Player p : Bukkit.getOnlinePlayers()){
        p.openInventory(heads);
    }
}

 

hmm thats really strange... let me try with not using Main.alive. That might be the issue I guess.

TheMcScavenger Yeah worked fine for me with all online players... That's really weird because the scoreboard works fine with using Main.alive but the inventory doesn't...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Is it a player list?

Code:java

public static List<Player> players = new ArrayList<Player>();

 

Yep

 

Is it empty? XD

Code:java

Bukkit.broadcastMessage(Main.alive.toString());

 

Okay I did that, and now there are 2 players in the list, but only one skull in the GUI.

 

Is it the first or the second name in the list? Maybe it's overriding the first..?

 

Second name isn't showing up.
"[Server] INFO [CraftPlayer{name=TheFancyWhale}, CraftPlayer{name=kierdo1000}]"
but only TheFancyWhale head shows up

 

Just edit my code my shows all online players just change it to check a world or something.

Code:

    public void Online(Player player){
        Player[] players = Bukkit.getServer().getOnlinePlayers();
               
                  ItemStack i = new ItemStack(Material.SKULL_ITEM);
                  ItemMeta m = i.getItemMeta();
                  i.setDurability((short) 3);
                  Inventory spectate = Bukkit.createInventory(player, 54, "Current Players " + "[" + players.length + "]");
                  for(int z = 0; z < players.length; z++)
                  {
                      m.setDisplayName(ChatColor.GREEN +players[z].getName());
                      ArrayList<String> nlore = new ArrayList<String>();
                      nlore.add(ChatColor.WHITE + "Current Level : " + ChatColor.GREEN + players[z].getLevel());
                      nlore.add("" + ChatColor.WHITE + "Health : " + ChatColor.GREEN + players[z].getHealth());
                      nlore.add(ChatColor.WHITE + "Food Level : " + ChatColor.GREEN + players[z].getFoodLevel());
                      m.setLore(nlore);
                      i.setItemMeta(m);
                      spectate.setItem(z, i);
                  }
                  player.openInventory(spectate);
              }

 

Tried something similar to that and got it working. Thanks for the help. Still not sure what's wrong with my original code though :/

 

Ill take a look when im free and sort it out

EDIT;

You need to get the first empty slot and add the head for each player... Also use this to get one player

Code:

Player[] players = Bukkit.getServer().getOnlinePlayers();

then to get a player fro that use this

Code:

players[z].getName()

there...

 

Vorqe He already got it working...

 

TheMcScavenger I was showing him what he needed to do to fix his code <removed>, he did it totally wrong so I helped him by giving him my code and the fix for his.


[edit by JaguarJo: removed insult. Please keep this discussion civil. Thanks.]

 

Do you even know what "working" means? It means he doesn't need you to edit code anymore, because his version already does the job without errors. All you're doing is bumping a thread that has already been resolved, as can be seen by the [Solved] tag.


[edit by JaguarJo: removed improper content in quoted comment.]

 

Tried something similar to that and got it working. Thanks for the help. Still not sure what's wrong with my original code though :/ <-- What he said so I fixed it.