Simple Plugin won't work! HELP!

I'm a new Java Dev. and I created a plugin that does 3 things
***Says "Test has been Enabled" during a server start
***Says "Test has been Disabled" during a server shutdown
***Sends a welcome message when you join the server that reads "Welcome to Libertycraft [name]!"

For any reason, the welcome message I cant get to show up.
The disable and enable messages work fine,
please help!
***HERE IS THE CODE***

package me.Bernabeast.plugin;

import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;

public class Test extends JavaPlugin implements Listener{

@Override
public void onEnable(){
System.out.println("Test has been Enabled!");

}
@Override
public void onDisable(){
System.out.println("Test has been Disabled!");
}
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event){
Player player = event.getPlayer();
event.setJoinMessage(ChatColor.AQUA + "Welcome to Libertycraft " + player.getName() + "!");
}




}

 

Code:java

package me.Bernabeast.plugin;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Test extends JavaPlugin implements Listener{
 
public final Logger log = Logger.getLogger("Minecraft"); <----The Defined Logger
 
@Override
public void onEnable(){
PluginManager pm = getServer().getPluginManager(); <-----This is the plugin manager
this.log.info("Test Has been enabled!");
pm.registerEvents(this, this); <-------you always have to register the listeners
}
@Override
public void onDisable(){
this.log.info(" Test Has been disabled!");
}
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event){
Player player = event.getPlayer();
event.setJoinMessage(ChatColor.AQUA + "Welcome to Libertycraft " + player.getName() + "!");
}
}

The rest looked ok
there were a few things wrong that i noticed.
1.) You did not have a logger defined.... i put that in.
a logger is what the plugin uses to contact the console

2.)you did not have a way to register your events. for this you have to use the plugin manager
i added that to the onEnable and took the time to register the event for you. you have to register all Listeners in the main class in the onEnable section. becuase you used the main class as a listener it was easy

3.) you cant use system.out.println in a plugin. you have to use the logger

ex. this.log.info(msg)

 

Instead of:

Code:

event.setJoinMessage(ChatColor.AQUA + "Welcome to Libertycraft " + player.getName() + "!");

Try this:

Code:

player.sendMessage(ChatColor.AQUA + "Welcome to Libertycraft " + player.getName() + "!");

 

Nope:/

 

whats wrong still?

 

You need to register your events in the onEnable() method with getServer().getPluginManager().registerEvents(this, this);

 

Wait what? i'm new so i dont get anything you said...

 

Ahh, ok, so every single class that has events in it needs to be "registered" in the onEnable() method.
getServer().getPluginManager().registerEvents(this(the class with the events in it), this(the class that registered the events));

So, because your event is inside the same exact same class as the onEnable method, you insert "this" and "this" into the two parameter slots. If your events were in a different class (like test.class) then this is how you would do it
getServer().getPluginManager().registerEvents(new test(),this);

 

Did you write your YAML?

 

What he means is put this in your onEnable:

Code:

    pm = getServer().getPluginManager();
pm.registerEvents(this, this);

And this at the top inside your class. (Underneath public class Test extends JavaPlugin implements Listener{)

Code:

public PluginManager pm;

This is needed in every plugin basically.

Also just a few tips:

1. When displaying code in forums use the [CODE ][/ CODE] or [syntax = java ][ /syntax], without the spaces, to keep formatting ("somewhat")

2. If you are extremely to Java then I recomend reading some tutorials everyday and applying them to your test plugins. Most people would tell you to quit trying to use Bukkit api until you have learned Java but I am not most people.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:

public void onEnabled(){
server().getPluginManager().registerEvents(this, this);
}
 
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event){
Player player = event.getPlayer();
player.setJoinMessage(ChatColor.AQUA + "Welcome to Libertycraft " + player.getName() + "!");
}

Bernabeast try that

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

i messaged him and he got it sorted out.... i was new so my post had to be viewed by moderator............

 

Someone fixed it for me thanks anyway guys!