Solved Simple command not working?

I have no idea why this isnt working?

Code:

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel)
    {
        if(commandLabel.equalsIgnoreCase("under"))
        {
            Player player = (Player) sender;
            player.sendMessage("test");
        }
        return true;
    }

if i type /under i dont get an error but it dosent say test?

 

dan14941 1) You didn't include the String array of arguments.
2) Check the command name not the command label - command name supports aliases.
3) Don't cast to a Player without checking it's a Player.
4) Don't cast to a Player if you don't need to access Player methods.

 

AdamQpzm is this ok?

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
    {
        if(cmd.getName().equalsIgnoreCase("under"))
        {
            Player player = (Player) sender;
            player.sendMessage("test");
        }
        return true;
    }

what should i change?

 

dan14941 You're still not checking that it is a Player first.

 

AdamQpzm would i use the instanceOf thing?

 

dan14941 Yep! Although I think you should spend time learning the basics of Java, since this is covered under that. I'd recommend the Oracle tutorials or a Java book.

 

Code:java

    public boolean onCommand(CommandSender sender, Command cmd, String cmdLabel, String[] args) {
    if(cmd.getName().equalsIgnoreCase("under")) {
    if(args.length == 0) {
    if(sender instanceof Player) { 
Player player = (Player) sender;
    player.sendMessage("test");
    }
    return true;
    } else {
p.sendMessage("You are using too many arguments!");
}
}
}

Didn't code in Eclipse, so it could be that some if-and-else things are wrong..

 

Minesuchtiiii Please don't spoon-feed.

 

AdamQpzm
Yes, but they should even see once the code.. so next time they know what to do and don't need to ask again.

 

Minesuchtiiii http://www.javaprogrammingforums.com/cafe/9544-problem-spoon-feeding.html