sign#setLine() not working - updating makes the sign blank!

So, I have this piece of code:

Code:java

@EventHandler
public void onPlayerInteract(PlayerInteractEvent e) {
// Hundreds of lines of code skipped
  Sign s = (Sign) e.getClickedBlock();
  s.setLine(0, "test");
  s.update();
}

If I update the sign, it becomes blank. If i don't, nothing happens. Does anyone know what I am doing wrong?

 

Any debug messages? console errors? anything?

 

@Shaner_X
You can't cast the Block to a sign. You need to cast the blocks' State to a sign.

 

Nope...

@Zombie_Striker I made a mistake. I actually have

Code:java

Sign s = (Sign) e.getClickedBlock().getState()

 

And still not working?

 

@Shaner_X
The piece of code you posted above (with the addition of "getState()" to the end) works just fine for me. There may be something else in your code causing this issue. Would you mind showing us the full class/eventhandler?

 

Nope

That's the only part relevant to the sign, the rest involves chests etc. After that, there is nothing that could possibly override the text on the sign

 

@Shaner_X
Well, there's probably some mistake in there, caused by something like encapsulation or layout of if statements, that's mostly why I wanted to see it, since that exact code works fine when I'm testing.

 

It's not encapsulated in any if statements. When I update the sign, it turns blank hence it is technically working (although I don't know why it's turning blank as the text is supposed to change, not become blank. anyways, here you go:

Code:java

 
    @EventHandler
    public void onBlockInteract(PlayerInteractEvent e) {
        Player buyer = e.getPlayer();
        if ( e.getAction() == Action.RIGHT_CLICK_BLOCK) {
            Sign s;
            try {
                s = (Sign) e.getClickedBlock().getState();
            } catch (Exception ex) {
                return;
            }
            if (! "[Trade]".equalsIgnoreCase(ChatColor.stripColor(s.getLine(0))))  {
                return;
            }
           int x = e.getClickedBlock().getLocation().getBlockX();
           int y = e.getClickedBlock().getLocation().getBlockY();
           int z = e.getClickedBlock().getLocation().getBlockZ();
           String world = e.getClickedBlock().getLocation().getWorld().getName();
 
            BlockState chestState = Bukkit.getServer().getWorld(world).getBlockAt(new Location(e.getClickedBlock().getWorld(), x, y - 1, z)).getState();
            Chest chest = (Chest) chestState;
            Inventory chestInventory = chest.getInventory();
 
            Inventory playerInventory = buyer.getInventory();
           String line1 = s.getLine(1);
           String line2 = s.getLine(2);
           String[] info1 = line1.split(" ");
           String[] info2 = line2.split(" ");
           int amount1 = Integer.parseInt(info2[0]);
           int amount2 = Integer.parseInt(info2[0]);
           String item_name1 = info1[1].toUpperCase();
           String item_name2 = info2[1].toUpperCase();
            ItemStack item1 = new ItemStack(Enum.valueOf(Material.class, item_name1), amount1); // What the player gets
           ItemStack item2 = new ItemStack(Enum.valueOf(Material.class, item_name2), amount2); // What the player pays
 
           if (!playerInventory.contains(Enum.valueOf(Material.class, item_name2))) {
              buyer.sendMessage(ChatColor.translateAlternateColorCodes('&', "&a[&eTradeShop&a] &cYou do not have &e"
                  + amount2 + " " + item_name2.toLowerCase()));
              return;
           }
 
           if (!chestInventory.contains(Enum.valueOf(Material.class, item_name1))) {
              buyer.sendMessage(ChatColor.translateAlternateColorCodes('&', "&a[&eTradeShop&a] &cThis shop does not have &e"
                  + amount1 + " " + item_name1.toLowerCase()));
               s.setLine(0, ChatColor.RED + "[Trade]"); // TODO NOT WORKING!!!
              return;
           }
 
           s.setLine(0, ChatColor.GREEN + "[Trade]");
           e.getClickedBlock().getState().update();
           buyer.sendMessage("test");
 
           playerInventory.addItem(item1);
           playerInventory.removeItem(item2);
           chestInventory.addItem(item2);
           chestInventory.removeItem(item1);
 
           buyer.sendMessage(ChatColor.translateAlternateColorCodes('&', "&a[&eTradeShop&a] &aYou have traded &e" + amount1 + " "
           + item_name1.toLowerCase() + " &a for &e" + amount2 + " " + item_name2.toLowerCase() + " &awith " + s.getLine(3)));
           return;
        }[syntax][/syntax]

 

I'm not sure if this would help but could you possibly make an item stack or something, I know you are trying set a block but maybe you can do something with item stacks.

[Edit] Forget the idea , instead of the try stement do an if statement that checks if it's a sign then set the variable maybe that could fix it.

 

@Shaner_X
I think I found the problem. You're updating your BlockState incorrectly.
You are doing "e.getClickedBlock().getState().update();" insteaqd of "s.update()"
(near the bottom of the listener)

 

I tried s.update() too .-.

I guess I'll both update the jar on the test server and the libraries and see if it works.

 

Just a question, did you check if The event gets triggered? You may have no registered Your event handler in onEnable() ?

 

Everything apart from the sign works.

 

Did you use The correct imports?

 

Good question... May I ask you which is supposed to be the correct package for "Sign"?

 

I think you need The block import

 

This is my import:

Code:Java

import org.bukkit.block.Sign;

 

Code:Java

 
In that case try changing it to material