Solved Sign Changing Plugin always returns false

So whenever I try to run my command with my plugin with all of the arguments correct, all the plugin gives me in chat is the usage from plugin.yml. If anyone could help me, feel free. Remember that I just started mod/plugin development yesterday and I'm still learning.

Code:java

package com.macleisure.am; //my real package is my email address, so I changed it to this for privacy.
 
import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.block.BlockState;
import org.bukkit.block.Sign;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class AdamsCommands extends JavaPlugin {
 
    @Override
    public void onEnable(){
        getLogger().info("onEnable has been invoked");
    }
 
    @Override
    public void onDisable(){
        getLogger().info("onDisable has been invoked!");
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
 
        Player player = (Bukkit.getServer().getPlayer(sender.getName()));
        Block block = player.getTargetBlock(null, 200);
 
        if (args.length == 1) {
            if (cmd.getName().equalsIgnoreCase("changeline")) {
                if (sender instanceof Player == false) {
                    sender.sendMessage("This command can only be run by a player!");
                } else {
                    if (block.equals(Material.SIGN_POST)) {
                        BlockState state = block.getState();
                        Sign sign = (Sign)state;
 
                        sign.setLine(Integer.parseInt(args[0]), args[1]);
                        sign.update(true);
                    } else { return false; }
                }
            } else { return false; }
        } else { return false; }
        return true;
    }
    }
 

 

dingus007
Block is not equal to Material, use block.getType().equals(Material.SIGN_POST)
Also, there is Material.SIGN_WALL, too, maybe you want to check this as well.
And you can merge line 36 and 37 to Sign sign = (Sign)Block.getState();

Edit: And you should check that block is not null

 

And instead of using this:

Code:

Player player = (Bukkit.getServer().getPlayer(sender.getName()));

Just cast it like this:

Code:

Player player = (Player) sender;

 

Thanks, guys I will test out the changes when I get back to my computer..

 

Code:

  if (args.length == 1) {

You are using args[0] and [1], so you need to check for args.length == 2 here, as you have 2 arguments for this command.

Code:

Integer.parseInt(args[0])

This will throw a NumberFormatException, if the player entered no valid interger value as first argument.
So better use a try{} catch{} block to handle the exception.

Code:

Player player = (Player) sender;

This is fine. But before casting "sender" to "Player", check if sender actually is a Player,
by using

Code:

if (sender instanceof Player)
{
  // cast to Player here
}

Because "sender" could also be the console, which would cause an error here, if you cast it to Player.

You should "return true;" if the player entered a valid command. Even if the other checks fail. (like if he has not targeted a sign, but the command was correct)
If it was not valid, (wrong command, wrong parameters) "return false;".

It's actually called "Material.WALL_SIGN".

 

So I edited my code to most of your changes, but plugin.yml still kicks in by saying /changeline [line] [text] and the command doesn't run even though I'm looking at a sign and put in two arguments.

Code:java

package com.macleisure.am
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.block.BlockState;
import org.bukkit.block.Sign;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class AdamsCommands extends JavaPlugin {
 
@Override
public void onEnable(){
getLogger().info("onEnable has been invoked");
}
 
@Override 
public void onDisable(){
getLogger().info("onDisable has been invoked!");
}
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
 
// /changeline command
 
 
 
if (cmd.getName().equalsIgnoreCase("changeline")  & sender instanceof Player) {
Player player = (Player) sender;
Block block = player.getTargetBlock(null, 200);
if (args.length == 2 & block.equals(Material.WALL_SIGN)) {
BlockState state = block.getState();
Sign sign = (Sign)state;
 
sign.setLine(Integer.parseInt(args[0]), args[1]);
sign.update(true);
return true;
} else { sender.sendMessage(ChatColor.RED + "Command formatted wrong!"); return false;}
}
return true;
}
}

If anyone could help, please do!

 

Code:

if (args.length == 2 & block.equals(Material.WALL_SIGN))
 
if (cmd.getName().equalsIgnoreCase("changeline") & sender instanceof Player)

Use "&&". You accidently used "&" in both lines, which will do something different.