Setting total experience

Im assuming the total exp count is the total number of experience points that comes to both the level, and progress towards the next level.

Basically, im working a bit of code into my plugin, where if a player is killed by another player, instead of dropping the exp on the ground, it transfers the xp directly into the players total experience points.

Code:

killer.setTotalExperience(killer.getTotalExperience() + event.getDroppedExp() + event.getNewTotalExp());
event.setDroppedExp(0);
event.setNewTotalExp(0);

However, when this code is run, the killers experience is never updated. Nothing happens. I added debug to show their total exp before and after adding, and its showing that it did indeed add the experience, but its not actually changing the experience level.

Any ideas?

 

Try getting and setting the total xp? Example:

Code:java

public void addExp(Player p, int exp)
{
    p.setTotalExperience(p.getTotalExperience() + exp);
}

 

Thats what i did in the first line

 

CorrieKay sorry for not reading properly. Meanwhile, this seems to work:

Code:java

int total = p.getTotalExperience() + 5;
                    p.setTotalExperience(total);
                    p.setLevel(0);
                    p.setExp(0);
                    for(;total > p.getExpToLevel();)
                    {
                        total -= p.getExpToLevel();
                        p.setLevel(p.getLevel()+1);
                    }
                    float xp = (float)total / (float)p.getExpToLevel();
                    p.setExp(xp);

Everytime I execute this (I put it in a command with a fixed recieved amount '5') I get my xp

 

ah, okay, so you calculate the exp and level. Alright, ill do that. THanks

 

np

 

Exp is a bit weird. If you want you can use my util class I made for exp.

https://github.com/alkarinv/BattleArena/blob/master/src/mc/alk/arena/util/ExpUtil.java

 

Experience is not broken, setTotalExperience just does not work like you expect it to

 

Heh, never said it was broken, just a bit weird and it is, like you said setTotalExperience doesn't work like everyone expects it to.

 

alkarin btw, you know setting the total experience to 0 will break my method ;3?

 

Your method and my ExpUtil class are completely separate though. I was just putting it out there in case someone wanted a set of functions that deals with exp. Not trying to criticize your code or anything. I was just possibly saving people some time getting the exp methods to work correctly.

 

alkarin I just mean that I use getTotalExperience to set the levels, and you set that to 0 ;3

 

well we go about it different ways. You set the level and exp to 0 then give back levels. I set everything to 0, then give back the exp. The problem you are going to run into (unless bukkit finally fixed this (which I don't think they have)) is that p.getTotalExperience() doesn't give back the correct experience after a player has enchanted something. So if a player enchants, then uses that method, their experience has not reduced any (not sure exactly when it updates, but its not quick). This leads to people being able to dupe experience.

For some reason though, while bukkit doesnt update total experience, the level and exp to next level is updated immediately after enchanting. So the correct way to get total experience is based off of getting the experience based on their current level, and exp to next level.

Hence exp is weird oO

 

True dat. Btw note that Minecraft handles the xp ;3 (so it is something Minecraft should fix, as getTotalExperience directly returns the EntityPlayer's totalExp)