Solved Setting punch damage.

I'm looking to set the punch damage of a player to 20 if they are in a certain List. Now, I already have the List stuff set up, I just need the punch damage.
On IRC people were a big help, that was what helped me find out the correct event to use, and how to get my List for use in my Listener, even though it is in my Main. Anyhow, here is my code and if someone could tell me how to get this working, that'd be awesome!

Code:java

        @EventHandler
        public void onEntityDamageByEntity(EntityDamageByEntityEvent event) {
            if (event.getEntity() instanceof LivingEntity){
        int health = ((Damageable) event.getEntity()).getHealth();
            if(event.getDamager() instanceof Player){
                  if(supermen.contains(event.getDamager())){
                 ((Damageable) event.getEntity()).setHealth(health-20);
               }
                }
                }
        }

 

First of all, casting an Entity to an EntityDamageEvent will most definitely result in an error. If you wanna set the damage of the event, just do event.setDamage(20); Simple as that.

You probably want to check if the damager holds nothing before setting the damage:

Code:java

@EventHandler
public void onEntityDamageByEntity(EntityDamageByEntityEvent event) {
    if(supermen.contains(event.getDamager())){
        if (!(event.getDamager() instanceof Player)) {
            return;
        }
        Player damager = (Player) event.getDamager();
        if (damager.getItemInHand() == null) {
            event.setDamage(20);
        }
    }
}

 

Rocoty
Trying this, however instead of checking to make sure they had Item in hand, I just did else because I guess, looking back on it, I did say the damage of a punch, when what I mean't was just the damage of an attack in general. I'll get back to you with whether this works or not.

 

yeah, in that case you won't need the instanceof check, nor the cast....

 

Setting the damage over their current health will throw errors and not even give them any damage.

 

Rocoty Jake0oo0
Yeah... Not working
Code:

Code:java

 @EventHandler
public void onEntityDamageByEntity(EntityDamageByEntityEvent event) {
if(supermen.contains(event.getDamager())){
event.setDamage(20);
}
}

Know that I'm not supposed to bump yet, but it's moved way down and I'm leaving for the night and would love to see a response tomorrow.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

What's your "supermen" list? Your code would only work if it is List<Entity>.

 

chasechocolate
It is an
ArrayList<String>
Does that work...?

 

I'd use a List<Entity> like chase said...

 

No. If you are saving players, it's generally best to use a List<String> and save the player's name. Then, on your event, check if it is a player, then cast, and then check if the list contains the player's name.

 

HTML:

@EventHandler
    public void onEntityDamageByEntity(EntityDamageByEntityEvent event) {
    List<String> supermen = new ArrayList<String>();
    if(event.getDamager() instanceof Player){
    Player player = (Player) event.getDamager();
      if(supermen.contains(event.getDamager())){
    if(player.getHealth() >= 20){
    event.setDamage(20);
    }else{
    player.setHealth(0);
    }
    }
    }
    }

That should work...

 

Rockon999 except you would want the supermen variable outside of the event method otherwise you will be creating a new empty list instance every time the event is called.

 

Rockon999
Wait.... That would make it so that if the person has less than 20 health, you make it so they have none?
they = attacker
Should it be
event.getEntity().setHealth(0);
?

 

C0nsole hey you could always make it so that it gets the damager, and if they're item in hand = null, then get the damaged entity, and if it's an instanceof player, you could set their health to health - punchDamage

 

But I want it to DEAL 20 damage, not TAKE a certain amount of health, as in my plugin there are people that have different Max healths.

 

C0nsole Exactly. My idea would work for that. You have to do something like:

Code:

int health = event.getDamagedEntity().getHealth();
ItemStack dmgrhold = event.getDamager().getInventory().getItemInHand();
 
if(dmgrhold.equals(null) && event.getDamager().isPartOfSomeSupermanArray)
{
  event.getDamagedEntity().setHealth(health-20);
}

It simply gets the damaged entity's health then subtracts the amount of damage set (in this case, 20) so it sets their health to their current health minus the damage done.

 

Zach_1919
This is my code:

Code:java

        @EventHandler
        public void onEntityDamageByEntity(EntityDamageByEntityEvent event) {
            if (event.getEntity() instanceof LivingEntity){
        int health = ((Damageable) event.getEntity()).getHealth();
            if(event.getDamager() instanceof Player){
                  if(supermen.contains(event.getDamager())){
                 ((Damageable) event.getEntity()).setHealth(health-20);
               }
                }
                }
        }

(It made me add the casts) and it doesn't work =/

Got this solved on IRC. Thanks everyone!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.