[SEC/FUN] Factions 2.0.0 - Guilds, War and user-controlled antigrief [BukkitDev]

Discussion in 'Archived: Plugin Releases' started by MassiveCraft, May 29, 2011.

  1. Offline

    Brettflan

    No, shouldn't be caused by server overload. By the way /f reload will reload all data from disk, so changes to factions, new claims, and so forth can be lost if they hadn't yet been saved. You should normally use /f save shortly before /f reload to reduce the likelihood of that happening.
     
  2. Offline

    embty

    Ok ill try that, Thank you for your great help. :)
     
  3. Offline

    MufinMcFlufin

    Nicely done with this plugin, Brettflan. A friend recommended it to me when I told him I wanted a more team-based PvP setting in my server, and this suites us well. We had an issue, in that any time someone tried to talk in global chat, it returned a Sever warning. Private, Faction based chat worked just fine, just not global. However, I'm pretty certain that was from using a different name display system than <{player_name}> {message} (our system is [{customized_group_symbol}]{player_name}: {message}) so I turned off the chat tag thing, and it works perfectly fine now.

    If you care to look at what warnings exactly it returned us every time someone spoke, here it is:
    Code:
    2011-06-01 16:48:14 [SEVERE] Could not pass event PLAYER_CHAT to Factions
    java.util.UnknownFormatConversionException: Conversion = '§'
        at java.util.Formatter.checkText(Unknown Source)
        at java.util.Formatter.parse(Unknown Source)
        at java.util.Formatter.format(Unknown Source)
        at java.util.Formatter.format(Unknown Source)
        at java.lang.String.format(Unknown Source)
        at org.mcteam.factions.listeners.FactionsPlayerListener.onPlayerChat(FactionsPlayerListener.java:88)
        at org.bukkit.plugin.java.JavaPluginLoader$6.execute(JavaPluginLoader.java:262)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:59)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:289)
        at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:651)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:639)
        at net.minecraft.server.Packet3Chat.a(Packet3Chat.java:32)
        at net.minecraft.server.NetworkManager.a(NetworkManager.java:196)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:75)
        at net.minecraft.server.NetworkListenThread.a(SourceFile:100)
        at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:372)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:287)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:394)
    
    After that report, I had one question and one suggestion. My question is about enemy factions raiding each other. I'm not sure if you already had thought about this, if this was intended, or if this was planned, but I've found that should faction A raid faction B, then the people of faction B could simple box themselves in. Because the people of A are in B's territory, they can't edit the areas, so everyone in faction A is safe while they remain caged. Was this planned, intended, or could you give me your thoughts about this in general?

    Lastly, my suggestion is that there be an option of some sort that you could set, so that way an admin of the entire server could have infinite power, and control limitless areas without worrying about people claiming it for themselves when power levels decrease, or perhaps simply instead the ability to set chunks as "Unclaimable" with options to be able to build in the area, or not. My original reasoning in this, I found could be solved by other means, but I still believe this could be useful for other players in some ways. I'd appreciate it if you would consider this.

    Thanks.
     
  4. Offline

    Brettflan

    What does this part of your conf.json file look like? Based on the error it might have been modified incorrectly.
    Code:
      "chatTagFormat": "%s§f ",
      "factionChatFormat": "%s§f %s",

    That entails a potentially rather long discussion; sorry, but I just don't have time for it.

    That's a big part of the purpose of safe zones and war zones.
     
  5. Offline

    MufinMcFlufin

    I left it as default, no changes made. Should I have?

    Copied and pasted:
    Code:
      "chatTagFormat": "%s§f ",
      "factionChatFormat": "%s§f %s",
    
    Ah well, no worries then. I was just talking with my friend about it, and how it seemed a sort of, two opponents each with an invincible shield, sort of situation.


    Well, with the config, I imagine that you could make certain areas exactly as I was mentioning, (A WarZone with power decrease) but by doing that, I no longer have access to making WarZones. I know I can't make you do it, but I imagined that it would be easy enough to implement anyways. Oh well.
     
  6. Offline

    Brettflan

    In that case, perhaps some other plugin is messing with the chat event's format (via event.setFormat()). Somehow it's ending up with "%§" in there. What other plugins are you using which might do something to chat messages?

    Well, again, having areas claimable by admins so that factions can't claim them is a big part of safe zones, and almost the entire reason for war zones (so people would have an admin claimed area that wasn't made "safe").
     
  7. Offline

    embty

    Ok heres the error you need I think

    Code:
    Factions: v1.2.0] Board cleaner removed 443 from [world,-91,-74]
    Factions: v1.2.0] Board cleaner removed 443 from [world,-91,-73]
    Factions: v1.2.0] Board cleaner removed 443 from [world,-91,-75]
    Factions: v1.2.0] Board cleaner removed 443 from [world,-89,-74]
    Factions: v1.2.0] Board cleaner removed 443 from [world,-89,-73]
    Factions: v1.2.0] Board cleaner removed 443 from [world,-89,-75]
    Factions: v1.2.0] Board cleaner removed 443 from [world,-90,-74]
    Factions: v1.2.0] Board cleaner removed 443 from [world,-90,-75]
    Factions: v1.2.0] Board cleaner removed 443 from [world,-90,-73]
    Factions: v1.2.0] Reset faction data (invalid faction) for player Bennyss
    Factions: v1.2.0] Reset faction data (invalid faction) for player chrrezl
    those guys factions were removed while they are online.
     
  8. Offline

    Bjourk

    Thanks so much for continuing this plugin!

    What are the chances of giving admin the ability to claim areas for a faction without joining that faction? Like the new WarZone claiming but "/f claimfor <FactionName>" or "/f adminclaim <FactionName>". That would make setup a lot easier!
     
  9. Offline

    Hunt800

    Well, we've had some issues with a certain faction growing out of control. I don't want to limit Player Freedom, but I also want to make it possible for other factions to grow to a point where they actually have a chance of not being squashed by the big guys. To fix this issue, I've got a few suggestions:
    • Allow Faction "ranks" - Basically, a faction at each rank will only be allowed a certain number of users, since I understand you do not want iConomy integration, you could allow Admins to rank up a faction through use of a command. Future expansion of this idea could include perks for factions as they rank up.
    • Limit Wars - What if you made it so factions couldn't war on another faction that was more than 60 power below them. If you did this, then the smaller factions would be protected until they had built up their strength. Note, smaller factions can ALWAYS war on bigger factions, and if a smaller faction wars a bigger one, the bigger one will be able to attack back.
    • "Dynamic" Attack Boosts, based on a factions size and the location of a battle - Because we use MCMMO, it just so happens that the big, overpowering faction is full of high ranked players capable of punching with the strength of a diamond sword. Other players can't. A possible work around may be to give factions with lower numbers a (toggleable) larger boost while on their own territory and in the wild. Sort of like a "David Vs. Golaith" perk. This would help to even out fights and possibly aid the little factions in retaliation.
    • Limit building in claims - One issue I see is that if a faction claims the block where another faction's town hall is, they can completely grief it in a moment. What if a faction couldn't build in a claim unless EVERY factions block around it (all 8) were either part of the wild, or part of their own faction. This would make it so a faction would have to claim all of the blocks around the town square (or the town's gold vault) before they could loot and destroy the place.
    • Height restrictions - This doesn't have to really do with my issue so much as it has to do with a personal wish on my part. Perhaps you could limit the minimum height of a faction claim, in order to leave much of the underground caves free for mining for all people.
     
  10. Offline

    Magesblood

    Whats the best way to reduce spam in safezone's when players are hitting each other non stop.?
     
  11. Offline

    ch96li

    Could you implement subfactions? Because while huge factions are fun, sometimes faction management becomes too much of a chore, also subfactions would allow specialization especially combined with mcmmo.
     
  12. Offline

    Xentonic

    but does it work with craftbukkit 818?
     
  13. Offline

    Brettflan

    Possibilities...
    1. The faction admin disbanded the faction.
    2. Maybe you messed around with /f reload and some changed faction data which hadn't been saved yet was lost.
    Other than that, a quick scan through the code for instances where factions can be disbanded/deleted revealed no potential bugs that I could see.

    Maybe.

    @Hunt800 I don't have any real plans to add major new features at this point. The source is available on GitHub for forking and I will accept most pull requests (assuming the code is at least passable and adds something potentially useful).

    Tell the idiots to stop hitting each other there, since it serves no purpose in a safe zone? Ban them for being retards if they continue anyway? ;)

    Not planning to, sorry. Factions can of course ally with each other.

    If the thread title indicates a version number at the end, that means it definitely works for that version. Otherwise, it just probably works for it. I assume you can read that [818] up there.
     
  14. Offline

    ledhead900

    Yea but history shows a lot of people who play MC are not very good with remembering to do things safely or are just not awear much no offence but a lot of them are bit newb but I mean that in best of ways that I think the /f save and /f reload should be combined to just /f reload

    so that it forces a save before the reload thus ensures its saved.
     
  15. Offline

    Brettflan

    If it saved right before reloading, it would simply overwrite any changes you just made and then load the same thing it just saved back up. Some way of specifying just one of the data files to reload instead of reloading all of them would be useful though, I agree.
     
  16. Offline

    darkwarriors

    @Brettflan
    important is that if u add this command, add also some restrictions beacuse if a faction set itself nopvp everytime "she" want, could be a catastrofic event :D

    i found a bug

    if a player left a factions all his old member cant hit him and viceversa!

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 16, 2016
  17. Offline

    MufinMcFlufin

    As far as chat related plugins, I only use EssentialsChat and Prefixer, then have Prefixes set per group in Permissions.


    I see your point.
     
  18. Offline

    DrBowe

    Ok, a few questions regarding faction land claiming:

    1) Is it possible to place a minimum amount of people required to start a faction?
    2) Is it possible to set it so that only factions can claim land, and not one single person?
    3) Is it possible to also hook into iConomy, so that these factions not only have to meet the minimum requirements, but also pay for each piece of land they buy? You could always ask for assistance from the iCoLand developer.
    4) Is it possible to configure the size of a 'land claim'. Again, I had something along the lines of what iCoLand is doing, but compatible with factions.
    5) When a faction loses power to the point that land becomes unprotected, is there some sort of server-wide broadcast? If not, I'd like to suggest this, as it would tell enemies that its the time to strike, and also tell allies that its the time to help.

    Sorry about all the questions, just curious if this plug-in would suit my server or not.
     
  19. Offline

    Magesblood

    Do you think you could just add a way to disable the message :p
     
  20. Offline

    duhfux

    Is it possible to or to have added to the plugin:

    An auto-claim on/off command, where walking onto an unclaimed chunk claims it. Also one for setting safe zones.

    Allowing admins access to doors/chests inside of a faction's claimed land.
    Sorry, am hungover. My brain is a puddle.
    Cheers.
     
  21. Offline

    killerbeez

    Anyway to get an option to turn off faction zones protecting chests?
     
  22. Offline

    MeinerHosen

    Thanks for taking this plugin over, I've been looking forward to seeing it updated for my PvP map.

    Keep up the good work on this and worldborder :D
     
  23. Offline

    Brettflan

    I've scanned through the code related to the /f leave command (which explicitly sets the player's faction to 0, "none") and the code which checks whether one player can hurt another (which compares factions of the two players to see if they match or are allied factions), and I don't see how that can happen.

    I use EssentialsChat and don't have any problems with it. You might experiment with disabling Prefixer to see if that gets rid of the error.

    The message is only shown to the person hitting and the person being hit. But... sure, I'll at least disable it on the person being hit. That way the only person potentially annoyed with those repeated messages is the idiot repeatedly trying to hit someone else in a safe zone.

    Remove it from "territoryProtectedMaterials" in the conf.json file.

    Sorry, but I'm not planning to add any of these. I just don't have time or incentive for them. Otherwise, the source is of course available, and I'm happy to include features coded in by others.
     
  24. Offline

    GmK

    @Brettflan

    Thank so much, so far working splendid here!

    Could you maybe compile the recent commits into a pre-release jar, as I would like to test the HeroChat 'Integration' methods ;)

    Thanks!
     
  25. Offline

    Brettflan

    I should be releasing 1.2.1 later today.

    A reminder, though, any plugins that limit the number of chat recipients (like local chat, or channel chat) will keep the chat message from reaching Factions at all, since those implementations necessarily cancel the chat event and send out individual messages which can't be intercepted. Thus, no faction tags in those messages. Only global chat messages will get faction tags.
    There's nothing I can do about that.
     
  26. Offline

    Magesblood

    Thank you :p
     
  27. Offline

    duhfux

    There's already the map that triggers this in the plugin. It would be extremely useful to be able to set more than one square of zone at a time. Have typed [t] f safe [enter] about 40 times now.
     
  28. Offline

    KinaNeko

    For some reason I can't seem to change any of the settings in the config file, every time I open and change a setting like max power and save it...no matter what I do it always seems to drop back to the default max power of 10. Is it meant to do this or do I need some specific way of altering the config file?

    Also as well, would it be possible to maybe allow an in-game saveable command of the faction admin to allow ALLIES and a separate one to allow NEUTRALS to use your doors both wood and iron (and maybe possibly other blacklisted items, mainly doors though)? This way you can allow them in and out of their own free will without having to worry about putting a pressure plate down to also allow unwanted guests in.
     
  29. Offline

    Brettflan

    Sorry, but it's more work than you'd apparently think.

    If you edit the file while the server is running, your changes will be ignored and eventually overwritten. Shut down the server before editing it, or use the /f lock, /f save, and /f reload commands.

    Sorry, not currently planning to add such a feature (lack of time and incentive).

    Released 1.2.1.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 16, 2016
  30. Offline

    geloum

    First of all, I want to thank you from the bottom of my heart for updating this.

    users can't destroy in the safe Area but they can build.. Wich is annoying.
    Running 818 with 121 of your plugin.

    Nodes used for users :

     

Share This Page