Scoreboard Problems

I have never found a use to using Scoreboards until now. I am trying to create a Top 5 Kills scoreboard.

Here's my code:

Code:

    public ScoreboardManager m = Bukkit.getServer().getScoreboardManager();   
    public Scoreboard board = m.getNewScoreboard();
    public Objective o = board.registerNewObjective("topkills", "dummy");
   
   
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        o.setDisplayName(ChatColor.GREEN + "Top 5 Kills");
        o.setDisplaySlot(DisplaySlot.SIDEBAR);
        e.getPlayer().setScoreboard(board);
    }
   
    @EventHandler
    public void onKill(PlayerDeathEvent e) {
        if(e.getEntity().getKiller() instanceof Player && e.getEntity() instanceof Player) {
            Score s = o.getScore(e.getEntity().getKiller());
            s.setScore(s.getScore() + 1);
        }
    }

Events are registered, Class implements Listener, but no Scoreboard shows up at all.

Any reasons why?

 

Score s = o.getScore(e.getEntity().getKiller());
Change To:
Score s = o.getScore(Bukkit.getOfflinePlayer(e.getEntity().getKiller()); - Didn't test this

 

Didn't work I want it to show right when you join, anyways.

 

baaaaaaaad!!11! cache them in a list and run a comparator to sort them. then display them on the scoreboard

 

Bump

 

Try this I didn't test it dow :\

Code:java

 
@Override
public void onEnable(){
makeScoreboared();
PluginManager pm = Bukkit.getServer().getPluginManager();
pm.registerEvents(this, this);
}
 
private static ScoreboardManager m = Bukkit.getServer().getScoreboardManager();
private static Scoreboard sb = m.getNewScoreboard();
private static Objective o = sb.registerNewObjective("topKills", "dummy");
 
public static void makeScoreboared(){
o.setDisplaySlot(DisplaySlot.SIDEBAR);
o.setDisplayName("§aTop 5 Kills");
 
Score score = o.getScore("No Killer");
score.setScore(0);
 
}
 
public void onJoinEvent(PlayerJoinEvent e){
Player p = e.getPlayer();
p.setScoreboard(sb);
}
 
public void onDeathEvent(PlayerDeathEvent e){
Player p = e.getEntity();
Player k = e.getEntity().getKiller();
 
Score score = o.getScore(k);
score.setScore(0);
 
}