Scoreboard help?

how can i get it so when some one kills some one it will say 1 on player kills and so on?

Code:java

        //Scoreboard
        this.getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
            public void run() {
                  Player[] players = main.this.getServer().getOnlinePlayers();
                  for (Player p : players) {
                      ScoreboardManager sbm = Bukkit.getScoreboardManager();
                    Scoreboard b = sbm.getNewScoreboard();
                    Objective obj = b.registerNewObjective("kills", "dummy");
                    obj.setDisplaySlot(DisplaySlot.SIDEBAR);
                    obj.setDisplayName("MCRust");
                    Score pkills = obj.getScore(Bukkit.getOfflinePlayer(ChatColor.GREEN + "Murders"));
                    pkills.setScore(0);
                    Score zkills = obj.getScore(Bukkit.getOfflinePlayer(ChatColor.GREEN + "Zombie Killed"));
                    zkills.setScore(0);
                    p.setScoreboard(b);
                }
            }
        }, 20, 20);

 

Wantsome909
Maybe use a hashset, and make a onEntityDeathEvent and add 1 to the hashset everytime someone dies, and when you are creating your score bored just retrieve the hashset

 

and wat a hashset?
mydeblob

 

Wantsome909
To code efficiently in bukkit you must have a good knowledge of java. A hash set is similar to an array list but can't hold 2 of the same data sets (correct me if I'm wrong). You would use the code like so.
Creating the hashset (This would go where you declare all your variables in the main class, or if you don't want to use getter and setter's whatever class your using the hashset in):

Code:java

HashSet<String> name = new HashSet<String>();

The "name" in this code is whatever you want your hashset to be called.
You would then make a player death event:

Code:java

@EventHandler
public void onPlayerDeath(PlayerDeathEvent event){
Player player = (Player) event.getEntity();
name.add(player.getName());
}

Again, in this code the "name" you would replace with whatever you named your hashset.
Then when you are adding this to the score board you would replace this:

Code:java

pkills.setScore(0);

With this

Code:java

pkills.setScore(name);

And again, you would replace "name" with the name of your hashset.

 

mydeblob so i cant have a sperate class with events and runnables? they have to be in the same class

mydeblob i mean like this

main class:

Code:java

 //Scoreboard
this.getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
public void run() {
Player[] players = main.this.getServer().getOnlinePlayers();
for (Player p : players) {
ScoreboardManager sbm = Bukkit.getScoreboardManager();
Scoreboard b = sbm.getNewScoreboard();
Objective obj = b.registerNewObjective("kills", "dummy");
obj.setDisplaySlot(DisplaySlot.SIDEBAR);
obj.setDisplayName("MCRust");
Score pkills = obj.getScore(Bukkit.getOfflinePlayer(ChatColor.GREEN + "Murders"));
pkills.setScore(kills);
Score zkills = obj.getScore(Bukkit.getOfflinePlayer(ChatColor.GREEN + "Zombie Killed"));
zkills.setScore(0);
p.setScoreboard(b);
}
}
}, 20, 20);

listener class:

Code:java

 
HashSet<String> kills = new HashSet<String>();
 
@EventHandler
public void onPlayerDeath(PlayerDeathEvent event){
Player player = (Player) event.getEntity();
kills.add(player.getName());
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Wantsome909
Yes, but remember to add your event in your onenable. And for the scoreboard you probably will have to use a getter method to access the hashset