Right click sign to run command

Hey guys,

I'm trying to make it when you right click a sign it runs the command /feather however it is not working. This is my code. Any help is much appreciated!

Code:java

 
import java.util.logging.Logger;
 
import org.bukkit.block.Sign;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.block.SignChangeEvent;
import org.bukkit.event.player.PlayerInteractEvent;
 
public class SignCommand implements Listener {
  public final Logger logger = Logger.getLogger("Minecraft");
 
 
  @EventHandler
  public void onSignChange(SignChangeEvent e) {
          if (e.getLine(0).equalsIgnoreCase("[Feather]")) {
                  e.setLine(0, "§3=========================");
                  e.setLine(1, "§3Click here to");
                  e.setLine(2, "§3get a feather!");
                  e.setLine(3, "§3=========================");
          }
  }
 
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
            if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK));
            if (e.getClickedBlock().getState() instanceof Sign) {
                    Sign s = (Sign) e.getClickedBlock().getState();
                    if (s.getLine(0).equalsIgnoreCase("[Feather]")){
                            e.getPlayer().chat("feather");
                    }
            }
    }
}

Thanks,
Glass

 

Glass_Eater84

Use Bukkit#dispatchCommand(CommandSender, String);

Also, don't use Logger.getLogger("Minecraft");, use plugin.getLogger();

 

Dragonphase Thanks, I tried but had no success. This is my updated code.
SignCommad class:

Code:java

public class SignCommand implements Listener {
 
 
 
  @EventHandler
  public void onSignChange(SignChangeEvent e) {
          if (e.getLine(0).equalsIgnoreCase("[Feather]")) {
                  e.setLine(0, "§3=========================");
                  e.setLine(1, "§3Click here to");
                  e.setLine(2, "§3get a feather!");
                  e.setLine(3, "§3=========================");
          }
  }
 
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
            if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK));
            if (e.getClickedBlock().getState() instanceof Sign) {
                    Sign s = (Sign) e.getClickedBlock().getState();
                    if (s.getLine(0).equalsIgnoreCase("[Feather]")){
                            Bukkit.dispatchCommand(e.getPlayer(), "feather");
                    }
            }
    }
}

And heres my registered events: (Main Class)

Code:java

public class Main extends JavaPlugin
{
  public void onDisable()
  {
    System.out.println(Messages.shoutdown);
  }
  public final Logger plugin = Logger.getLogger("Minecraft");
  public void onEnable()
  {
    Bukkit.getServer().getPluginManager().registerEvents(new SignCommand(), this);

 

Glass_Eater84

When you create a sign with "[Feather]" as the first line, you're replacing it in your onSignChange EventHandler. So your conditional check on line 20 will always return false.

 

Dragonphase I put this check on line 20 because the first line(Feather) wasn't getting replaced. However, neither the command function nor the replacement is working, this is why I though there might be a bug in the registerEvents

 

timtower How would I do that, specifically?

 

timtower Im not getting any errors nor is it showing up...

 

There are more than one type of signs. Add multiple checks for these.

Code:java

Material.SIGN
Material.WALL_SIGN
Material.SIGN_POST

are the ones I believe. Not 100% sure.

 

timtower

Code:java

 
public class SignCommand implements Listener {
  public final Logger logger = Logger.getLogger("Minecraft");
 
 
  @EventHandler
  public void onSignChange(SignChangeEvent e) {
          if (e.getLine(0).equalsIgnoreCase("[Feather]")) {
                  e.setLine(0, "§3=========================");
                  e.setLine(1, "§3Click here to");
                  e.setLine(2, "§3get a feather!");
                  e.setLine(3, "§3=========================");
          }
  }
 
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
            if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
            if (e.getClickedBlock().getState() instanceof Sign) {
                    Sign s = (Sign) e.getClickedBlock().getState();
                    if (s.getLine(0).equalsIgnoreCase("[Feather]")){
                            e.getPlayer().chat("feather");
 
                    }
            }
    }
}

 

timtower wrong code I undid what I did because it didnt work updated
here it is:

Code:java

 
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
            if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
            if (e.getClickedBlock().getState() instanceof Sign) {
                    Sign s = (Sign) e.getClickedBlock().getState();
                    if (s.getLine(0).equalsIgnoreCase("[Feather]")){
                            e.getPlayer().chat("feather");
                            System.out.println(Messages.debug);
                    }
 
                    }
            }
    }
 

 

Glass_Eater84
I'm just curious of what you're trying to do.
Your SignChangeEvent changes signs with line[0] "[Feather]" to a random panel.
Your PlayerInteractEvent triggers when a player interacts with a sign that has "[Feather]" in line[0] but that'll never occur due to your SignChangeEvent.

 

stormneo7 Well, what I was trying to do is make it so whenever I type [Feather] on the sign, and someone clicks it, it will give run the command /feather

 

Glass_Eater84 I'm going to update your code to something that I would probably use. I hope this helps in some way. (As per usual this is NOT tested.)
SignCommand

Code:java

public class SignCommand implements Listener {
 
Main m;
public SignCommand(Main instance)
{
m= instance;
}
 
@EventHandler
public void onSignChange(SignChangeEvent e) {
if (e.getLine(0).equalsIgnoreCase("[Feather]")) {
e.setLine(0, "§3=========================");
e.setLine(1, "§3Click here to");
e.setLine(2, "§3get a feather!");
e.setLine(3, "§3=========================");
}
}
 
@EventHandler
public void onPlayerInteract(PlayerInteractEvent e) {
if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK));
if (e.getClickedBlock().getType() == Material.SIGN || e.getClickedBlock().getType() == Material.SIGN_POST)
Sign s = (Sign) e.getClickedBlock().getState();
if (s.getLine(0).equalsIgnoreCase("[Feather]")){
Bukkit.dispatchCommand(e.getPlayer(), "feather");
}
}
}
}

And for your Main class, the following

Code:java

public class Main extends JavaPlugin
{
public void onDisable()
{
System.out.println(Messages.shoutdown);
}
public final Logger plugin = Logger.getLogger("Minecraft");
public void onEnable()
{
Bukkit.getServer().getPluginManager().registerEvents(new SignCommand(this), this); // This is what i've changed.
}
} // end of Class

 

I know how making multiple classes show a sign of organization but in this case, it's just two listeners. Just do it in the main class lol...

Also, wtf does this do?

Code:java

if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK));

I also don't get this insanity... The first event PREVENTS signs to BECOME [Feather] so the 2nd event will NEVER trigger.

 

I agree, you could just put it in one class, but in this case he's using two classes so we have to work with them two classes.

and for

Code:java

if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK));

[/quote] I am with you on that one, I just left that in, I guess he could remove it to see if it works. (OR TRY LEFT CLICKING!!!)

 

Xyplo Thanks. However, I am still getting an error here:

Code:java

Sign s = (Sign) e.getClickedBlock().getState();
                if (s.getLine(0).equalsIgnoreCase("[Feather]")){
                    Bukkit.dispatchCommand(e.getPlayer(), "feather");
}

"Sign can not be resolved as a type"
Also, I removed

Code:java

if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK));