Solved Rewriting a string in a file

Hey there,

I'm trying to remove a string from a line, meaning if I have

Code:

ArenaNames: dev | bukkit

and I enter the command /delete bukkit I get the new string:

Code:

ArenaNames: dev

I have this code:

Show Spoiler Hide Spoiler

Code:java

    public void CFGRemoveArena(String GameArena)
    {
        String ArenaNames = plugin.SimonCFGM.getArenaConfig().getString("ArenaNames");
        String ArenaLocs = plugin.SimonCFGM.getArenaConfig().getString("ArenaLocations");
        String ArenaTypes = plugin.SimonCFGM.getArenaConfig().getString("ArenaTypes");
        String RelatedArenas = plugin.SimonCFGM.getArenaConfig().getString("RelatedArena");
 
        if(ArenaNames == null || ArenaLocs == null || ArenaTypes == null || RelatedArenas == null)
        {
            plugin.SimonLog.logWarning("Attempted to delete an arena from an empty cfg! Canceled!");
        }
        else
        {
            String[] Names = ArenaNames.split(" | ");
            String[] Locs = ArenaLocs.split(" | ");
            String[] Types = ArenaTypes.split(" | ");
            String[] Relateds = RelatedArenas.split(" | ");
 
            int id = 0;
            int correctid = 0;
            while(id < Names.length)
            {   
                if(!ArenaNames.contains(GameArena))
                {
                    plugin.SimonLog.logWarning("Attempted to delete an non-existing arena! Canceled!");
                    return;
                }
 
                if(Names[id].contains(GameArena))
                {   
                    correctid = id+2;
                    break;
                }
 
                id++;
            }
 
            id = -1;
            while(id < correctid)
            {       
                try
                {
                    if(correctid == 2 && id == -1 && Names.length == 1)
                    {
                        plugin.SimonCFGM.getArenaConfig().set("ArenaNames", null);
                        plugin.SimonCFGM.getArenaConfig().set("ArenaLocations", null);
                        plugin.SimonCFGM.getArenaConfig().set("ArenaTypes", null);
                        plugin.SimonCFGM.getArenaConfig().set("RelatedArena", null);
 
                        File signFile = new File(plugin.getDataFolder(), "SavedArenas.yml");
                        signFile.delete();
 
                        plugin.SimonCFGM.saveDefaultArenaConfig();
                        plugin.SimonCFGM.reloadArenaConfig();
 
                        break;
                    }
 
                    if(id == correctid-1)
                    {                   
                        String NewArenaNames = ArenaNames.replaceFirst(Names[correctid], "DELETED");
                        String NewArenaLocs = ArenaLocs.replaceFirst(Locs[correctid], "DELETED");
                        String NewRelatedArenas = RelatedArenas.replaceFirst(Relateds[correctid], "DELETED");
 
                        plugin.SimonCFGM.getArenaConfig().set("ArenaNames", NewArenaNames);
                        plugin.SimonCFGM.getArenaConfig().set("ArenaLocations", NewArenaLocs);
                        plugin.SimonCFGM.getArenaConfig().set("RelatedArena", NewRelatedArenas);
 
                        plugin.SimonLog.logWarning("Finished, found the skip place and made it 'DELETED'");
 
                        id++;
                        break;
                    }
 
                    if(id == -1)
                    {
                        id++;
                        continue;
                    }
 
                    id++;
                }
                catch (IndexOutOfBoundsException ex )
                {
                    break;
                }
            }
 
            plugin.SimonCFGM.saveArenaConfig();
            plugin.SimonCFGM.reloadArenaConfig();
 
            plugin.SimonCFGM.CFGLoadGameArenas();
 
            plugin.SimonLog.logInfo("Deleting process finished for arena: " + GameArena);
        }
    }

http://pastebin.com/SgqLgxGh

and this is the config I am trying to rewrite:

Show Spoiler Hide Spoiler

Code:

# Default Arena Configuration for 'SimonSays' - Eden.Campo
 
ArenaNames: dev | bukkit
ArenaLocations: world,107,86,192 | world,107,86,191
ArenaTypes: 0 | 0
RelatedArena: test1 | test2

CorrectID is the index of the string I'm trying to delete in the file.

I tried to hardcode the locations but I doesn't seem to work, I can't delete anything without everything getting messed up.

Any ideas?

Thanks, Eden.

 

Are you using Bukkits YML API? You should use List<String>/List<Integer> to store these, meaning your config would look like this:

Code:

ArenaNames:
  - dev
  - bukkit
ArenaLocations:
  - world,107,86,192
  - world,107,86,191
ArenaTypes:
- 0
- 0
RelatedArena:
- test1
- test2

Then you can use List operations to remove and add items to them, and set them to the config using getConfig().set("ArenaNames", list);

 

Chinwe

That will mess up these classes, https://github.com/EdenCampo/SimonSays/tree/master/src/net/edencampo/simonsays/Dataloaders because they are all built on the <Section> x | y | z syntax :\

 

EdenCampo
In that case, when you use .split(" | "), you use StringBuilder to build the string again using this method:

Code:

    public static String removeFromList(String list, String toRemove)
    {
        String[] split = list.split(" | ");
        StringBuilder sb = new StringBuilder();
 
        for (String s : split)
        {
            if (!s.equals("|") && !s.equals(toRemove))
                sb.append(s + " | ");
        }
 
        return sb.toString().contains("|") ? sb.toString().substring(0, sb.lastIndexOf(" | ")) : sb.toString();
    }

 

Chinwe

Thanks again, made it fit into the cfg and if GameArena equals "bukkit" it deletes everything but "another"

Show Spoiler Hide Spoiler

Code:java

 String ArenaNames = plugin.SimonCFGM.getArenaConfig().getString("ArenaNames");
 
String toRemove = GameArena;
 
String[] Names = ArenaNames.split(" | ");
StringBuilder sb = new StringBuilder();
 
for (String s : Names)
{
if (!s.equals("|") && !s.equals(toRemove))
{
sb.append(s + (s.equals(Names[Names.length - 1]) ? "" : " | "));
plugin.SimonCFGM.getArenaConfig().set("ArenaNames", s);
}
}
 
plugin.SimonCFGM.saveArenaConfig();
plugin.SimonCFGM.reloadArenaConfig();
 
plugin.SimonCFGM.CFGLoadGameArenas();
 
plugin.SimonLog.logInfo("Deleting process finished for arena: " + GameArena);

Code:

# Default Arena Configuration for 'SimonSays' - Eden.Campo
 
ArenaNames: dev | bukkit | another
ArenaLocations: world,107,86,192 | world,107,86,191 | world,107,86,191
ArenaTypes: 0 | 0 | 0
RelatedArena: odf | asd | dasd

turns into:

Code:

# Default Arena Configuration for 'SimonSays' - Eden.Campo
ArenaNames: another
ArenaLocations: world,107,86,192 | world,107,86,191 | world,107,86,191
ArenaTypes: 0 | 0 | 0
RelatedArena: odf | asd | dasd

 

You need to move line 13 out of the for loop, and set ArenaNames to sb.toString() instead

I changed it to its own method, now you can just change it to plugin.SimonCFGM.getArenaConfig().set("ArenaNames", removeFromList(Names, GameArena);

By the way, its conventional for variables to start lowercase, with following words starting withACapitalLetter

 

Chinwe

Show Spoiler Hide Spoiler

Code:java

    public void CFGRemoveArena(String GameArena, String location, String type, String related)
    {
        String ArenaNames = plugin.SimonCFGM.getArenaConfig().getString("ArenaNames");
        String ArenaLocs = plugin.SimonCFGM.getArenaConfig().getString("ArenaLocations");
        String ArenaTypes = plugin.SimonCFGM.getArenaConfig().getString("ArenaTypes");
        String RelatedArenas = plugin.SimonCFGM.getArenaConfig().getString("RelatedArena");
 
        if(ArenaNames == null || ArenaLocs == null || ArenaTypes == null || RelatedArenas == null)
        {
            plugin.SimonLog.logWarning("Attempted to delete an arena from an empty cfg! Canceled!");
        }
        else
        {   
            CFGremoveFromList("ArenaNames", GameArena);
            CFGremoveFromList("ArenaLocations", location);
            CFGremoveFromList("ArenaTypes", type);
            CFGremoveFromList("RelatedArena", related);
 
            plugin.SimonLog.logInfo("Deleting process finished for arena: " + GameArena);
        }
    }
 
 
    public void CFGremoveFromList(String list, String remove)
    {
        String[] split = list.split(" | ");
        StringBuilder sb = new StringBuilder();
 
        for (String s : split)
        {
            if (!s.equals("|") && !s.equals(remove))
            {
                sb.append(s + (s.equals(split[split.length - 1]) ? "" : " | "));
            }
 
            plugin.SimonCFGM.getArenaConfig().set(s.toString(), s);
        }
 
        plugin.SimonCFGM.saveArenaConfig();
        plugin.SimonCFGM.reloadArenaConfig();
 
        plugin.SimonCFGM.CFGLoadGameArenas();
    }

Thanks again, I got messed up with this :S

Code above doesn't work either, just resets everything to:

Code:

# Default Arena Configuration for 'SimonSays' - Eden.Campo
 
ArenaNames: ArenaNames
ArenaLocations: ArenaLocations
ArenaTypes: ArenaTypes
RelatedArena: RelatedArena

 

It's still in the loop (and the arguments are wrong) :3
Paste this to replace CFGremoveFromList:

Code:

    public void CFGremoveFromList(String list, String remove)
    {
        String[] split = list.split(" | ");
        StringBuilder sb = new StringBuilder();
 
        for (String s : split)
        {
            if (!s.equals("|") && !s.equals(remove))
            {
                sb.append(s + (s.equals(split[split.length - 1]) ? "" : " | "));
            }
 
        }
            plugin.SimonCFGM.getArenaConfig().set(list, sb.toString());
 
        plugin.SimonCFGM.saveArenaConfig();
        plugin.SimonCFGM.reloadArenaConfig();
 
        plugin.SimonCFGM.CFGLoadGameArenas();
    }

 

Chinwe

Got it working, thanks!