Solved /reply is not working

Hello, I am having trouble making a /reply command. The problem is that each time I use /reply it says "There is no one to reply to.", even after somone sent me a message. Here is my code:

Code:java

public class msg implements CommandExecutor{
    private Main main;
 
    public msg(Main main)
    {
        this.main = main;
    }
 
 
    private Map<String, String> map = new HashMap<String, String>();
 
    @Override
    public boolean onCommand(CommandSender Sender, Command cmd, String commandLabel, String[] args){
        String noperm = main.getConfig().getString("NoPermission").replace("&", "§");
        String prefix = main.getConfig().getString("Prefix").replace("&", "§");
        if(cmd.getName().equalsIgnoreCase("message")){
            if(Sender instanceof Player){
                Player player = (Player) Sender;
                if(player.hasPermission("pcommands.msg")){
                    if(args.length >= 2){
                        Player target = Bukkit.getPlayer(args[0]);
                        if(target == null){
                            player.sendMessage(prefix + "§cPlayer not found.");
                        }else{
                            StringBuilder sb = new StringBuilder();
                            for(int i=1; i<args.length; i++){
                            sb.append(args[i]).append(" ");
                            }
                            String message = sb.toString();
                            String sendermsg = prefix + "§3" + " [me->" + target.getName() + "] " + ChatColor.WHITE + message.replace("&", "§");
                            String targetmsg = prefix + "§3" + " [" + player.getName() + "->me] " + ChatColor.WHITE + message.replace("&", "§");
                            target.sendMessage(targetmsg);
                            player.sendMessage(sendermsg);
                            this.map.put(target.getName(), player.getName());
                        }
                    }
                }else{
                    player.sendMessage(prefix + noperm);
                }
            }
        }else if(cmd.getName().equalsIgnoreCase("reply")){
            if(Sender instanceof Player){
            Player player = (Player) Sender;
            if(player.hasPermission("pcommands.reply")){
                if(args.length >= 1){
                    if(map.containsKey(player.getName())){
                        Player sendto = Bukkit.getPlayer((String) this.map.get(player.getName()));
                        if(sendto != null){
                            if(sendto.isOnline()){
                                StringBuilder sb = new StringBuilder();
                                for(int i=1; i<args.length; i++){
                                    sb.append(args[i]).append(" ");
                                }
                                String message = sb.toString();
                                String sendermsg = prefix + "§3" + "[me->" + sendto.getName() + "] " + ChatColor.WHITE + message.replace("&", "§");
                                String targetmsg = prefix + "§3" + "[" + player.getName() + "->me] " + ChatColor.WHITE + message.replace("&", "§");
                                sendto.sendMessage(targetmsg);
                                player.sendMessage(sendermsg);
                            }else{
                                player.sendMessage(prefix + "§cPlayer is not online!");
                            }
                            player.sendMessage(prefix + "§cPlayer not found.");
                        }else{
                            player.sendMessage(prefix + "§cPlayer not found.");
                        }
                    }else{
                        player.sendMessage(prefix + "§cThere is no one to reply to.");
                    }
                }
            }
            }
        }
        return false;
    }
}[/i][/i]

Any ideas on how to solve this? Thanks for the help

 

random_username Could you try putting the inverse into the HashMap as well? i.e.

Code:

this.map.put(target.getName(), player.getName());
this.map.put(player.getName(), target.getName());

 

Okay, I'm going to try it, thanks for the reply

afistofirony
Nope, It's not working could there be another way to solve it?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Modified the code a bit, any ideas on how to solve it?
code:

Code:java

public class msg implements CommandExecutor{
    private Main main;
 
    public msg(Main main)
    {
        this.main = main;
    }
 
    //for the ones who use /message
    private Map<String, String> map = new HashMap<String, String>();
 
 
    @Override
    public boolean onCommand(CommandSender Sender, Command cmd, String commandLabel, String[] args){
        String noperm = main.getConfig().getString("NoPermission").replace("&", "§");
        String prefix = main.getConfig().getString("Prefix").replace("&", "§");
        if(cmd.getName().equalsIgnoreCase("message")){
            if(Sender instanceof Player){
                Player player = (Player) Sender;
                if(player.hasPermission("pcommands.msg")){
                    if(args.length >= 2){
                        Player target = Bukkit.getPlayer(args[0]);
                        if(target == null){
                            player.sendMessage(prefix + "§cPlayer not found.");
                        }else{
                            StringBuilder sb = new StringBuilder();
                            for(int i=1; i<args.length; i++){
                            sb.append(args[i]).append(" ");
                            }
                            String message = sb.toString();
                            String sendermsg = prefix + "§3" + " [me->" + target.getName() + "] " + ChatColor.WHITE + message.replace("&", "§");
                            String targetmsg = prefix + "§3" + " [" + player.getName() + "->me] " + ChatColor.WHITE + message.replace("&", "§");
                            target.sendMessage(targetmsg);
                            player.sendMessage(sendermsg);
                            this.map.put(target.getName(), player.getName());
                        }
                    }
                }else{
                    player.sendMessage(prefix + noperm);
                }
            }
        }else if(cmd.getName().equalsIgnoreCase("reply")){
            if(Sender instanceof Player){
            Player player = (Player) Sender;
            if(player.hasPermission("pcommands.reply")){
                if(args.length >= 1){
                    if(map.containsKey(player.getName())){
                        Player target = Bukkit.getPlayer((String) this.map.get(player.getName()));
                        if(target != null){
                            if(target.isOnline()){
                                StringBuilder sb = new StringBuilder();
                                for(int i=1; i<args.length; i++){
                                    sb.append(args[i]).append(" ");
                                }
                                String message = sb.toString();
                                String sendermsg = prefix + "§3" + "[me->" + target.getName() + "] " + ChatColor.WHITE + message.replace("&", "§");
                                String targetmsg = prefix + "§3" + "[" + player.getName() + "->me] " + ChatColor.WHITE + message.replace("&", "§");
                                target.sendMessage(targetmsg);
                                player.sendMessage(sendermsg);
                                this.map.remove(target.getName());
                                this.map.remove(player.getName());
                                this.map.put(target.getName(), player.getName());
 
                            }else{
                                player.sendMessage(prefix + "§cPlayer is not online!");
                            }
                            player.sendMessage(prefix + "§cPlayer not found.");
                        }else{
                            player.sendMessage(prefix + "§cPlayer not found.");
                        }
                    }else{
                        player.sendMessage(prefix + "§cThere is no one to reply to.");
                    }
                }
            }
            }
        }
        return false;
    }
}
[/i][/i]

 

random_username
It doesn't work?? or does it now?

 

It isn't working at the moment

 

bump, any ideas? The problem is that each time someone uses /reply, it says "There is no one to reply to.", even after receiving a message. Code:

Code:java

public class msg implements CommandExecutor{
    private Main main;
 
    public msg(Main main)
    {
        this.main = main;
    }
 
    //for the ones who use /message
    private Map<String, String> map = new HashMap<String, String>();
 
 
    @Override
    public boolean onCommand(CommandSender Sender, Command cmd, String commandLabel, String[] args){
        String noperm = main.getConfig().getString("NoPermission").replace("&", "§");
        String prefix = main.getConfig().getString("Prefix").replace("&", "§");
        if(cmd.getName().equalsIgnoreCase("message")){
            if(Sender instanceof Player){
                Player player = (Player) Sender;
                if(player.hasPermission("pcommands.msg")){
                    if(args.length >= 2){
                        Player target = Bukkit.getPlayer(args[0]);
                        if(target == null){
                            player.sendMessage(prefix + "§cPlayer not found.");
                        }else{
                            StringBuilder sb = new StringBuilder();
                            for(int i=1; i<args.length; i++){
                            sb.append(args[i]).append(" ");
                            }
                            String msg = sb.toString();
                            String message = ChatColor.translateAlternateColorCodes('&', msg);
                            String sendermsg = prefix + "§3" + " [me->" + target.getName() + "] " + ChatColor.WHITE + message.replace("&", "§");
                            String targetmsg = prefix + "§3" + " [" + player.getName() + "->me] " + ChatColor.WHITE + message.replace("&", "§");
                            target.sendMessage(targetmsg);
                            player.sendMessage(sendermsg);
                            this.map.put(target.getName(), player.getName());
                        }
                    }
                }else{
                    player.sendMessage(prefix + noperm);
                }
            }
        }else if(cmd.getName().equalsIgnoreCase("reply")){
            if(Sender instanceof Player){
            Player player = (Player) Sender;
            if(player.hasPermission("pcommands.reply")){
                if(args.length >= 1){
                    if(map.containsKey(player.getName())){
                        Player target = Bukkit.getPlayer((String) this.map.get(player.getName()));
                        if(target != null){
                            if(target.isOnline()){
                                StringBuilder sb = new StringBuilder();
                                for(int i=0; i<args.length; i++){
                                    sb.append(args[i]).append(" ");
                                }
                                String msg = sb.toString();
                                String message = ChatColor.translateAlternateColorCodes('&', msg);
                                String sendermsg = prefix + "§3" + "[me->" + target.getName() + "] " + ChatColor.WHITE + message.replace("&", "§");
                                String targetmsg = prefix + "§3" + "[" + player.getName() + "->me] " + ChatColor.WHITE + message.replace("&", "§");
                                target.sendMessage(targetmsg);
                                player.sendMessage(sendermsg);
                                this.map.remove(target.getName());
                                this.map.remove(player.getName());
                                this.map.put(target.getName(), player.getName());
 
                            }else{
                                player.sendMessage(prefix + "§cPlayer is not online!");
                            }
                            player.sendMessage(prefix + "§cPlayer not found.");
                        }else{
                            player.sendMessage(prefix + "§cPlayer not found.");
                        }
                    }else{
                        player.sendMessage(prefix + "§cThere is no one to reply to.");
                    }
                }
            }
            }
        }
        return false;
    }
}
[/i][/i]

Thanks for the help

 

random_username
Try to do this under the line that says

Code:

this.map.put(target.getName(), player.getName());

Put this under that ^

Code:

this.map.put(player.getName(), target.getName());

 

ajs333
Why was i tagged?

 

The Gaming Grunts
I acedentaly taged you but removed your name sorry...

 

ajs333
Its ok

 

It still says "there is no one to reply to", is there any other way to fix this?

 

random_username

Code:java

map.containsKey(player.getName())
// in the IF statement for reply
// Make it
map.containsValue(player.getName())

 

Nope, that isn't working either, btw, thanks for the reply .
Any other ideas??

 

are the messages being sent to one another and the replier has the correct permissions?

if so, try adding your hashmap to your main class, like this:

Code:

public static HashMap<String, Stirng> map = new HashMap<String, String>();

and access it from there, rather than in your command executor class

 

while using /message yes, they are. But when I use /reply, it says "there is no one to reply to".

 

read my edit

 

What do you mean? Do I just set the Hashmap to:

Code:java

 private static Map<String, String> map = new HashMap<String, String>();

?

 

put that hashmap in your main class, the class that extends JavaPlugin. and use the hashmap their to put the targets of /reply

 

so when I want to put the users, I should do:

Code:java

main.map.put(target.getName(), player.getName());

? Btw, this part is in the msg class, hashmap in the main class.

 

yes! any luck?

 

Sorry for late response, had to look for someone to help me test. Yes, that solved it, thanks so much!

 

BTW for future references: every time a command is typed with the correct syntax, like /msg or /reply, a new instance of your command executor class will be created resulting in the hash map to be reset every time the command is typed

 

random_username
I have been trying to code something similar to what you just did and I only get one error on this line...

Code:

 main.map.put(target.getName(), player.getName());

 

Actually, this is not the case unless the code specifically says to do so. For example, if you use getCommand("msg").setExecutor(new MessageCommand()), that specific instance is stored as the instance to reference, not the class itself.

The only case in which creating a new instance for every execution would be realistic is if the command's class was stored, not an instance of the class (i.e. getCommand("msg").setExecutor(MessageCommand.class)). However, this can lead to issues with <class>.newInstance() because the class may not have a default constructor (one with no parameters).