Solved Removing online players from a HashMap?

Well, I was about finished with coding this minigame, though it doesn't seem to remove players that are online & in the HashMap...

Code:

Code:java

for(Player online : PO.getOnlinePlayers())
if(Scoreboards.pointD.containsKey(online.getName())) {
Scoreboards.pointD.put(online.getName(), 0);
}

PO.java:

Code:java

public static List<Player> getOnlinePlayers() {
List<Player> list = Lists.newArrayList();
for (World world : Bukkit.getWorlds()) {
list.addAll(world.getPlayers());
}
return Collections.unmodifiableList(list);
}

 

hashmap.remove(key);

 

FisheyLP
I'll try it again, didn't seem to work earlier..

 

...
just do

Code:java

return list;

 

WesJD

Firstly, I can immediately see that you understand little of the principles of object orientated programming, as you are making seemingly unnecessary calls to static methods. Please learn about statics and where it is appropriate to use them.

Secondly, why are you using a method like this to retrieve an immutable list of all online players? Why not use:

Code:java

Bukkit.getOnlinePlayers();

 

Why are you not using Bukkit.getOnlinePlayers()?

Post code or we have no proof of you trying.

 

FisheyLP
Changed the return, and it's working now. Thanks.

I'm not going to question it as I'm just a basic Java programmer. I'll take a look at when it is. Thanks.