Removing items with certain meta from player inventory,

Hey guys Again, im working on this money plugin and i have got the counting part of the deposit down pat. But i cant figure out why it wont remove the money, I dont get any errors in the console.

Code:java

    public int countAndRemoveMoney(Inventory inventory) {
          int amount = 0;
        ItemStack[] contents = inventory.getContents();
          ItemStack money1 = new ItemStack(339, 1);
          ItemStack money2 = new ItemStack(339, 1);
          ItemStack money3 = new ItemStack(339, 1);
          ItemStack money4 = new ItemStack(339, 1);
          ItemStack money5 = new ItemStack(339, 1);
          ItemStack money6 = new ItemStack(339, 1);
          ItemStack money7 = new ItemStack(339, 1);
          ItemStack money8 = new ItemStack(339, 1);
          ItemStack money9 = new ItemStack(339, 1);
          ItemStack money10 = new ItemStack(339, 1);
        money1.setItemMeta(money_ones);
        money2.setItemMeta(money_twos);
        money3.setItemMeta(money_threes);
        money4.setItemMeta(money_fours);
        money5.setItemMeta(money_fives);
        money6.setItemMeta(money_sixs);
        money7.setItemMeta(money_sevens);
        money8.setItemMeta(money_eights);
        money9.setItemMeta(money_nines);
        money10.setItemMeta(money_tens);
 
 
            // Do the same for all of your types of money, changing it to be * (dollar value)
        // }
 
        if(inventory.contains(money1)) {
            amount += money1.getAmount() *1;
 
            money1.setAmount(0);
        }
        if(inventory.contains(money2)) {
            amount += money2.getAmount() *2;
   money2.setAmount(0);
        }
        if(inventory.contains(money3)) {
            amount += money3.getAmount() *3;
              money3.setAmount(0);
        }
        if(inventory.contains(money4)) {
            amount += money4.getAmount() *4;
              money4.setAmount(0);
        }
        if(inventory.contains(money5)) {
            amount += money5.getAmount() *5;
              money5.setAmount(0);
        }
        if(inventory.contains(Material.PAPER)) {
            amount += money6.getAmount() *6;
              money6.setAmount(0);
        }
        if(inventory.contains(money7)) {
            amount += money7.getAmount() *7;
              money7.setAmount(0);
        }
        if(inventory.contains(money8)) {
            amount += money8.getAmount() *8;
          money8.setAmount(0);
        }
        if(inventory.contains(money9)) {
            amount += money9.getAmount() *9;
              money9.setAmount(0);
        }
        if(inventory.contains(money10)) {
            amount += money10.getAmount() *10;
 
   money10.setAmount(0);
        }
 
 
          return amount;
        }

If you need more of the code please comment below and tag me

 

Give the money a display name

Code:java

                                if(player.getInventory().contains(ItemStackHere).getItemMeta().getDisplayName("Display name here")) {
                                    player.getInventory().remove(ItemStackHere);
                                }

 

You'll have to work with colors if you want to do that in a safe manner...

 

True, but having a money plugin wouldn't you need to do so anyways? You wouldn't be able to differentiate between currencies if you didn't have them.

 

He might be setting the lore.

 

i did indeed set the display name with $AMOUNT
the lore for all the money is the same

 

Don't forget to apply a chat color then.

 

Yeah he is correct. You would have to add chat color for example if it was green.

Code:java

if(player.getInventory().contains(ItemStackHere).getItemMeta().getDisplayName(ChatColor.GREEN + "Display name here")) {
      player.getInventory().remove(ItemStackHere);
}

The name is case sensitive aswell.

 

Yeah i think ill do that

 

oh, I forgot to add this. you need to specify the amount to remove, most likely one so just do this

1. Code:java

   player.getInventory().remove(ItemStackHere, 1);

 

But

Code:

ItemStack money = new ItemStack(339, 1);
if(player.getInventory().contains(money)) {
    if(money.getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN + "$2" )) {
        amount += money.getAmount() * 2;
    }
   
}

I wont be able to get the different money and add them all up, or am i over thinking this

 

If all the display names are different, the money will be counted as separate itemstacks. so if you had an emerald named "$2" and another named "$5" they would count as different itemstacks. The money could still be sorted

 

Im sorry im not getting any of this but i have these at the top would there be a simpler way to use these to get the items?

Code:java

static {
        ItemStack paper = new ItemStack(Material.PAPER);
        List<String> moneyLore = Arrays.asList(ChatColor.GRAY + "Issued by MonkeyCraft's bank department.");
 
        // Initialize $1 bills
        money_ones = paper.getItemMeta();
        money_ones.setDisplayName(ChatColor.GREEN + "$1");
        money_ones.setLore(moneyLore);
        // etc, do this for all the bill types
    }
    public static final ItemMeta money_twos;
    // etc for all the money types
 
    static {
        ItemStack paper = new ItemStack(Material.PAPER);
        List<String> moneyLore = Arrays.asList(ChatColor.GRAY + "Issued by MonkeyCraft's bank department.");
 
        // Initialize $1 bills
        money_twos = paper.getItemMeta();
        money_twos.setDisplayName(ChatColor.GREEN + "$2");
        money_twos.setLore(moneyLore);
        // etc, do this for all the bill types
    }
    public static final ItemMeta money_threes;
    // etc for all the money types
 
    static {
        ItemStack paper = new ItemStack(Material.PAPER);
        List<String> moneyLore = Arrays.asList(ChatColor.GRAY + "Issued by MonkeyCraft's bank department.");
 
        // Initialize $1 bills
        money_threes = paper.getItemMeta();
        money_threes.setDisplayName(ChatColor.GREEN + "$3");
        money_threes.setLore(moneyLore);
        // etc, do this for all the bill types
    }
    public static final ItemMeta money_fours;
    // etc for all the money types
 
    static {
        ItemStack paper = new ItemStack(Material.PAPER);
        List<String> moneyLore = Arrays.asList(ChatColor.GRAY + "Issued by MonkeyCraft's bank department.");
 
        // Initialize $1 bills
        money_fours = paper.getItemMeta();
        money_fours.setDisplayName(ChatColor.GREEN + "$4");
        money_fours.setLore(moneyLore);
        // etc, do this for all the bill types
    }
    public static final ItemMeta money_fives;
    // etc for all the money types
 
    static {
        ItemStack paper = new ItemStack(Material.PAPER);
        List<String> moneyLore = Arrays.asList(ChatColor.GRAY + "Issued by MonkeyCraft's bank department.");
 
        // Initialize $1 bills
        money_fives = paper.getItemMeta();
        money_fives.setDisplayName(ChatColor.GREEN + "$5");
        money_fives.setLore(moneyLore);
        // etc, do this for all the bill types
    }
    public static final ItemMeta money_sixs;
    // etc for all the money types
 
    static {
        ItemStack paper = new ItemStack(Material.PAPER);
        List<String> moneyLore = Arrays.asList(ChatColor.GRAY + "Issued by MonkeyCraft's bank department.");
 
        // Initialize $1 bills
        money_sixs = paper.getItemMeta();
        money_sixs.setDisplayName(ChatColor.GREEN + "$6");
        money_sixs.setLore(moneyLore);
        // etc, do this for all the bill types
    }
    public static final ItemMeta money_sevens;
    // etc for all the money types
 
    static {
        ItemStack paper = new ItemStack(Material.PAPER);
        List<String> moneyLore = Arrays.asList(ChatColor.GRAY + "Issued by MonkeyCraft's bank department.");
 
        // Initialize $1 bills
        money_sevens = paper.getItemMeta();
        money_sevens.setDisplayName(ChatColor.GREEN + "$7");
        money_sevens.setLore(moneyLore);
        // etc, do this for all the bill types
    }
    public static final ItemMeta money_eights;
    // etc for all the money types
 
    static {
        ItemStack paper = new ItemStack(Material.PAPER);
        List<String> moneyLore = Arrays.asList(ChatColor.GRAY + "Issued by MonkeyCraft's bank department.");
 
        // Initialize $1 bills
        money_eights = paper.getItemMeta();
        money_eights.setDisplayName(ChatColor.GREEN + "$8");
        money_eights.setLore(moneyLore);
        // etc, do this for all the bill types
    }
    public static final ItemMeta money_nines;
    // etc for all the money types
 
    static {
        ItemStack paper = new ItemStack(Material.PAPER);
        List<String> moneyLore = Arrays.asList(ChatColor.GRAY + "Issued by MonkeyCraft's bank department.");
 
        // Initialize $1 bills
        money_nines = paper.getItemMeta();
        money_nines.setDisplayName(ChatColor.GREEN + "$9");
        money_nines.setLore(moneyLore);
        // etc, do this for all the bill types
    }
    public static final ItemMeta money_tens;
    // etc for all the money types
 
    static {
        ItemStack paper = new ItemStack(Material.PAPER);
        List<String> moneyLore = Arrays.asList(ChatColor.GRAY + "Issued by MonkeyCraft's bank department.");
 
        // Initialize $1 bills
        money_tens = paper.getItemMeta();
        money_tens.setDisplayName(ChatColor.GREEN + "$1");
        money_tens.setLore(moneyLore);
        // etc, do this for all the bill types
    }

 

the best way to do this is to make a new itemstack, then get the item meta, set your things and set the itemmeta to what it was. ex.

Code:java

ItemStack money1 = new ItemStack(Material.PAPER);
ItemMeta im = money1.getItemMeta();
im.setDisplayName(ChatColor.GREEN + "$1");
im.setLore(ChatColor.GRAY + "Lore");
money1.setItemMeta(im);

That will make a new itemstack, set the lore and display name all in 5 lines. Saves a lot of time. Just repeat that for other bills and rename the item meta and the itemstack