Registering in the Main Class

I have a bit of a problem. I am trying to code a kit where you can teleport a player in a 3x2000x3 area to you and have a 5 second cooldown. I believe I have to register this in the main class though and I have no idea how. Any help?
Kit Class:

Code:java

HashMap<String, Integer> map = new HashMap<String, Integer>();
 
    public void addCooldown(String name, int time){
        map.put(name, time);
    }
 
    public boolean hasCooldown(String name){
        return map.containsKey(name);
    }
 
    public void removeOneSecond(String name){
        map.put(name, map.get(name) - 1);
    }
 
    public int getSeconds(String name){
        if(map.containsKey(name)){
            return map.get(name);
        }else{
            return 0;
        }
    }
    public void startTask(){
        new BukkitRunnable(){
            public void run(){
                for(String entry : map.keySet()){
                    removeOneSecond(entry);
                    int amount = getSeconds(entry);
                    if(amount <= 0){
                        map.remove(entry);
                    }
                }
            }
        }.runTaskTimer(Main.getInstance(), 0, 20); //Runs every second, also. Im not 100% sure but this might cause a concurrent modification exception
    }
}
 
 
 
 
 
 

Main class:

Code:java

package me.TCOB055.MultiKits;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scheduler.BukkitRunnable;
 
public class Main extends JavaPlugin {
    public GUIListener guilisten = new GUIListener(this);
    public Events Events = new Events(this);
    //array lists for kits
    ArrayList<String> PvP = new ArrayList<String>();
    ArrayList<String> Fisherman = new ArrayList<String>();
    ArrayList<String> kitused = new ArrayList<String>();
    ArrayList<String> venom = new ArrayList<String>();
    ArrayList<String> trampler = new ArrayList<String>();
    ArrayList<String> TearGhast = new ArrayList<String>();
    ArrayList<String> Archer = new ArrayList<String>();
    ArrayList<String> Taken = new ArrayList<String>();
    ArrayList<String> Ninja = new ArrayList<String>();
    ArrayList<String> Caveman = new ArrayList<String>();
    ArrayList<String> Launcher = new ArrayList<String>();
    ArrayList<String> Reverser = new ArrayList<String>();
    //end of array lists
 
    public void onEnable() {
        commands();
        events();
    }
 
    public void commands(){
        getCommand("Fisherman").setExecutor(new Fisherman(this));
        getCommand("PvP").setExecutor(new PvP(this));
        getCommand("kit").setExecutor(new Kit(this));
        getCommand("Venom").setExecutor(new Venom(this));
        getCommand("Trampler").setExecutor(new Trampler(this));
        getCommand("tearghast").setExecutor(new TearGhast(this));
        getCommand("Archer").setExecutor(new Archer(this));
        getCommand("Taken").setExecutor(new Taken(this));
        getCommand("Ninja").setExecutor(new Ninja(this));
        getCommand("Caveman").setExecutor(new Caveman(this));
        getCommand("Launcher").setExecutor(new Launcher(this));
        getCommand("Reverser").setExecutor(new Reverser(this));
    }
 
    public void events(){
        PluginManager pm = getServer().getPluginManager();
        pm.registerEvents(Events, this);
        pm.registerEvents(guilisten, this);
 
    }
}
 
 

 

TCO_007 I'd reccomend a different approach, as what you want is a delay, not a cooldown. You can simply use either a BukkitRunnable or a repeating task that runs every second and checks if the Player has moved, and if he hasn't, it either continues counting down or teleports him, and cancels the task/runnable.

 

Well, what Im trying to do is basically recreate the kit Endermage from the well-known HG server of MC-HG.
I just want it so that the player cant teleport again for atleast 5 seconds. And where can I learn how to take your approach because this is the first time I have ever tried to make a cooldown. xTigerRebornx

by the way, this is the kit event in that same class:

Code:java

@ EventHandler
    public void onTakenClick(PlayerInteractEvent event) {
        Player p = (Player) event.getPlayer();
        if (plugin.Taken.contains(p.getName())){
            if (event.getAction() == Action.RIGHT_CLICK_AIR && p.getItemInHand().getType() == Material.IRON_INGOT) {
                List<Entity> nearby = p.getNearbyEntities(3, 20000, 3);
                for (Entity tmp : nearby)
                        if (tmp instanceof Player) {
                            tmp.teleport(p.getLocation()); 
                            p.teleport(p.getLocation());
                            p.sendMessage(ChatColor.GOLD + "You have teleported " + ((Player) tmp).getName() + " to you!");
 
                        }
                }
            }
 
        }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

TCO_007 Ah, my bad, I read what the problem was wrong. You are taking the correct approach to what you are doing, but I'd still reccomend using a scheduler to work with your cooldowns. You could simply add them to a List that stores who is cooling down, and use a delayed task to remove them from that List a few seconds later. Look into how to use the Bukkit Scheduler

 

Can you help me with this though? It says the ".getInstance()..." at the bottom is "undefined for the type main". I figure that means I have to register that in the Main class but I have no idea how to.

 

List would work but is an ordered collection, not exactly descriptive of what we truly want here. A little bit of OO theory lesson: a plain Collection (or Set) would work best, and then we could chose from HashSet, ArrayList, LinkedList, LinkedHashSet, etc.

You should probably not be using the Singleton pattern, but since dependency injection would create a lot of objects with the same reference, you should either schedule this in the main class, or just create a singleton system with getInstance().

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I dont want any given code straight to me here but is there an example code I could use anywhere thats from recent? I will have to look up what the singleton system is because I have no idea what that is XD
Now how could I schedule it in the main class? Thats what I am stuck on.
coasterman10

 

TCO_007 Singleton is a design paattern where you have just one instance of a class that is accessed by a static method such as getInstance(). It's a bit different for Bukkit plugins because they don't instantiate themselves, hence why it is a bit weird and not optimal. Here's the general pattern:

Code:java

public class Main extends JavaPlugin {
  private static Main instance;
 
  public static Main getInstance() {
    return instance;
  }
 
  public void onEnable() {
    instance = this;
  }
 
  public void onDisable() {
    instance = null;
  }
}

Now, if you aren't creating a huge number of a class, dependency injection works well, and is generally preferable to singletons for a number of reasons, one being that not only does it eliminate temptations to bad static coding practices, but it also supports different instances of the injected class. Dependency injection is where you take the class you want to reference, and pass it into another class's constructor so it can reference it later, like so:

Code:java

public class Foo {
  private final Main plugin;
 
  public Foo(Main plugin) {
    this.plugin = plugin;
  }
}

I personally prefer dependency injection. In this case, you may want to consider using it. To schedule the task in your kit class, you would use dependency injection to pass it the plugin, and then just use "plugin" instead of "Main.getInstance()".

 

So the code should look like this now correct?
Kit Taken Event:

Code:java

@ EventHandler
    public void onTakenClick(PlayerInteractEvent event) {
        Player p = (Player) event.getPlayer();
        if (plugin.Taken.contains(p.getName())){
            if (event.getAction() == Action.RIGHT_CLICK_AIR && p.getItemInHand().getType() == Material.IRON_INGOT) {
                List<Entity> nearby = p.getNearbyEntities(3, 20000, 3);
                for (Entity tmp : nearby)
                        if (tmp instanceof Player) {
                            tmp.teleport(p.getLocation()); 
                            p.teleport(p.getLocation());
                            p.sendMessage(ChatColor.GOLD + "You have teleported " + ((Player) tmp).getName() + " to you!");
 
                        }
                }
            }
 
        }

The map event:

Code:java

HashMap<String, Integer> map = new HashMap<String, Integer>();
 
    public void addCooldown(String name, int time){
        map.put(name, time);
    }
 
    public boolean hasCooldown(String name){
        return map.containsKey(name);
    }
 
    public void removeOneSecond(String name){
        map.put(name, map.get(name) - 1);
    }
 
    public int getSeconds(String name){
        if(map.containsKey(name)){
            return map.get(name);
        }else{
            return 0;
        }
    }
    public void startTask(){
        new BukkitRunnable(){
            public void run(){
                for(String entry : map.keySet()){
                    removeOneSecond(entry);
                    int amount = getSeconds(entry);
                    if(amount <= 0){
                        map.remove(entry);
                    }
                }
            }
        }.runTaskTimer(plugin, 0, 20); //Runs every second, also. Im not 100% sure but this might cause a concurrent modification exception
    }
}
 
 

The main class:

Code:java

package me.TCOB055.MultiKits;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scheduler.BukkitRunnable;
 
public class Main extends JavaPlugin {
    public GUIListener guilisten = new GUIListener(this);
    public Events Events = new Events(this);
    //array lists for kits
    ArrayList<String> PvP = new ArrayList<String>();
    ArrayList<String> Fisherman = new ArrayList<String>();
    ArrayList<String> kitused = new ArrayList<String>();
    ArrayList<String> venom = new ArrayList<String>();
    ArrayList<String> trampler = new ArrayList<String>();
    ArrayList<String> TearGhast = new ArrayList<String>();
    ArrayList<String> Archer = new ArrayList<String>();
    ArrayList<String> Taken = new ArrayList<String>();
    ArrayList<String> Ninja = new ArrayList<String>();
    ArrayList<String> Caveman = new ArrayList<String>();
    ArrayList<String> Launcher = new ArrayList<String>();
    ArrayList<String> Reverser = new ArrayList<String>();
    //end of array lists
  public void onDisable(){
      instance = null;
  }
    public void onEnable() {
        commands();
        events();
        instance = this;
    }
 
    public void commands(){
        getCommand("Fisherman").setExecutor(new Fisherman(this));
        getCommand("PvP").setExecutor(new PvP(this));
        getCommand("kit").setExecutor(new Kit(this));
        getCommand("Venom").setExecutor(new Venom(this));
        getCommand("Trampler").setExecutor(new Trampler(this));
        getCommand("tearghast").setExecutor(new TearGhast(this));
        getCommand("Archer").setExecutor(new Archer(this));
        getCommand("Taken").setExecutor(new Taken(this));
        getCommand("Ninja").setExecutor(new Ninja(this));
        getCommand("Caveman").setExecutor(new Caveman(this));
        getCommand("Launcher").setExecutor(new Launcher(this));
        getCommand("Reverser").setExecutor(new Reverser(this));
    }
 
    public void events(){
        PluginManager pm = getServer().getPluginManager();
        pm.registerEvents(Events, this);
        pm.registerEvents(guilisten, this);
 
    }
 
    private static Main instance;
 
      public static Main getInstance() {
        return instance;
      }
}
 
 

coasterman10

 

coasterman10 When I used the term "List", was referring to any sort of List or Collection, not just a List.

 

I am still not seeing though where the code actually puts the player into the cooldown because its not with the code of the Taken kit and that EventHandler doesnt have anything in it that references to it. Does the kit (after teleporting them) even add them to the cooldown?

 

Well it seems you have managed to mix up dependency injection and the singleton. Seeing as you have implemented the singleton correctly in your main class, replace "plugin" with "Main.getInstance()" in your event class.

As for making the cooldown actually happen, that is up to you to determine the logic. If the code isn't there, add it.

 

Well, Im just confused now because I thought that Hashmap was all I needed but seeing as Its not, would I just add the player to the Hashmap "map"?
Like map.add(p.getName())?
Thats how I have done it with ArrayLists but they are not quite the same thing so Im a little stuck on that part. So this code should be correct now though correct? I changed the plugin to Main.getInstance();

Code:java

HashMap<String, Integer> map = new HashMap<String, Integer>();
 
    public void addCooldown(String name, int time){
        map.put(name, time);
    }
 
    public boolean hasCooldown(String name){
        return map.containsKey(name);
    }
 
    public void removeOneSecond(String name){
        map.put(name, map.get(name) - 1);
    }
 
    public int getSeconds(String name){
        if(map.containsKey(name)){
            return map.get(name);
        }else{
            return 0;
        }
    }
    public void startTask(){
        new BukkitRunnable(){
            public void run(){
                for(String entry : map.keySet()){
                    removeOneSecond(entry);
                    int amount = getSeconds(entry);
                    if(amount <= 0){
                        map.remove(entry);
                    }
                }
            }
        }.runTaskTimer(Main.getInstance(), 0, 20); //Runs every second, also. Im not 100% sure but this might cause a concurrent modification exception
    }
}

coasterman10

 

TCO_007 Maps use key/value pairs, so you would use map.add(key, value), like you have in your code.