Registering Events

I started cleaning up my core plugin for my server and I started using multiple classes I think I registered the events wrong this is my onenable

Code:java

    @Override
    public void onEnable(){
        getLogger().info("Minecloud Core Enabled");
        PluginManager pm = this.getServer().getPluginManager();
        pm.registerEvents(new fb(), this);
        pm.registerEvents(this, this);
        //Recipes To Register
        for (ShapedRecipe recipe : recipes) {
            this.getServer().addRecipe(recipe);
        }
 
        for (ShapelessRecipe recipe : shapeless) {
            this.getServer().addRecipe(recipe);
        }
    }

Here's my fb class

Code:java

package com.icloud.dcljr.MinecloudCore;
 
import java.util.ArrayList;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.HumanEntity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.CraftItemEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.ShapedRecipe;
import org.bukkit.inventory.ShapelessRecipe;
import org.bukkit.inventory.meta.ItemMeta;
 
import Utils.EasyItems;
 
public class fb implements Listener {
 
    public static MinecloudCore plugin;
 
    public static ArrayList<ShapelessRecipe> shapeless = new ArrayList<ShapelessRecipe>();
    public static ArrayList<ShapedRecipe> recipes = new ArrayList<ShapedRecipe>();
    //Recipe Limiter To Just Freebuild
    @SuppressWarnings("incomplete-switch")
    @EventHandler
    public void RemoveRecipes(CraftItemEvent e) {
        HumanEntity p = (HumanEntity) e.getViewers().get(0);
        ItemMeta im = e.getRecipe().getResult().getItemMeta();
        if (p instanceof Player) {
            @SuppressWarnings("unused")
            Player player = (Player) p;
            boolean isWorldHM = p.getWorld().getName().startsWith("world");
            boolean isItemHM = (im.hasLore()) ? im.getLore().contains(ChatColor.DARK_AQUA + "Freebuild Item") : false;
            if (!isWorldHM && isItemHM) {
                e.setCancelled(true);
            }
        }
    }
    //Items and their recipes
    {
        ItemStack EnderBow = EasyItems.EasyFreebuild(Material.BOW, (int) 1,(byte) 0, (String) "Enderbow" ,(String) "The dragons essence");
        ShapedRecipe ebow = new ShapedRecipe(new ItemStack(EnderBow));
        ebow.shape(" ST", "SET", " ST");
        ebow.setIngredient('S', Material.STRING);
        ebow.setIngredient('T', Material.STICK);
        ebow.setIngredient('E', Material.DRAGON_EGG);
        recipes.add(ebow);
 
 
        ItemStack LemonG = EasyItems.EasyFreebuild(Material.INK_SACK, (int) 4,(byte) 11, (String) "Lemon Grenade" ,(String) "In Cave Johnsons name");
        ShapelessRecipe LemonGrenade = new ShapelessRecipe(new ItemStack(LemonG));
        LemonGrenade.addIngredient(Material.APPLE);
        LemonGrenade.addIngredient(Material.INK_SACK, 11);
        LemonGrenade.addIngredient(Material.TNT);
        shapeless.add(LemonGrenade);
    }
}
 

 

You'd do

Code:

    private final fb f = new fb(this);

Code:java

pm.registerEvents(this.f, this);

 

sgavster Where would I put those?

 

1. onEnable:
   
   Code:java

   pm.registerEvents(this.f, this);

   
   Under yourplugin implements blah blah
   
   Code:java

    private final fb f = new fb(this);

Edit: AHH I don't know why this is orange, I didn't click the color button..

 

sgavster I get an error under new fb(this)

 

monkeymanboy Put this in your fb class:

Code:

    public static MinecloudCore plugin;
 
    public fb (MinecloudCore instance)
    {
        plugin = instance;
    }

 

sgavster no errors now I'll test it
EDIT: Still get an error

I think it might be this in my main

Code:java

public static ArrayList<ShapelessRecipe> shapeless;
public static ArrayList<ShapedRecipe> recipes;

here's how I did it in class fb

Code:java

    public static ArrayList<ShapelessRecipe> shapeless = new ArrayList<ShapelessRecipe>();
    public static ArrayList<ShapedRecipe> recipes = new ArrayList<ShapedRecipe>();

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Why dont you make recipes like this

Code:

private ShapelessRecipe myRecipe = new ShapelessRecipe(new ItemStack(Material.STICK, 1)).addIngredient(Material.DIRT);

And register it onEnable
getServer().addRecipe(myRecipe);

 

sgavster Because it is in a different class

 

Bump