Solved Regenerate exploded blocks

Hey guys,
what I am trying to do is to make an explosion and regenerate the blocks after some time.
So I created an explosion using 'loc.getWorld().createExplosion(loc, 4, false);'. That works fine.
Now I store the exploded blocks into a list

Code:

public List<Block> blocks;
@EventHandler
public void onEntityExplode(EntityExplodeEvent e) {
blocks = e.blockList();
}

And here is my regeneration method:

Code:

 public void regen() {
for (Block b : blocks) {
b.getLocation().getBlock().setTypeIdAndData(b.getTypeId(), b.getData(), false);
}
}

But it don't work. The blocks explode but dont get replaced.
Thank you for your help

bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Create a delayed task and put back all the blocks from the list.

 

The_Doctor_123 this is what I am doing but it dont work . I delayed regen() for 10 seconds using the BukkitScheduler.

 

MiniDigger
So what does it do? Throw an exception, or just not work? Show us the code you used.

 

Code:

loc.getWorld().createExplosion(loc, 4, false);
Bukkit.getScheduler().runTaskLater(Advent.plugin, new Runnable() {
 
@Override
public void run() {
regen();
}, 20*10);

it dont throw an exception, it just dont replace the blocks. The just blew up.

 

What is the regen() method? Don't you need a List argument so it knows what blocks to regen?

 

the regen method is in the first post. It dont need the blocklist, the list is an attribute

 

MiniDigger
Oh, that's troublesome the way you did that. What if there was a second explosion before the first set of blocks were restored? Create an argument for that method(or just don't have the method at all.. you don't exactly need it to be a method) for the list of blocks in the explosion.

Also, check if the event is even getting executed. Did you register events?

 

the event is getting executed. it checked it with a log msg. I think somethink in the regen() method is wrong.

 

with your EntityExplodeEvent add all blocks exploded to map with Block & location.

Then do what The_Doctor_123 said and set a runnable to get all blocks in that map and place them.

 

MiniDigger
Let me ask you, does regeneration apply to all explosions or just ones generated by your plugin?

 

The_Doctor_123 just ones

Goblom isnt this what I am doing?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

MiniDigger yes, but it looks like every time a new explosion happens then the previous blocks in the list get overwritten

 

Goblom yeah it does but I know that this is the only explosion on the server. Its the lobby server of a network.

 

MiniDigger instead of doing blocks = e.getBlocks();

try doing blocks.add(e.getBlocks());

 

there is not method add(List<Block>) in type list. I used addAll(List<Block>) but it still dont works

 

You can't actually save blocks...

 

This.

All the original method is doing is saving the Block objects, which can be considered a "pointer" to the place in the world. A Block does not store what's actually there, just where it is. (You can check this yourself by looking at CraftBlock.java). So when it attempts to restore the blocks, it's simply setting the block to what it currently is, i.e. doing nothing.

MiniDigger what you want to store is the block's state - and there happens to be a Bukkit class to do exactly that: BlockState. In the initial event handler, add block.getState() for each affected block to a List<BlockState> object. In your deferred task, call state.update(true) for each member of the list.

I do something similar in my PortableHole plugin (not explosion repairing in this case, but closing temporary tunnels through solid blocks).

A couple of other points:

• You will need to track the block states from multiple explosions. One way to do this is create a new class (let's call it Explosion) which stores the List<BlockState> from an explosion. This class could inherit BukkitRunnable, so your event handler can just create one (passing the list of affected blocks to the constructor) and call .runTaskLater() on it. Once the task is run, the object goes out of scope.
• You need to think about what happens if the server is shut down when there is one or more repair operations pending. You can either persist all of the block states that need restoring, or (much easier) do all the repairing from the plugin's onDisable() method (you'll need to keep track of all the pending tasks so you can run them early).

 

desht thank you realy much. Got it working know. Never looked into the differets of Block and BlockState ;D

 

This is probably outdated, but I would LOVE to know how you did this. Can you give me the complete code please MiniDigger?

 

scarabcoder I'll try to send you the code when I am at home.

 

MiniDigger Thanks!

 

desht
Though BlockState is (currently) bugged.. sadly

Example (I tested this with your PortableHole plugin to make sure you run into the same issue): If there is a sign with text in the way of the "portable hole", then, after restoring that sign from air back to sign material, the tile data (sign text) will be lost..forever (no reconnect can fix this).

See this ticket about it: https://bukkit.atlassian.net/browse/BUKKIT-3522

Same issue with all other TileEntityData (chest content etc.)

I really hope this will be fixed soon.

 

scarabcoder there you go:

Code:java

 @EventHandler
public void onEntityExplode(EntityExplodeEvent e) {
ArrayList<Block> blocks = new ArrayList<>();
ArrayList<Block> dontexplode = new ArrayList<>();
for (Block b : e.blockList()) {
if (b.getType() == Material.WOOL || b.getType() == Material.TORCH) {
blocks.add(b);
} else {
dontexplode.add(b);
}
}
for(Block b : dontexplode){
e.blockList().remove(b);
b.getState().update(true);
}e.setYield(0);
GeschenkExplosion ge = new GeschenkExplosion(blocks);
Bukkit.getScheduler().runTaskLater(Advent.plugin, ge, 20 * 20);
}

Code:java

package eu.zonegames.Advent;
 
import java.util.ArrayList;
import java.util.List;
import java.util.Random;
 
import org.bukkit.Bukkit;
import org.bukkit.block.Block;
import org.bukkit.block.BlockState;
import org.bukkit.scheduler.BukkitRunnable;
 
public class GeschenkExplosion extends BukkitRunnable{
 
    List<BlockState> states;
 
    public GeschenkExplosion(ArrayList<BlockState> blocks){
        states = blocks;
    }
 
    public GeschenkExplosion(List<Block> blocks){
        states = new ArrayList<>();
        for(Block b : blocks){
            states.add(b.getState());
        }
    }
 
    @Override
    public void run() {
        regen();
    }
 
    public void regen(){
        for(final BlockState state : states){
            Bukkit.getScheduler().runTaskLater(Advent.plugin, new Runnable() {
 
                @Override
                public void run() {
                    state.update(true);
                }
            }, new Random().nextInt(10*20) + 20);
        }
    }
 
}

 

Thanks a lot MiniDigger!

MiniDigger For some reason, this doesn't work for me. Where do I put the code?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

scarabcoder the first snippet is a event listener. Put it into your Listener. The second one is a class.

 

Okay, thanks!