Random Firework Class - Create some Random Fireworks!

Hello fellow Bukkiteers! I just thought I would make up a quick little Random Firework Class for you guys. If it helps make sure to leave a like! If you have any questions or suggestions on how to make this better, feel free to leave a comment! Thanks for clicking!

RandomFireworks Class:

Code:java

/**
* Created by XvPROTETCEDvX / XvBaseballkidvX on 2/3/14.
*/
public class RandomFireWorks {
 
private static RandomFireWorks fireWorks = new RandomFireWorks();
 
//While in other classes you can now use RandomFirWorks.getManager().<METHODS>();
 
public static RandomFireWorks getManager(){
return fireWorks;
}
 
//Make the arraylists for the colors and types
ArrayList<Color> colors = new ArrayList<Color>();
ArrayList<FireworkEffect.Type> types = new ArrayList<FireworkEffect.Type>();
 
//MAKE SURE YOU PUT THIS IN YOUR ONENABLE!!!
public void addColors(){
//ADD ALL THE COLORS
colors.add(Color.WHITE);
colors.add(Color.PURPLE);
colors.add(Color.RED);
colors.add(Color.GREEN);
colors.add(Color.AQUA);
colors.add(Color.BLUE);
colors.add(Color.FUCHSIA);
colors.add(Color.GRAY);
colors.add(Color.LIME);
colors.add(Color.MAROON);
colors.add(Color.YELLOW);
colors.add(Color.SILVER);
colors.add(Color.TEAL);
colors.add(Color.ORANGE);
colors.add(Color.OLIVE);
colors.add(Color.NAVY);
colors.add(Color.BLACK);
//I think I added them all not sure though
}
 
//MAKE SURE YOU PUT THIS IN YOUR ONENABLE!!!
public void addTypes(){
//ADD ALL THE TYPES
types.add(FireworkEffect.Type.BURST);
types.add(FireworkEffect.Type.BALL);
types.add(FireworkEffect.Type.BALL_LARGE);
types.add(FireworkEffect.Type.CREEPER);
types.add(FireworkEffect.Type.STAR);
//Added all the types
}
 
//Getting a random firework
 
public FireworkEffect.Type getRandomType(){
int size = types.size();
Random ran = new Random();
FireworkEffect.Type theType = types.get(ran.nextInt(size));
 
return theType;
}
 
//Getting a random COLOR!!!
 
public Color getRandomColor(){
int size = colors.size();
Random ran = new Random();
Color color = colors.get(ran.nextInt(size));
 
return color;
}
 
public void launchRandomFirework(Location loc){
Firework fw = loc.getWorld().spawn(loc, Firework.class);
FireworkMeta fm = fw.getFireworkMeta();
fm.setPower(1);
//Adding all the effects to the firework meta
fm.addEffects(FireworkEffect.builder().with(getRandomType()).withColor(getRandomColor()).build());
//set the firework meta to the firework!
fw.setFireworkMeta(fm);
}
}
 

What to do in your onEnable Method:

Code:java

public void onEnable(){
RandomFireWorks.getManager().addColors();
RandomFireWorks.getManager().addTypes();
}

How to use it:

Code:java

Location loc = player.getLocation();
RandomFireWorks.getManager().launchRandomFirework(loc);
 

EDIT: Make sure you use all of the correct imports!

Code:java

import org.bukkit.Color;
import org.bukkit.FireworkEffect;
import org.bukkit.Location;
import org.bukkit.entity.Firework;
import org.bukkit.inventory.meta.FireworkMeta;
 
import java.util.ArrayList;
import java.util.Random;

Thanks for reading - Josh C:

 

You should be keeping your Randoms stored, as creating a new Random isn't something you want to be doing 2+ times per method call.,

 

XvBaseballkidvX You should put addColors and addTypes in a private constructor in the RandomFireworks class

 

If I were you, I'd add the colors like this:

Code:java

for(Color c : Color.values()) {
if(c == null) return;
colors.add(c);
}

 

sgavster Color.values() Will not work for me sadly

 

sgavster
There's nothing that could ever cause a value of Colors to be null.

 

Code:

private Color getRandomBGRColor() {
     return Color.fromBGR(new Random().nextInt(255), new Random().nextInt(255), new Random().nextInt(255));
}

This is a small part of my firework manager. I think this would be a 'bit' more random (and shorter)

 

darkness1999
Except for the fact it'd be a lot less efficient, given you're making a new Random every time.

 

macguy8 I'm pretty sure randoms use hardly any resources, so creating new ones shouldn't be an issue.

 

XvBaseballkidvX They don't use much, however they do take more resources than most other objects to create. Even presuming they use almost no resources to create (which they don't), darkness1999's method would still be making 3 objects per call instead of making 1 per call, or even better making 1 for the entire class and storing it.