Plugin Works as needed, still throws ArrayIndexOutOfBoundsException

Okay, so I have a plugin that I built for the server owner of a server I play on. It's fairly simple: It logs a string of text that you enter into command in a file. The thing is, even though it logs EXACTLY as it should, I'm getting ArrayIndexOutOfBoundsException when I do the command, and my debug message is popping up in the chat. Any help? Here is the code:

Code:java

package me.redstonefreak589.SimpleLog;
 
import java.io.File;
import java.io.FileWriter;
import java.io.IOException;
import java.io.PrintWriter;
import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.Calendar;
import java.util.logging.Logger;
 
import org.apache.commons.lang.StringUtils;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin{
    public final Logger logger = Logger.getLogger("Minecraft");
    public static Main plugin;
 
    @Override
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " has been disabled!");
    }
 
    @Override
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " has been enabled!");
    }
    public void logToFile(String message,String fileName)
 
    {
 
        try
        {
            File dataFolder = getDataFolder();
            if(!dataFolder.exists())
            {
                dataFolder.mkdir();
            }
 
            File saveTo = new File(getDataFolder(), fileName + ".txt");
            if (!saveTo.exists())
            {
                saveTo.createNewFile();
            }
 
 
            FileWriter fw = new FileWriter(saveTo, true);
 
            PrintWriter pw = new PrintWriter(fw);
 
            pw.println(message);
 
            pw.flush();
 
            pw.close();
 
        } catch (IOException e)
        {
 
            e.printStackTrace();
 
        }
 
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
        String newString = "";
        String oldString = "";
        Player player = (Player) sender;
        if(commandLabel.equalsIgnoreCase("log")){
            if(args.length != 0){
                DateFormat dateFormat = new SimpleDateFormat("MM/dd/yyyy HH:mm:ss");
                Calendar cal = Calendar.getInstance();
                String date = dateFormat.format(cal.getTime());
                logToFile("=" + date + "=","logs");
                for(int i = 0; i <= args.length; i++){
                      try{
                          oldString = args[i];
                          newString = newString + oldString + " ";
                      } catch (Exception e){
                        String error = e.toString();
                        logToFile(error,"errors");
                        player.sendMessage(ChatColor.RED + "ERROR: A logging error has occured (This is common). Please refer to the errors.txt file for more information");
                    }
 
                }
                logToFile(newString,"logs");
                logToFile(StringUtils.repeat("=", date.length()/2-3) + "End Of Log" + StringUtils.repeat("=", date.length()/2-3),"logs");
                logToFile(" ","logs");
            }else{
                player.sendMessage(ChatColor.RED + "Usage: /log [text]");
            }
        }
        return false;
    }
}
[/i]

The error is in the for statement inside the try and catch statements (On line 85). The line says "oldString = args;"
Am I doing something wrong, or am I overthinking it? I don't know much java, but I do know lot's about coding bukkit, so I don't really have much of an understanding of these kinds of things. The only thing I know how to do is find the error type, and the line it was on, then fix it. This one however, is stumping me.

Also, I have NO idea what those little [/i]'s are. They just appeared there. :\

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

nateracecar5

Code:

int i = 0; i <= args.length; i++;

This is the problem, Since you are starting at 0, then going to args.length, it will go 1 over the Array's bounds, since the Array will start at 0, but have a length of 1, you could subtract 1 from the length

Code:

int i = 0; i <= (args.length - 1); i++;

 

Okay I will try that, and btw, thanks for the quick response.

Thank you so much! I knew I was overlooking it, I kept doing

Code:java

for(int i = 1; i <= (args.length+1); i++){
//do stuff
}

to try and expirement, but it didn't work.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

nateracecar5 Because you are increasing both by 1, which is the same as starting both from their original. (Either start at one, or use args.length - 1)

 

Okay, thanks

 

nateracecar5 Change this

Code:

int i = 0; i <= args.length; i++;

to

Code:

int i = 0; i < args.length; i++; // (remove the '=')

Doing so would make your OutOfBoundsException stop and it also prevents you from having to add or subract 1 from the the length of the args... (An example is what xTigerRebornx suggested)


Edit: I used to the same thing with <= when i first started writing java. I have since learned that use <= in a for loop can cause much pain.

 

Goblom Thanks. I will remember this in the future.