Solved PlayerJoinEvent Not Passing.

​

​

Source​

I've had this problem for the past two months now, and it's been preventing me from doing any updates to dev.bukkit.

Every time a player joins, I get this stacktrace:​

http://pastebin.com/tZCiCQKX

Upon inspection, you will see that the error refers to these lines:​

​

Code:java

 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent e){
        if ((main.getConfig().getBoolean("CameraMode.Updates.NotifyOps") == true)) {
            if (updater.getResult().equals(UpdateResult.UPDATE_AVAILABLE)) {
                if (updater.getLatestType().toString().equalsIgnoreCase("release")) {
                    if (e.getPlayer().hasPermission("cameramode.update")){
                        e.getPlayer().sendMessage(ChatColor.DARK_AQUA + "CameraMode: " + ChatColor.AQUA + "New Update Available!");
                        e.getPlayer().sendMessage(ChatColor.GRAY + updater.getLatestFileLink().toString());
                    }
                }
            }
        }
    }

Specifically, the first line that mentions the updater class.​

​

I know there's nothing wrong with the updater class.​

It was made by the bukkit dev team and has worked, as is, since before the problem arose.

So I went back to where the updater class is initiated, thinking there might be a problem with how I instantiated it.

Here, you can find the onEnable:​

Code:java

 
    //###### - Objects - ######//
 
 
    UpdateType bifff;
    UpdateType biff = this.getUpdater();
 
    //############################//
    //#########- Start - #########//
    //############################//
 
    public void onEnable() {
        getConfig().options().copyHeader(true);
        getConfig().options().copyDefaults(true);
        saveConfig();
        if (getConfig().getBoolean("CameraMode.Enabled") == false) {
            getLogger().info("Plugin Disable Setting Detected...");
            getServer().getPluginManager().disablePlugin(this);
        }
        getServer().getPluginManager().registerEvents(new Events(this), this);
        PluginDescriptionFile pdfFile = this.getDescription();
        commands.add("camera");
        commands.add("cameramode");
        for (String commands : this.commands){
            getCommand(commands).setExecutor(new Commands(this));
        }
 
        getUpdater();
        getLogger().info(pdfFile.getName() + " v" + pdfFile.getVersion() + " has been enabled");
        if (biff != null) {
        @SuppressWarnings("unused")
        Updater updater = new Updater(this, 80542, getFile(), biff, true);
        }
    }

The "GetUpdater()" is a method of my own making. It was the first real method I ever made, so obviously, it was, and still is, highly suspect for being the cause behind the trouble. But I can't seem to find any way to alter it in a better suited fashion.
Here it is:​

Code:java

 
    public UpdateType getUpdater(){
        if (getConfig().getBoolean("CameraMode.Updates.AutoUpdate") == true){
            bifff = Updater.UpdateType.DEFAULT;
        }else if (getConfig().getBoolean("CameraMode.Updates.NotifyOps") == true){
            bifff = Updater.UpdateType.NO_DOWNLOAD;
        }else{
            bifff = null;
        }
        return bifff;
    }

​

I will not just walk away from this issue and not include the updater.
I take this and my plugin seriously, and I want to know what is producing the problem, and how I can fix it, so I can prevent this from ever happening again.

These have been a long two months... And any advice you can offer would be appreciated.​

​

Thanks so much.​

xYourFreindx ​

​

​

 

Line 134 of events class is null.

Code:java

 if (updater.getResult().equals(UpdateResult.UPDATE_AVAILABLE)) {

is returning null. Probably from updader.getResult()

 

The Fancy Whale
It could be. Which is why I thought that the updater class may not have been initialized correctly in my main class.

BASICALLY

I think there's something either wrong with my getUpdater() method, or the way it is retrieved. ​

​

Update....
I have completely removed the getUpdater() method from the main class and replaced it with something simpler in the onEnable. ​

Code:java

 
        if (getConfig().getBoolean("CameraMode.Updates.AutoUpdate") == true){
            Updater updater = new Updater(this, 80542, getFile(), Updater.UpdateType.DEFAULT, true);
        }else if (getConfig().getBoolean("CameraMode.Updates.NotifyOps") == true){
            Updater updater = new Updater(this, 80542, getFile(), Updater.UpdateType.NO_DOWNLOAD, true);
        }else;

And fiddled with the onPlayerjoin a bit, producing...​

Code:java

Updater updater;
public Events(Updater plugin){
    this.updater = plugin;
}
 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent e){
        if ((main.getConfig().getBoolean("CameraMode.Updates.NotifyOps") == true)) {
            if (updater.getResult().toString().equals("UPDATE_AVAILABLE")) {
                if (updater.getLatestType().toString().equalsIgnoreCase("release")) {
                    if (e.getPlayer().hasPermission("cameramode.update")){
                        e.getPlayer().sendMessage(ChatColor.DARK_AQUA + "CameraMode: " + ChatColor.AQUA + "New Update Available!");
                        e.getPlayer().sendMessage(ChatColor.GRAY + updater.getLatestFileLink().toString());
                    }
                }
            }
        }
    }

But NOTHING I do seems to have any effect.
I'm STILL getting the exact same result whenever I join the server.​

​

I'm really at a loss...
Please... ​

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

xYourFreindx you have two constructors in Events, obviously only one will be used in the initialization of the object. In your code you only use the plugin one, which leaves the updater null, causing the NPE.

First create an Updater instance like you do in the end of onEnable(). Then create the Events object using a new constructor taking both a plugin instance and an Updater instance, and initialize the Events fields accordingly.

 

fireblast709
If I understand you correctly, what you're saying is that this:

Code:java

 
public Events(CameraMode plugin){
this.main = plugin;
}
public Events(Updater plugin){
this.updater = plugin;
}

Is bad.

I don't know how I would even begin to go about making a constructor for two classes. Could you give me an example?
Also....
If I am still understanding you right...
I'm going to need to do this:

Code:java

 
getLogger().info(pdfFile.getName() + " v" + pdfFile.getVersion() + " has been enabled");
if (getConfig().getBoolean("CameraMode.Updates.AutoUpdate") == true){
Updater updater = new Updater(this, 80542, getFile(), Updater.UpdateType.DEFAULT, true);
}else if (getConfig().getBoolean("CameraMode.Updates.NotifyOps") == true){
Updater updater = new Updater(this, 80542, getFile(), Updater.UpdateType.NO_DOWNLOAD, true);
}else;
 

in my events class as well. Would that go in this "double" constructor? Or would it replace the "Updater updater;" ?

And thank you... You've already been more help to me in the past two minutes, than anyone else has been in the past two months.

 

xYourFreindx it's not bad, it simply doesn't work.

Code:

public Events(CameraMode plugin, Updater updater){
    this.main = plugin;
    this.updater = updater;
}

this does work. Also you need to define the Updater instance outside the if-else scope

Code:

Updater updater;
if(...)
{
    updater = ...;
}
else
{
    updater = ...
}

 

fireblast709 I need the else if statements in order to correctly initiate the updater class, as defined by the settings in the config.
I don't know what you want me to do, but I can't (obviously) have an else if statement hanging out in the open, outside a method.
So what do you suggest?

 

xYourFreindx as I showed, you define the Updater in the method scope do you can use it later on. You can insert as many 'else if', as long as the 'Updater updater' stays outside the if...else if...else block

 

Here is what I've produced... ​

Code:

public class Events implements Listener {
 
    CameraMode main;
    Updater updater;
   
    public int ID;
    String reason = "You are in CameraMode!";
 
    public Events(CameraMode plugin, Updater updater){
        this.main = plugin;
 
        if (main.getConfig().getBoolean("CameraMode.Updates.AutoUpdate") == true){
            this.updater = new Updater(main, 80542, getFile(), Updater.UpdateType.DEFAULT, true);
        }else if (main.getConfig().getBoolean("CameraMode.Updates.NotifyOps") == true){
            this.updater = new Updater(main, 80542, getFile(), Updater.UpdateType.NO_DOWNLOAD, true);
        }
    }

But "getFile()" is highlighted in red.
getFile is how the updater can tell what file to replace with the new update. And can only be accessed in the main class.

Also. In my onEnable, where I register my events, it is now highlighted in red, saying that "Events(CameraMode is not defined". ​

fireblast709 Forgot to tag you.
Thank you so much for your patience.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

xYourFreindx i would create the Updater instance in the main class, then pass it to Events through the constructor

Code:

Updater updater;
if(main.getConfig().getBoolean("CameraMode.Updates.AutoUpdate") == true)
{
    updater = new Updater(main, 80542, getFile(), Updater.UpdateType.DEFAULT, true);
}
else if (main.getConfig().getBoolean("CameraMode.Updates.NotifyOps") == true)
{
    updater = new Updater(main, 80542, getFile(), Updater.UpdateType.NO_DOWNLOAD, true);
}
Events events = new Events(this, updater);

 

​

Thanks to the invaluable help of fireblast709 , I've come up with a solution to all my problems.
I've set it up so that the main class does all the updater work, and instead of getting the information from the updater itself, the event class will instead take the info from an arrayList, in which the main class has stored the info telling the playerjoin event what it should do.

Main:​

Code:

    public ArrayList<String> updates = new ArrayList<String>();
   
    //###### - Objects - ######//
   
 
    String reason = "You are in CameraMode!";
 
 
    public ArrayList<String> commands = new ArrayList<String>();
   
   
    //############################//
    //#########- Start - #########//
    //############################//
   
    @SuppressWarnings("unused")
    public void onEnable() {
        getConfig().options().copyHeader(true);
        getConfig().options().copyDefaults(true);
        saveConfig();
        if (getConfig().getBoolean("CameraMode.Enabled") == false) {
            getLogger().info("Plugin Disable Setting Detected...");
            getServer().getPluginManager().disablePlugin(this);
        }
        getServer().getPluginManager().registerEvents(new Events(this), this);
        PluginDescriptionFile pdfFile = this.getDescription();
        commands.add("camera");
        commands.add("cameramode");
        for (String commands : this.commands){
            getCommand(commands).setExecutor(new Commands(this));
        }
        getLogger().info(pdfFile.getName() + " v" + pdfFile.getVersion() + " has been enabled");
        if (getConfig().getBoolean("CameraMode.Updates.AutoUpdate") == true){
            Updater updater = new Updater(this, 80542, getFile(), Updater.UpdateType.DEFAULT, true);
        }else if (getConfig().getBoolean("CameraMode.Updates.NotifyOps") == true){
            Updater updater = new Updater(this, 80542, getFile(), Updater.UpdateType.NO_DOWNLOAD, true);
            if (updater.getResult().equals(Updater.UpdateResult.UPDATE_AVAILABLE) && updater.getLatestType().toString().equalsIgnoreCase("release")) {
                updates.add(updater.getLatestFileLink().toString());
            }
        }else{
        }
    }
    public void onDisable(){
        reloadConfig();
        PluginDescriptionFile pdfFile = this.getDescription();
        getLogger().info(pdfFile.getName() + " v" + pdfFile.getVersion() + " has been disabled");
        updates.clear();
    }

PlayerJoinEvent​

Code:java

 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent e){
        if (main.getConfig().getBoolean("CameraMode.Updates.NotifyOps") == true) {
            if (!(main.updates.isEmpty())) {
                if (e.getPlayer().hasPermission("cameramode.update")){
                    e.getPlayer().sendMessage(ChatColor.DARK_AQUA + "CameraMode: " + ChatColor.AQUA + "New Update Available!");
                    e.getPlayer().sendMessage(ChatColor.GRAY + main.updates.get(0));
                }
            }
        }
    }

As you can see, the playerjoinevent no longer has to interact with the updater class in any way, concentrating everything to one area, and limiting the amount of code necessary.

Thanks again to all who've assisted me in this two month long process.
I'm glad it's over. ​

​