Solved PlayerDropItemEvent Bugging? Or..

Well I have this..:
public void onDrop(PlayerDropItemEvent e) {
if(this.isRandomizeEnabled(e.getPlayer())) {
e.getPlayer().sendMessage(this.title + "You cannot modify your inventory while Randomize is enabled!");
e.setCancelled(true);
}
}
It won't cancel the item drop if you press 'Q' in your hotbar, any ideaS?

 

Pizza371
Did you register your events? Do you have @EventHandler above your method?

 

Minecrell I didn't explain myself well enough:
It does call, I do get the message, but only when i do it with the Inventory GUI open, but when I press 'Q' on the hotbar, it doesnt work

 

Pizza371
Do you get the message if you press 'Q' on the hotbar (or only in the inventory)?

 

Minecrell nothing gets executed when I press Q

 

Pizza371
Maybe isRandomizeEnabled() will return false after you close the inventory? (I don't know where you set it)

 

Code:

@EventHandler
public void onDrop(PlayerDropItemEvent e) {
          e.getPlayer().sendMessage("I work");
}

If that code ^ doesn't work then you probably aren't registering the event(
onEnable() --> "getServer().getPluginManager.registerEvents(<Listener>, this);")

, if it does, then the "if(this.isRandomizeEnabled(e.getPlayer()))" is returning false for whatever reason

 

Dread9Nought: It does work but only when I open my inventory and drag stuff out
Minecrell
private boolean isRandomizeEnabled(Player p) {
if(this.randomizeEnabled.contains(p.getName())) return true;
return false;
}
it just an easy way of getting whether a player is in a list.. cuz.. im lazy

 

Pizza371
Where do you add them to the list?

 

Minecrell

Code:java

private void toggleRandomizer(Player p) {
        if(this.isRandomizeEnabled(p)) {
            p.sendMessage(this.title + "Randomize toggled [" + ChatColor.DARK_RED + "OFF" + ChatColor.WHITE + "]");
            this.randomizeEnabled.remove(p.getName()); //remove
            if(this.armourcontents.containsKey(p.getName())) {
            p.getInventory().setArmorContents(this.armourcontents.get(p.getName()));
            this.armourcontents.remove(p.getName());
            }
        } else {
            p.sendMessage(this.title + "Randomize toggled [" + ChatColor.GREEN + "ON" + ChatColor.WHITE + "]");
            this.randomizeEnabled.add(p.getName()); //add
            this.armourcontents.put(p.getName(), p.getInventory().getArmorContents());
        }
    }[/syntax=java]

 

Pizza371
What happens if you remove the if clause and always send a message like this:

Code:java

@EventHandler
public void onPlayerDropItem(PlayerDropItemEvent event) {
    event.getPlayer().sendMessage(ChatColor.GREEN + "You've dropped an item!");
}

Will you get the message when using 'Q' on the hotbar then?

 

You can still drop items with 'Q' with
public void onDrop(PlayerDropItemEvent e) {
e.setCancelled(true);
}
Minecrell

 

Pizza371
Tested it myself, and it's working for me... Can you post your complete class? Do you have any other plugins installed on the server?

 

Minecrell

Code:java

package me.nalo.randomizeme;
 
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Random;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.player.PlayerDropItemEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
    private final List<String> randomizeEnabled = new ArrayList<String>();
    private final HashMap<String, ItemStack[]> armourcontents = new HashMap<String, ItemStack[]>();
    private final Material[] leggings = new Material[] {
            Material.DIAMOND_LEGGINGS, Material.IRON_LEGGINGS, Material.IRON_LEGGINGS, Material.GOLD_LEGGINGS
    };
    private final Material[] chestplates = new Material[] {
            Material.DIAMOND_CHESTPLATE, Material.IRON_CHESTPLATE, Material.LEATHER_CHESTPLATE, Material.GOLD_CHESTPLATE
    };
    private final Material[] boots = new Material[] {
            Material.DIAMOND_BOOTS, Material.IRON_BOOTS, Material.LEATHER_BOOTS, Material.GOLD_BOOTS
    };
    private final String title = "[" + ChatColor.AQUA + "RandomizeMe" + ChatColor.WHITE + "] ";
    @Override
    public void onEnable() {   
        getServer().getPluginManager().registerEvents(this, this);
        startRandomizePlayersSchedular();
    }
    @Override
    public void onDisable() {
        safeDisable();
    }
    private void startRandomizePlayersSchedular() {
        Bukkit.getScheduler().runTaskTimerAsynchronously(this, new Runnable() {
            Random rdm = new Random();
            int length = Material.values().length;
            @Override
            public void run() {   
                for(Player p : Bukkit.getOnlinePlayers()) {
                    if(isRandomizeEnabled(p)) {
                        p.getInventory().setHelmet(new ItemStack(Material.values()[rdm.nextInt(length)]));
                        p.getInventory().setChestplate(new ItemStack(chestplates[rdm.nextInt(chestplates.length)]));
                        p.getInventory().setLeggings(new ItemStack(leggings[rdm.nextInt(leggings.length)]));
                        p.getInventory().setBoots(new ItemStack(boots[rdm.nextInt(boots.length)]));
                    }
                }
            }
        }, 0L, 5L);
    }
    private void safeDisable() {
        for(Player p : Bukkit.getOnlinePlayers()) {
            if(this.isRandomizeEnabled(p)) {
                toggleRandomizer(p);
            }
        }
    }
    private void toggleRandomizer(Player p) {
        if(this.isRandomizeEnabled(p)) {
            p.sendMessage(this.title + "Randomize toggled [" + ChatColor.DARK_RED + "OFF" + ChatColor.WHITE + "]");
            this.randomizeEnabled.remove(p.getName());
            if(this.armourcontents.containsKey(p.getName())) {
            p.getInventory().setArmorContents(this.armourcontents.get(p.getName()));
            this.armourcontents.remove(p.getName());
            }
        } else {
            p.sendMessage(this.title + "Randomize toggled [" + ChatColor.GREEN + "ON" + ChatColor.WHITE + "]");
            this.randomizeEnabled.add(p.getName());
            this.armourcontents.put(p.getName(), p.getInventory().getArmorContents());
        }
    }
    private boolean isRandomizeEnabled(Player p) {
        if(this.randomizeEnabled.contains(p.getName())) return true;
        return false;
    }
    public boolean onCommand(CommandSender s, Command cmd, String cmdname, String[] args) {
        if(cmdname.equalsIgnoreCase("randomizeme")) {
            if(!(s instanceof Player)) return true;
            Player p = (Player) s;
            if(p.hasPermission("RandomizeMe.use") || p.isOp()) {
            this.toggleRandomizer(p);
            } else {
                p.sendMessage(this.title + "No permission!");
            }
        }
        return false;
    }
    @EventHandler
    public void onLeave(PlayerQuitEvent e) {
        if(this.isRandomizeEnabled(e.getPlayer())) this.toggleRandomizer(e.getPlayer());
    }
    @EventHandler
    public void onClick(InventoryClickEvent e) {
        if(this.isRandomizeEnabled((Player)e.getWhoClicked())) {
            ((Player)e.getWhoClicked()).sendMessage(this.title + "You cannot modify your inventory while Randomize is enabled!");
            e.setCancelled(true);
        }
    }
    public void onDrop(PlayerDropItemEvent e) {
        e.setCancelled(true);
    }
}

it's proably a stupid mistake then knowing me :c

 

Pizza371
The second one (onDrop) doesn't have the @EventHandler annotation.

 

Minecrell *epic facepalm* sorry
I thought it was working because of the onClick method above it (when I dragged it out it must've lagged and went back as if onDrop cought it, thanks!..
:L..