PlayerDeathEvent

I'm using a PlayerDeathEvent to determine if the killer is a player, and if so, send a message; which works sorta OK.

The problem is, however, when I hit the player, and a zombie hits the player and gets the kill, it still sends the killed a message that he died by me, which it shouldn't since it died by the zombie, right?

I checked if the killer is an instanceof Player, but it ignores that when I hit the player once, then a zombie gets the kill.

Is there anything I can do to work around this?

Code:java

    @EventHandler
    public void onPlayerDeath(PlayerDeathEvent e) {
        Player p = (Player) e.getEntity();
        if (e.getEntity().getKiller() instanceof Player) {
            p.sendMessage(ChatColor.translateAlternateColorCodes('&', Main.plugin.getConfig()
                    .getString("Settings.DeathMessage")));
        }
    }

 

Move Player p = etc... inside of your if block. I don't think that's what's causing your issue, but there's no need to create that bit of data if you aren't going to use it.

 

ZanderMan9
Doesn't matter, just a preference.

 

I suppose if you are going to add onto this, then yes. Maybe there is another method besides getKiller that you need to use? It might default to the player that attacked it...

 

If you look at the javadocs, getKiller() returns player.

 

unrealdesign
Yes, and if a zombie killed it, it should return null, right? But it's not, it's still returning as if a player killed the player, but the zombie killed the player.

 

No? Think about it. If you made the code, you would set the killer to the last person that hit the player. Since getKiller() is not part of the event, it's part of a player instance. The only time the killer would be null is if a player never hit that player, or maybe if he reconnects after being hit, I'm not sure about that part. So to re-iterate: since it isn't part of the event and can't change every time a player gets hit, it just stays with the Player to hit that player. At least, this is how I'm interpreting the code without actually going through it.

 

You could use the EntityDamageByEntityEvent.

Code:java

public void onEntityDamageByEntity(EntityDamageByEntityEvent e)
{
 
    /** Doesn't do anything if either entities aren't players. **/
    if(!(e.getEntity() instanceof Player) && !(e.getDamager() instanceof Player))
        return;
 
    Player p = (Player) e.getEntity();
    Player damager = (Player) e.getDamager();
 
    /** getHealth() is ambigious, using Damageable fixes that. **/
    Damageable d = (Damageable) p;
 
    /** If the player dies, again note that this code only works if an entity (player) damaged the target. **/
    if(d.getHealth() - e.getDamage() <= 0)
    {
        p.sendMessage(ChatColor.translateAlternateColorCodes('&', Main.pl.getString("Settings.DeathMessage")));
    }
 
}

 

3Shawnster
To fix the ambigious health, you should be building against Bukkit; building against Craftbukkit is not endorsed and is not recommended.

 

unrealdesign Is correct it would find the player that last killed him

 

Javadocs doesn't say and I've not tested it. Could bet last Player hit, or yes, last player killer.

 

HeadGam3z
You can do

Code:java

e.getPlayer().getLastDamageCause().getEntity()

and that will give you a more accurate answer.