Player Interact Stops Working?

Well, yesterday I was just playing around with spawnFallintBlock(), though today I've realized I can only use the sword once, then the plugin needs to be reloaded. Put some debug messages in, but it seems that it isn't creating the runnable again?

Code:

Code:java

package com.excomm.test;
 
import java.util.Arrays;
import java.util.List;
import java.util.Random;
 
import org.bukkit.ChatColor;
import org.bukkit.DyeColor;
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.entity.FallingBlock;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.entity.EntityChangeBlockEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.scheduler.BukkitRunnable;
import org.bukkit.scheduler.BukkitTask;
import org.bukkit.util.Vector;
 
public class Handler implements Listener {
 
    Random r = new Random();
 
    List<DyeColor> colors = Arrays.asList(DyeColor.RED, DyeColor.ORANGE, DyeColor.YELLOW, DyeColor.GREEN, DyeColor.BLUE, DyeColor.LIGHT_BLUE, DyeColor.PINK, DyeColor.MAGENTA, DyeColor.LIME, DyeColor.CYAN, DyeColor.PURPLE, DyeColor.BLACK, DyeColor.WHITE);
    DyeColor color = colors.get(r.nextInt(colors.size()));
 
    static int time = 6;
    static BukkitTask task;
 
    @EventHandler
    public void onClick(final PlayerInteractEvent e) {
        final Player p = e.getPlayer();
        final Block block = e.getClickedBlock();
        if(!(e.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
            if(!(e.getItem().getType() == Material.GOLD_SWORD)) return;
            p.sendMessage(ChatColor.GREEN + "You started a wool rain! (5 seconds)");
                task = new BukkitRunnable() {
                    public void run() {
                        time--;
                        if(time == 5 || time == 4 || time == 3 || time == 2 || time == 1) {
                            p.sendMessage(ChatColor.YELLOW + "Wool rain ends in " + time + "!");
                            FallingBlock block1 = block.getWorld().spawnFallingBlock(block.getLocation(), Material.WOOL, color.getWoolData());
                            float x = (float) 0 + (float) (((0 - 0) + 0));
                            double y = 2.4;
                            float z = (float) 0 + (float) (((0 - 0) + 0));
                            block1.setVelocity(new Vector(x, y, z));
                        } else if(time == 0) {
                            p.sendMessage(ChatColor.RED + "Wool rain has eneded.");
                            task.cancel();
                        }
                    }
                }.runTaskTimer(Main.getInstance(),20L,20L);
    }
    @EventHandler
    public void onBlockFall(EntityChangeBlockEvent e) {
        if(e.getEntity() instanceof FallingBlock) {
            e.getBlock().setType(Material.AIR);
            e.getBlock().breakNaturally();
            e.setCancelled(true);
        }
    }
}

Thanks,
Wes

 

WesJD
Probably because the time variable is outside of the method, and thus on first run it will increment it all the way down to 0 and never work again because of your if checks.

 

Assist Explain a bit more please? I'm not understanding.

 

WesJD
Sorry I don't have time to explain very well right now. You have the time variable there set to 6 (seconds). When the runnable runs the first time, it will increment the integer by 1 every time until it's 0, which is when you cancel the task. Now this will stay at 0 forever until you set it equal to something again. You should place the time variable inside the method so a new one will be created each time the event runs rather than using the same old one. You should also do this with the random dye thing.

Also. What in the world is this madness?

Code:

float x = (float) 0 + (float) (((0 - 0) + 0));

 

Assist

Had it there from testing, never removed it.

EDIT:

Got it working, thanks!