player.getLocation Problem

Hi @all,

I want to make a Teleportation Command but when a the Player Move in 5 sec to abort the Teleportation. My Problem is that i don't get the right Location from the Player.

There is some of my Code

Code:

long startet = System.currentTimeMillis();
long now = System.currentTimeMillis();
long end = startet + 5000;

Integer x = player.getLocation().getBlockX();
Location startLocation = player.getLocation();

while ( now < end ) {
	now = System.currentTimeMillis();
}

if ( startLocation.getBlockX() == player.getLocation().getBlockX() &&
	 startLocation.getBlockY() == player.getLocation().getBlockY() &&
	 startLocation.getBlockZ() == player.getLocation().getBlockZ() ) {

	if ( clan.getClanSpawnX() != 0 && clan.getClanSpawnZ() != 0 ) {
		player.teleport( clan.getClanSpawnLocation() );
	} else {
		player.teleport( new Location( plugin.getServer().getWorld("world") , clan.getBaseX() -2, clan.getBaseY(), clan.getBaseZ() ) );
	}

} else {
	player.sendMessage(ChatColor.GOLD + "Teleporierung abgebrochen, du hast dich bewegt.");
}

How i can get the right Location from the Player now? With plugin.getServer().getPlayer( player.getName() ).getLocation() i become the same Location. But not the New Location.

Any Idea? Thanks

 

You are not allowed to freeze the main thread!
Use a syncDelayedTask to wait 20*5 ticks ( = 5 secs). More information: http://wiki.bukkit.org/Scheduler_Programming

In this task itself you grab the location of the player like you told:

 

Ah thanks, i look how i can do this. First Time to work with Task. How i can give this Task some Variables?

 

If you have a new class (implementing Runnable) you can give references in the constructor, like this:

Code:java

public class MyTask implements Runnable
{
  private final String playerName;
  private final Server server;
 
  public MyTask(String playerName, Server server)
  {
    this.playerName = playerName;
    this.server = server;
  }
 
  public void run()
  {
    Player player = server.getPlayerExact(playerName);
    //Do stuff with the player here...
  }
}

 

Thanks, the Timer Works, but i become the wrong Location from the Server.

Code:

plugin.getServer().getScheduler().scheduleSyncDelayedTask( plugin, new ClanSpawnTask(plugin, clan, player), 100L);

Code:

package ch.nonameweb.bukkit.plugins.minepvp.tasks;

import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.entity.Player;

import ch.nonameweb.bukkit.plugins.minepvp.Clan;
import ch.nonameweb.bukkit.plugins.minepvp.MinePvP;

public class ClanSpawnTask implements Runnable {
	private MinePvP plugin;
	private Clan clan;
	private Player player;
	public ClanSpawnTask( MinePvP plugin, Clan clan, Player player ) {
		this.plugin = plugin;
		this.clan = clan;
		this.player = player;
	}
	@Override
	public void run() {
		player.sendMessage("X : " + player.getLocation().getBlockX() + " Y : " + player.getLocation().getBlockY() + " Z : " + player.getLocation().getBlockZ() );
		player.sendMessage("X : " + plugin.getServer().getPlayer(player.getName()).getLocation().getBlockX() + " Y : " + plugin.getServer().getPlayer(player.getName()).getLocation().getBlockY() + " Z : " + plugin.getServer().getPlayer(player.getName()).getLocation().getBlockZ() );
		if ( player.getLocation().equals( plugin.getServer().getPlayer( player.getName() ).getLocation() ) ) {
			if ( clan.getClanSpawnX() != 0 && clan.getClanSpawnZ() != 0 ) {
				player.teleport( clan.getClanSpawnLocation() );
			} else {
				player.teleport( new Location( plugin.getServer().getWorld("world") , clan.getBaseX() -2, clan.getBaseY(), clan.getBaseZ() ) );
			}
		} else {
			player.sendMessage(ChatColor.GOLD + "Teleporierung abgebrochen, du hast dich bewegt.");
		}
	}

}

player.getLocation().getBlockX() and plugin.getServer().getPlayer(player.getName()).getLocation().getBlockX() get the same X Coordinate. And this is the Location wo i Start the Command.

Any idea?

How you make this nice Black Code Style?

Sorry, it works now i save the Last Position in X Y Z.

Thank you. Thread Close

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

//EDIT: Old post:

Show Spoiler Hide Spoiler

Code:java

package ch.nonameweb.bukkit.plugins.minepvp.tasks;
 
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.entity.Player;
 
import ch.nonameweb.bukkit.plugins.minepvp.Clan;
import ch.nonameweb.bukkit.plugins.minepvp.MinePvP;
 
public class ClanSpawnTask implements Runnable {
	private MinePvP plugin;
	private Clan clan;
	private String playerName; // A lot of things can happen in 100 ticks: The user can log off for example, so we only store it's name!
private Location loc; // Here we store the location the player is at when executing the command.
	public ClanSpawnTask( MinePvP plugin, Clan clan, String playerName, Location loc ) { // Don't forget that the constructor changed!
		this.plugin = plugin;
		this.clan = clan;
		this.playerName = playerName;
this.loc = loc;
	}
public void run() {
Player player = plugin.getServer().getPlayerExact(playerName);
if(player == null) // That's the case if the player is offline now.
  return;
		player.sendMessage("X : " + loc.getBlockX() + " Y : " + loc.getBlockY() + " Z : " + loc.getBlockZ() );
		player.sendMessage("X : " + player.getLocation().getBlockX() + " Y : " + player.getLocation().getBlockY() + " Z : " + player..getLocation().getBlockZ() );
		if ( player.getLocation().equals( loc ) ) {
			if ( clan.getClanSpawnX() != 0 && clan.getClanSpawnZ() != 0 ) {
				player.teleport( clan.getClanSpawnLocation() );
			} else {
				player.teleport( new Location( loc.getWorld() , clan.getBaseX() -2, clan.getBaseY(), clan.getBaseZ() ) );
			}
		} else {
			player.sendMessage(ChatColor.GOLD + "Teleporierung abgebrochen, du hast dich bewegt.");
		}
	}
 
}
 

It could also be that loc.equals(anotherLoc) always returns true, in that case you'll have to check the worlds name, x, y and z manually:

Code:java

package ch.nonameweb.bukkit.plugins.minepvp.tasks;
 
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.entity.Player;
 
import ch.nonameweb.bukkit.plugins.minepvp.Clan;
import ch.nonameweb.bukkit.plugins.minepvp.MinePvP;
 
public class ClanSpawnTask implements Runnable {
private final MinePvP plugin;
private final Clan clan;
private final String playerName; // A lot of things can happen in 100 ticks: The user can log off for example, so we only store it's name!
private final String worldName;
private final int x;
private final int y;
private final int z;
public ClanSpawnTask( MinePvP plugin, Clan clan, String playerName, Location loc ) { // Don't forget that the constructor changed!
this.plugin = plugin;
this.clan = clan;
this.playerName = playerName;
this.worldName =loc.getWorld().getName();
this.x = loc.getBlockX();
this.y = loc.getBlockY();
this.z = loc.getBlockZ();
}
public void run() {
Player player = plugin.getServer().getPlayerExact(playerName);
if(player == null) // That's the case if the player is offline now.
  return;
player.sendMessage("X : " + x + " Y : " + y + " Z : " + z );
player.sendMessage("X : " + player.getLocation().getBlockX() + " Y : " + player.getLocation().getBlockY() + " Z : " + player..getLocation().getBlockZ() );
Location loc = player.getLocation();
if ( player.getWorld().getName().equals(worldName) && x == loc.getBlockX() && y == loc.getBlockY() && z == loc.getBlockZ()) {
if ( clan.getClanSpawnX() != 0 && clan.getClanSpawnZ() != 0 ) {
player.teleport( clan.getClanSpawnLocation() );
} else {
player.teleport( new Location( loc.getWorld() , clan.getBaseX() -2, clan.getBaseY(), clan.getBaseZ() ) );
}
} else {
player.sendMessage(ChatColor.GOLD + "Teleporierung abgebrochen, du hast dich bewegt.");
}
}
 
}
 

BTW: For java syntax highlighting:

Code:

[syntax=java]public void foo() {};[/syntax]

Fein das es nun werkelt / Good that it works now!

 

Hi Danke Hi Thanks....

How can i add a generatet Delay Time for the Task?

Code:java

 
Integer time = plugin.getConfig().getInt("Global.Settings.Attack.Time");
Integer delay = plugin.getConfig().getInt("Global.Settings.Attack.Delay");
 
time = ( time * 60 ) * 20;
delay = ( delay * 60 ) * 20;
delay = delay + time;
 
plugin.getServer().getScheduler().scheduleSyncDelayedTask( plugin, new StartAttackTask(plugin, clan.getName(), clan2.getName() ), delay + L);
 
plugin.getServer().getScheduler().scheduleSyncDelayedTask( plugin, new StopAttackTask(plugin, clan.getName(), clan2.getName() ), 20L);
 

And how can i Stop the Task after the Run?

Thank you.

 

First off: Sorry, I drunk a bit... I'll ignore the first question for now... ^^

You can't stop it after cause it has already executed and doesn't exist anymore... But if you start a task it returns a int - this int is a pid (process ID) - If you want to stop the task before it executes:
getServer().getScheduler().cancelTask(pid);
of course you have to store the pid somewhere...

BTW: I don't mean that in a bad way, but your grammar shows that you speak german (and your code shows that it's "schwitzerdütsch"?)...

 

@V10lator : Thans, and yes im from Switzerland And my English is really bad

 

As long as you don't had the nick "kill0r" (or something similar, don't remember atm) everything is okay. BTW: I'm from Bavaria.
But let's go back to topic...

 

Yes back to Topic

Okey, than i make a Scheduler close from Time to Time the old Tasks.

Back to first Question.

Now i make this to Start a Scheduler....

Code:java

plugin.getServer().getScheduler().scheduleSyncDelayedTask( plugin, new StartAttackTask(plugin, clan.getName(), clan2.getName() ), 1000L);

but i want to replace the 1000L to a Variable.

 

Then do this:

Code:java

 
long time = 500L;
plugin.getServer().getScheduler().scheduleSyncDelayedTask( plugin, new StartAttackTask(plugin, clan.getName(), clan2.getName() ), time);

 

Thanks it works.