Perhaps Im using .canbreed() wrong?

Im attempting to make it so Farm animals have a chance to 'breed' extra animals when you breed them.

I got it all working well, by just 'spawning' a baby next to the animal with a random chance when clicking with wheat...

but I have 2 issues. the one mentioned in the topic is the biggest.
The issue is they can just spam wheat on the animal until out to get a "CRAPLOAD of babies"

Im checking if the animal is an adult and if it can breed, I was assuming 'canbreed' means it has the ability to get the hearts over it head, and would return false if it just breeded recently...

here is my logic:

Code:java

 
if ((e instanceof Cow || e instanceof Pig || e instanceof Sheep || e instanceof Chicken) && ((Animals)e).isAdult() && ((Animals)e).canBreed()){
 

am i using .canBreed() incorrectly by assuming it does a true/false in a different way?

also the other problem if anyone has a quick fix, is sheep 'babies' im spawning are not the color of the parent, they are all white. Anyone know a way to pull the color of the sheep clicked with wheat, and set it to my:

Code:java

 
LivingEntity ANI = wor.spawnCreature(locentity, b);
((Animals) ANI).setBaby();
 

I can do an extra if to catch if its a sheep, and then apply color to it if needed, just not sure how to grab the color of the 'parent' sheep.

 

Try adding a true in the parentheses for the canBreed().

 

For your first problem, I'd suggest a timer that sets a minimum delay between spawns. Something like:

Code:Java

 
// This goes in your class as a private variable
private static Map<Animal, Boolean> canSpawnBaby = new HashMap<Animal, Boolean>();
 
// This goes in your method that determines if the baby should spawn
if (e instanceof Cow || *snip*) {
    final Animal animal = (Animal)e;
 
    if (animal.isAdult() && animal.canBreed()) {
        if (!canSpawnBaby.containsKey(animal))
            canSpawnBaby.put(animal, true);
 
        if (canSpawnBaby.get(animal)) {
            LivingEntity baby  = ((Animal)wor.spawnCreature(locentity, b)).setBaby();
            canSpawnBaby.put(animal, false);
        } else {
            Runnable task = new Runnable() {
                public void run() {
                    if (canSpawnBaby.containsKey(animal))
                        canSpawnBaby.put(animal, true);
                }
            };
 
            Bukkit.getScheduler().scheduleAsyncDelayedTask(<your-plugin-instance>, task, <desired-delay>);
        }
    }
}
 

As for the second, I've never tried this, but it might work. Add the CraftBukkit jar file as a library for your project, and use this immediately after the line "LivingEntity baby = ((Animal)wor.spawnCreature(...).setBaby();":

Code:Java

 
if (baby instanceof CraftSheep && animal instanceof CraftSheep) {
    ((CraftSheep)baby).setColor(((CraftSheep)animal).getColor());
}
 

I got that from the Bukkit page on GitHub for the CraftBukkit implementation of Sheep. You can find it here.

That wouldn't do anything, canBreed() doesn't accept parameters, just take a look at the JavaDoc page.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

AH yea, tried the (true) it didnt like that.
didn't think of a task to delay breeding why I was trying the "canbreed' using it as a logic to see if they can get extras..so it didn't spam them, as after it bred, it wouldn't work...but they could spam it with wheat UNTIL it bred (while it had hearts over its head) to get lots of them

and that's a lot shorter than the path I was trying of, I dug all through the javadoc, dont know how i missed it before for .getcolor :\

Code:java

 
                        if (e instanceof Sheep) {
                            Colorable ASheep = (Colorable) e;
                            DyeColor c = ASheep.getColor();
                            Sheep bSheep;
                            bSheep = (Sheep)ANI;
                            bSheep.setColor(c);
                        }
 

Thanks a ton guys, think I got it from here.

 

Ahaha I missed that bit in the JavaDoc I jumped to the more complicated fix, I gotta work on not doing that lol

Anyway, happy to help Good luck!

 

Me too Lart, Ill fight with something for an hour, making some complicated rube goldberg like coding to do something. To realize later, while looking for something else "oh crap there is a .something(); I could have just called on..."

 

Yup yup, most programmers I know are like that We get so fixated on solving something in this ingenious way, we don't take the time to realize it was already done hahaha