Solved onPlayerInteract(PlayerInteractEvent event)

Hello, each time a player left clicks with an empty hand I get a NullPointerException at line 5
this does not happen on leftclicks with a item or block in their hand and rightclicks are fine aswell

Code:java

 @EventHandler
public void onPlayerInterract(PlayerInteractEvent event) {
ItemStack is = event.getItem();
Player p = event.getPlayer();
String name = is.getItemMeta().getDisplayName();
 
if (p.getItemInHand().getType() == Material.AIR
|| p.getItemInHand() == null) {
return;
}
if (!(p.getItemInHand().hasItemMeta() && p.getItemInHand()
.getItemMeta().hasDisplayName())) {
return;
}
if (name.equalsIgnoreCase(ChatColor.RED + "Choose a Class")
&& event.getAction() == Action.RIGHT_CLICK_AIR) {
classGUI(event.getPlayer());
} else {
return;
}
}

 

Thats because the item doesn't have item meta. You need to test this at first:

Code:Java

 
if (is.hasItemMeta()) {
 

 

This is not working

Code:java

@EventHandler
public void onPlayerInterract(PlayerInteractEvent event) {
ItemStack is = event.getItem();
Player p = event.getPlayer();
 
if (is.hasItemMeta()) {
String name = is.getItemMeta().getDisplayName();
 
if (p.getItemInHand().getType() == Material.AIR
|| p.getItemInHand() == null) {
return;
}
if (!(p.getItemInHand().hasItemMeta() && p.getItemInHand()
.getItemMeta().hasDisplayName())) {
return;
}
if (name.equalsIgnoreCase(ChatColor.RED + "Choose a Class")
&& event.getAction() == Action.RIGHT_CLICK_AIR) {
classGUI(event.getPlayer());
} else {
return;
}
}
}

 

Try declaring Player p = event.getPlayer() before the itemstack then for the itemstack use

ItemStack is = p.getInventory().getItemInHand();

 

61352151511 How would that help?

Pixwarron What if they don't have an item in their hand?

 

I'm not sure :/ That's the way I normally do it and when I put that in eclipse I didn't get any errors, didn't think about him checking to see if there was an item in the hand or not.

 

Check if the item in the player's hand is null before checking if it's type is air and before getting it's display name. By the way, instead of continuously invoking p.getItemInHand(), just use the variable is you created. You could also use p instead of event.getPlayer() on line 17.

FisheyLP ItemStack#getItemMeta() only returns null when the item's type is air. There is no real need to ItemStack#hasItemMeta() in my opinion.

 

Something is really wrong with the code.
Check if item is not air and has item meta and display name first.

 

Pixwarron
The issue has nothing to do with null item-meta. The displayname is null (i.e default item name = null displayname). You need a null check on the displayname. While a null-check on itemmeta is ok, it's unwarranted in my opinion, to reiterate what Traks said.

 

Code:java

if(!p.getItemInHand().hasItemMeta()) return;
if(p.getItemInHand().getType() == Material.AIR){
 
}

Start off with that.

Also, to check for a specific display name, you have to have a .getDisplayName()

e.g.

Code:java

if(p.getItemInHand().getDisplayName().contains("Kit Selector"){
 
 
//code
 
}

 

Thank you very much, I cleaned up the code and this is the final product

Code:java

        if (!(p.getItemInHand().hasItemMeta()))
            return;
        if (p.getItemInHand().getType() == Material.AIR)
            return;
        String name = is.getItemMeta().getDisplayName();
        if (name.equalsIgnoreCase(ChatColor.RED + "Choose a Class")
                && event.getAction() == Action.RIGHT_CLICK_AIR) {
            classGUI(event.getPlayer());
        } else {
            return;
        }
 
    }

 

Add some comments of your own in your code, so you can look back at a later date if needed.