NullpointerException with Vault

Hi guys I get following error by clicking a sign:

Show Spoiler Hide Spoiler

[16:27:05] [Server thread/ERROR]: Could not pass event PlayerInteractEvent to EnchantSigns v1.0
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427) ~[craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:481) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:466) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:191) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.PlayerInteractManager.interact(PlayerInteractManager.java:374) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java:628) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.PacketPlayInBlockPlace.a(SourceFile:60) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.PacketPlayInBlockPlace.handle(SourceFile:9) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:146) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:655) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:250) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:545) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:457) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
Caused by: java.lang.NullPointerException
at de.schegar.enchantsigns.Signs.onClick(Signs.java:112) ~[?:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_21]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_21]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_21]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_21]
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425) ~[craftbukkit-1.7.2-R0.2.jar:git-Bukkit-1.7.2-R0.2-b2974jnks]
... 15 more

here's my concerned method:

Show Spoiler Hide Spoiler

Code:java

@EventHandler
    public void onClick(PlayerInteractEvent e) {       
        if(e.getAction() == Action.RIGHT_CLICK_BLOCK || e.getAction() == Action.LEFT_CLICK_BLOCK) {
            Player p = e.getPlayer();
            BlockState bs = e.getClickedBlock().getState();
            if (bs instanceof Sign) {
                Sign sign = (Sign) bs;
                signCheck(sign.getLine(0));
                if (SignCheck == true) {
                    if (e.getPlayer().hasPermission("es.use")) {
                        String EnchantmentType = sign.getLine(0);
                          Integer level = Integer.valueOf(sign.getLine(1));
                          String payment = sign.getLine(2);                         
                        if (p.getItemInHand().getType() == Material.AIR || p.getItemInHand() == null) {
                            p.sendMessage("Please select what you want to enchant");
                        } else {
                            if (payment.equalsIgnoreCase("Price:")) {
                                Double priceDouble = Double.valueOf(sign.getLine(3));
                                if (this.econ.has(p.getName(), priceDouble)) {
                                    this.econ.withdrawPlayer(p.getName(), priceDouble);
                                    enchant(EnchantmentType, p, level);
                                    p.sendMessage("Enchanted successfully!");
                                } else {
                                    p.sendMessage("$cYou don't have enough money");
                                }
                            } else if (payment.equalsIgnoreCase("Levels:")) {                           
                                Integer priceInt = Integer.valueOf(sign.getLine(3));
                                if (p.getLevel() >= priceInt) {
                                    p.setLevel(p.getLevel() - priceInt);
                                    enchant(EnchantmentType, p, level);
                                    p.sendMessage("Enchanted successfully!");
                                } else {
                                    p.sendMessage("§cYour level is too low");
                                }
                            }
                        }
                    }  else {
                        e.getPlayer().sendMessage("§cYou don't have the permission to use an EnchantSign");
                    }
                }                           
            }   
        }
    }

I get the error in line 19 while the plugin checks if the player has enough money to buy the enchantment.

I use the latest vault version and 1.7.2 beta version of bukkit.

Thanks for your help
schegar

 

Can you give the code where you instantiate "econ"?

 

Code:java

private Economy econ;
    EnchantSigns plugin;
    Boolean SignCheck;
 
    public Signs(EnchantSigns plugin) {
        this.econ = plugin.economy;
        this.plugin = plugin;
        }

 

schegar
May I see the 'economy' variable in EnchantSigns class? Also, if you don't mind, also show the method you use to initialize it.

 

Code:java

public Economy economy = null;
 

Code:java

if (this.getConfig().getBoolean("Use Vault") == true) {
            this.setupEconomy();
        }

Code:java

private boolean setupEconomy() {
        RegisteredServiceProvider<Economy> economyProvider = getServer()
                .getServicesManager().getRegistration(
                        net.milkbowl.vault.economy.Economy.class);
        if (economyProvider != null) {
            economy = economyProvider.getProvider();
        }
 
        return (economy != null);
    }

 

You still have the possibility that economy is null, if economyProvider is null. That null value cascades through and when you access i:

Code:java

if (this.econ.has(p.getName(), priceDouble)) {

"econ" is still null. You can't do econ.has() on null. If your plugin is absolutely dependent on Vault and can't function without a Vault economy then you should shut your plugin down when economyProvider is null.

 

Also if you can post the text of your startup log to make sure Vault sees an economy when you are doing your testing that would be great.