Solved NPE

Hi, so when target is null, the code works, but when they are not null, then it doesnt work. Here is my code:

Code:java

        Player p = (Player) sender;
 
        if(cmd.getName().equalsIgnoreCase("inventory")) {
            if(args.length == 0) {
                p.sendMessage(PREFIX + "Usage = /inventory -o <player>");
            }
            else if(args.length == 1) {
                p.sendMessage(PREFIX + "Usage = /inventory -o <player>");
            }
            else if(args.length == 2) {
                if(p.hasPermission("inventorymenu.open")) {
                    Player target = Bukkit.getServer().getPlayer(args[1]);
                    if(target == null) {
                        p.sendMessage(PREFIX + "Could not find player " + args[1]);
                        return true;
                    }
                    else GUI.getGUIClass().openGadgetGUI(target, p); //LINE 52
                }
            }
        }
        return true;

Stack trace:

http://gyazo.com/3ebba219bd597b47892cac3394bcecdd

GUI class:

Code:java

package org.zodiactheories.healthmenu;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.scheduler.BukkitRunnable;
public class GUI implements Listener {
 
    private static GUI guiclass;
 
    public static GUI getGUIClass() {
        return guiclass;
    }
 
    public final List<Player> sender = new ArrayList<>();
    public final List<Player> target = new ArrayList<>();
 
    public void openGadgetGUI(Player p, Player guisender) {
 
        Inventory inv = Bukkit.createInventory(null, 9, ChatColor.GREEN + "Inventory 1");
 
        ItemStack helmet = p.getInventory().getHelmet();
        ItemStack chestplate = p.getInventory().getChestplate();
        ItemStack leggings = p.getInventory().getLeggings();
        ItemStack boots = p.getInventory().getBoots();
        ItemStack potion = new ItemStack(Material.POTION);
        ItemMeta potionMeta = potion.getItemMeta();
 
        potionMeta.setDisplayName(ChatColor.GOLD + p.getActivePotionEffects().toString());
        potion.setItemMeta(potionMeta);
        int health = (int) p.getHealth();
        int hunger = (int) p.getFoodLevel();
 
        ItemStack hearts = new ItemStack(Material.GOLD_NUGGET, health);
        ItemStack food = new ItemStack(Material.RAW_FISH, hunger);
 
        ItemStack nextgui = new ItemStack(Material.REDSTONE);
        ItemMeta meta = nextgui.getItemMeta();
        meta.setDisplayName(ChatColor.GREEN + "Click me to go to the Player's inventory!");
        nextgui.setItemMeta(meta);
 
        inv.setItem(0, helmet);
        inv.setItem(1, chestplate);
        inv.setItem(2, leggings);
        inv.setItem(3, boots);
        inv.setItem(4, nextgui);
        inv.setItem(6, potion);
        inv.setItem(7, hearts);
        inv.setItem(8, food);
        guisender.openInventory(inv);
        target.add(p);
        sender.add(guisender);
    }

Thanks

 

Doesn't look like you are assigning a value to guiclass...side note: any particular reason you are using a singleton pattern here?

 

Is your guiclass variable initialised somewhere?

 

You never define guiclass.

EDIT: Oh god, double ninja'd.

 

Rocoty theguynextdoor Necrodoom

Dammit. I made a vow that I would never miss any initialization mistakes again.

Rocoty

I just find them easy to work with