Not shooting snowball

Well, basically I am working on a plugin that shoots a snowball if a variable is true and the slot is equal to something, is it possible someone could find my error and why it's not shooting a snowball.


package me.grasshoppermatt.mainpackage;

import org.bukkit.Effect;
import org.bukkit.entity.Player;
import org.bukkit.entity.Snowball;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;

public class MainEvents implements Listener {

boolean snowball1 = true;

@EventHandler
public void PlayerInteractEvent(PlayerInteractEvent e) {
Player p = e.getPlayer();
if(snowball1 == true) {
if(!(e.getAction() == Action.RIGHT_CLICK_BLOCK)) {
if(p.getInventory().getHeldItemSlot() == 1) {
Snowball snowball = e.getPlayer().launchProjectile(Snowball.class);
snowball.getWorld().playEffect(e.getPlayer().getLocation(), Effect.SMOKE, 55);
}
}
}
}

 

Your code is saying if they did not right click a block, and if they are on slot 1, launch a snowball? I believe you need to return true after

Code:java

if(!(e.getAction() == Action.RIGHT_CLICK_BLOCK)) {

So your code would look like this:

Code:java

package me.grasshoppermatt.mainpackage;
 
import org.bukkit.Effect;
import org.bukkit.entity.Player;
import org.bukkit.entity.Snowball;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
 
public class MainEvents implements Listener {
 
boolean snowball1 = true;
 
@EventHandler
public void PlayerInteractEvent(PlayerInteractEvent e) {
Player p = e.getPlayer();
if(snowball1 == true) {
if(!(e.getAction() == Action.RIGHT_CLICK_BLOCK)) {
return true;
}
if(p.getInventory().getHeldItemSlot() == 1) {
Snowball snowball = e.getPlayer().launchProjectile(Snowball.class);
snowball.getWorld().playEffect(e.getPlayer().getLocation(), Effect.SMOKE, 55);
}
}
}

Also. If this is your main class, you need to have an onEnable and register events:

Code:java

 public void onEnable(){
            getServer().getPluginManager().registerEvents(this, this);
    }

Hope this helped.

 

Thanks for that Catch I also had the Main class do that have a nice day man.

Also, you can't return a void true.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Cant return void at all

 

grasshopperMatt123
You are right, you have to change the ! Statement to just a normal statement.

 

Onlineids MooshViolet You can't? Whatever happened to

PHP:

if(e.getAction() != Action.RIGHT_CLICK_BLOCK) {
    return;
}

 

Onlineids
You can return a void. But because the type void means nothing, you just end the method with that. So if you don't want the code behind a certain line to be executed, use return;

 

Exactly what I was hinting at, you can return a void just not with a true false ect.